reduce memory needs for main menu.

Author: FiveTeethless

lib/3rd_party_adapters/LVGL/GuiEngine.cpp

@@ -211,8 +211,8 @@ void GuiEngine::refresh()
  * 
  * @param menuList - list of items for the menu to display
  */
-void GuiEngine::drawMenu(const MenuItemList *menuList)
+void GuiEngine::drawMenu(const MenuItemList &menuList)
 {
-    CurrentScreen = std::make_shared<ScreenMenu>(*menuList);
+    CurrentScreen = std::make_shared<ScreenMenu>(menuList);
     CurrentScreen->draw();
 }

lib/3rd_party_adapters/LVGL/GuiEngine.hpp

@@ -23,7 +23,7 @@ class GuiEngine : public IGuiEngine
     GuiEngine(const Configuration &configuration, TwoWire &i2c);
     virtual void registerKeyPad(IKeypad *keypad) override;
     virtual void refresh() override;
-    virtual void drawMenu(const MenuItemList *menuList) override;
+    virtual void drawMenu(const MenuItemList &menuList) override;
 
     Adafruit_SSD1306 display;
 

lib/3rd_party_adapters/LVGL/Screen.cpp

@@ -130,7 +130,7 @@ static void ScreenMenu_value_cb(lv_event_t *e)
  * 
  * @param itemList - List of items to be drawn with this menu
  */
-ScreenMenu::ScreenMenu(MenuItemList itemList)
+ScreenMenu::ScreenMenu(const MenuItemList &itemList)
     : _List{itemList}
 {
 }

lib/3rd_party_adapters/LVGL/Screen.hpp

@@ -29,13 +29,13 @@ class IScreen
 class ScreenMenu final : public IScreen
 {
   public:
-    ScreenMenu(MenuItemList itemList);
+    ScreenMenu(const MenuItemList &itemList);
     ~ScreenMenu() override = default;
 
     void draw() override;
 
   private:
-    const MenuItemList _List;
+    const MenuItemList &_List;
 };
 
 /**

lib/application_business_rules/user_interaction/IGuiEngine.hpp

@@ -12,5 +12,5 @@ class IGuiEngine
   public:
     virtual void registerKeyPad(IKeypad *keypad) = 0;
     virtual void refresh() = 0;
-    virtual void drawMenu(const MenuItemList *menuList) = 0;
+    virtual void drawMenu(const MenuItemList &menuList) = 0;
 };

lib/application_business_rules/user_interaction/Menu.cpp

@@ -56,7 +56,7 @@ Menu::Menu(IGuiEngine &guiEngineToUse, IKeypad &keypad)
     subMenu3.push_back(&Sub3Button2);
 
     /* draw the main menu with GuiEngine */
-    guiEngine.drawMenu(&mainMenu);
+    guiEngine.drawMenu(mainMenu);
 }
 
 /**