count last frame in when measuring the close_time

Author: zh1peng

docs/conf.py

@@ -32,6 +32,8 @@
     "sphinx.ext.autodoc",              # Auto pull docstrings
     "sphinx.ext.napoleon",             # Google/Numpy style docstrings
     "sphinx_autodoc_typehints",        # Type hints in docs
+    "sphinx.ext.viewcode",
+    "sphinx.ext.githubpages",
 ]
 
 # Allow both .rst and .md files

psyflow/StimUnit.py

@@ -488,24 +488,32 @@ def show(
         self.set_state(flip_time=flip_time)
 
         # --- Frame-based visual presentation ---
-        tclock = core.Clock()
-        tclock.reset()
-
         visual_stims = [s for s in self.stimuli if hasattr(s, "draw") and callable(s.draw)]
         n_frames = int(round(t_val / self.frame_time))
 
         for frame_i in range(n_frames - 1):
             for stim in visual_stims:
                 stim.draw()
-            if frame_i == n_frames - 2:
-                self.win.callOnFlip(
-                    self.set_state,
-                    offset_trigger=offset_trigger,
-                    close_time=self.clock.getTime(),
-                    close_time_global=core.getAbsTime()
-                )
-                self.win.callOnFlip(self.send_trigger, offset_trigger)
+            # if frame_i == n_frames - 2: # if it is the last frame, schedule the offset
+            #     self.win.callOnFlip(
+            #         self.set_state,
+            #         offset_trigger=offset_trigger,
+            #         close_time=self.clock.getTime(),
+            #         close_time_global=core.getAbsTime()
+            #     )
+            #     self.win.callOnFlip(self.send_trigger, offset_trigger)
             self.win.flip()
+        self.set_state(
+            close_time=self.clock.getTime(),
+            close_time_global=core.getAbsTime()
+        )
+        self.send_trigger(offset_trigger)
+        #         self.set_state,
+        #         offset_trigger=offset_trigger,
+        #         close_time=self.clock.getTime(),
+        #         close_time_global=core.getAbsTime()
+        #     )
+        #     self.win.callOnFlip(self.send_trigger, offset_trigger)
 
         self.log_unit()
         return self

psyflow/templates/task2doc_prompt.txt

@@ -11,16 +11,15 @@ For each section below, include every detail—parameters, timings, flow logic,
 
 **IMPORTANT TABLE FORMATTING RULES (apply to every table in sections 1–4):**  
 1. Always start with a header row and a separator row, for example:  
-2. After the separator row, include **one blank line** before listing data rows.  
-3. Do **not** omit the blank line—this ensures the table closes properly.  
-4. Do **not** add extra pipes or indentation.
+2. Do **not** omit the blank line—this ensures the table closes properly.  
+3. Do **not** add extra pipes or indentation.
 
 # Task Name  
 Extract the full task name and use it as the document’s top-level heading.
 
 ## (Meta Information) we don't need the meta information as header, we just show table  
-• Render as a Markdown table with two columns: Field and Value.  
-• Include this header and separator row exactly, then a blank line:  
+• Render as a Markdown table with two columns: Field and Value. 
+• Include this header and separator row exactly
   | Field                | Value                        |  
   |----------------------|------------------------------|  
 
@@ -30,9 +29,10 @@ Extract the full task name and use it as the document’s top-level heading.
   - URL / Repository  
   - Short Description  
   - Created By  
-  - Date Created  
+  - Date Updated 
   - PsyFlow Version  
   - PsychoPy Version  
+  Try your best to fill the table, if you are not sure leave them as blank.
 
 ## 1. Task Overview  
 • One concise paragraph summarizing the goal and design of the task.