Updated code to make it far easier.

Easier to send the data

Author: susrisha

GoInfoGame/GoInfoGame/AppQuestManager.swift

@@ -64,9 +64,10 @@ class AppQuestManager {
                 if quest.isApplicable(element: node){
                     // Create a duplicate of the quest
                     // Create a display Unit
-                    let unit = DisplayUnitWithCoordinate(displayUnit: quest.displayUnit, coordinateInfo:  CLLocationCoordinate2D(latitude: node.position.latitude, longitude: node.position.longitude), id: node.id)
+                    let duplicateQuest = quest.copyWithElement(element: node)
+                    let unit = DisplayUnitWithCoordinate(displayUnit: duplicateQuest.displayUnit, coordinateInfo:  CLLocationCoordinate2D(latitude: node.position.latitude, longitude: node.position.longitude), id: node.id)
                     displayUnits.append(unit)
-                    nodeQuests.append(quest)
+                    nodeQuests.append(duplicateQuest)
                     break
                 }
             }
@@ -77,15 +78,16 @@ class AppQuestManager {
                 if quest.isApplicable(element: way){
                     // Create a duplicate of the quest
                     // Need to add another here.
+                    let duplicateQuest = quest.copyWithElement(element: way)
                     let position  = dbInstance.getCenterForWay(id: String(way.id)) ?? CLLocationCoordinate2D()
-                    let unit = DisplayUnitWithCoordinate(displayUnit: quest.displayUnit, coordinateInfo: position, id: way.id)
+                    let unit = DisplayUnitWithCoordinate(displayUnit: duplicateQuest.displayUnit, coordinateInfo: position, id: way.id)
                     displayUnits.append(unit)
 //                    if(quest is SideWalkWidth){
 //                        if let q = quest as? SideWalkWidth {
 //                            q.assignAnsweringHandler()
 //                        }
 //                    }
-                    wayQuests.append(quest)
+                    wayQuests.append(duplicateQuest)
                     break
                 }
             }

GoInfoGame/GoInfoGame/DataBase/DatabaseConnector.swift

@@ -23,6 +23,11 @@ class DatabaseConnector {
         }
     }
 
+    /**
+        Saves the OPElements into the database. This method does not remove the old data. However, it updates the
+         data with same id
+        @param elements  List of OPElement
+     */
     func saveElements(_ elements: [OPElement]) {
         // Save the elements appropriately
         // Get the ways and nodes out
@@ -84,7 +89,10 @@ class DatabaseConnector {
             print("Elements to be skipped or something happened")
         }
     }
-    
+    /**
+            Earlier implementation of saveElements. This used to save only the Way type of objects.
+            This is not used anymore
+     */
     func saveElements(_ elements: [OPWay]) {
         do {
             try realm.write {
@@ -128,15 +136,25 @@ class DatabaseConnector {
             print("Error saving elements to Realm: \(error)")
         }
     }
-    
+    /**
+     Fetches all the StoredNodes in the Database
+     @returns a Results object containing StoredNodes
+     */
     func getNodes() -> Results<StoredNode> {
         return realm.objects(StoredNode.self)
     }
-    
+    /**
+    Fetches all the storedWays in the Database
+     @returns a Results object containing StoredWay
+     */
     func getWays() -> Results<StoredWay> {
         return realm.objects(StoredWay.self)
     }
-    
+    /**
+     Fetches the center of a given StoredWay
+     @param id String value of the way ID
+     @returns CLLocationCoordinate2D the center location
+     */
     func getCenterForWay(id: String) -> CLLocationCoordinate2D? {
         // Get all the objects for the way
         guard let way = realm.object(ofType: StoredWay.self, forPrimaryKey: Int(id))  else {
@@ -159,15 +177,28 @@ class DatabaseConnector {
         return CLLocationCoordinate2D(latitude: 0, longitude: 0)
 
     }
-    
+    /**
+     Fetches a single node from the database
+     @param id: String value of the node ID
+     @return StoredNode
+     */
     func getNode(id:String) -> StoredNode? {
         return realm.object(ofType: StoredNode.self, forPrimaryKey: Int(id))
     }
-    
+    /**
+     Fetches single Way from the database
+     @param id: String value of the wayId
+     @return StoredWay
+     */
     func getWay(id: String) -> StoredWay? {
         return realm.object(ofType: StoredWay.self, forPrimaryKey: Int(id))
     }
-    
+    /**
+     Adds tags to the existing node and stores the same
+     @param id : String value of the node ID
+     @param tags [String:String] map of the added tags
+     @return StoredNode
+     */
     func addNodeTags(id: String, tags:[String: String]) -> StoredNode? {
         guard let theNode = getNode(id: id) else { return nil }
         do {
@@ -185,7 +216,12 @@ class DatabaseConnector {
         return theNode
     }
 
-    
+    /**
+     Adds tags to the existing way and stores the same
+     @param id: String value of the way ID
+     @param tags `[String:String]` map of the added tags
+     @return `StoredWay`
+     */
     func addWayTags(id: String, tags:[String:String]) -> StoredWay? {
         guard let theWay = getWay(id: id) else { return nil }
 
@@ -196,7 +232,13 @@ class DatabaseConnector {
         realm.add(theWay, update: .all) // Test this
         return theWay
     }
-    
+    /**
+     Creates a changeset for an element with specific ID. This does not store the updated nodes. That is to be done separately
+     - parameter id: String id of the changed element
+     - parameter type: StoredElementEnum type of the changed element (either way or node)
+     - parameter tags [String:String] tags changed with this
+     - Returns: An instance of `StoredChangeset`
+        */
     func createChangeset(id:String, type: StoredElementEnum, tags:[String:String]) -> StoredChangeset? {
         let storedChangeset = StoredChangeset()
         storedChangeset.elementId = id
@@ -215,15 +257,20 @@ class DatabaseConnector {
         }
         return storedChangeset
     }
-    
+    /// Fetches the changeset objects from the database
+    /// - parameter synced: Optional variable of whether synced or non synced
+    /// - Returns: an instance of `Results<StoredChangeset>`
     func getChangesets(synced: Bool = false) -> Results<StoredChangeset> {
 
         if (synced == true){
             return  realm.objects(StoredChangeset.self).where({$0.changesetId != -1 })
         }
         return realm.objects(StoredChangeset.self).where({$0.changesetId == -1 })
     }
-    
+    /// Assigns changesetId for a stored changeset
+    /// - parameter obj: Internal id for the changeset in the database (unique ID)
+    /// - parameter changesetId: Assigned changeset ID from the server
+    /// - Returns updated `StoredChangeset`
     func assignChangesetId(obj:String, changesetId: Int) -> StoredChangeset? {
         guard let changeset = realm.object(ofType: StoredChangeset.self, forPrimaryKey: obj) else {
             return nil

GoInfoGame/GoInfoGame/quests/BusStopLit/BusStopLit.swift

@@ -34,8 +34,9 @@ class BusStopLit: Quest{
     var wikiLink: String = ""
     var changesetComment: String = ""
     var form: AnyView = AnyView(BusStopLitForm())
-    var relationData: Any? = nil
+    var relationData: Element? = nil
     func onAnswer(answer: WayLitOrIsStepsAnswer) {
+        
     }
     var displayUnit: DisplayUnit {
         DisplayUnit(title: self.title, description: "",parent: self,sheetSize:.SMALL )
@@ -54,4 +55,10 @@ class BusStopLit: Quest{
             return _internalExpression
         }
     }
+    
+    func copyWithElement(element: Element) -> any Quest {
+        let q = BusStopLit()
+        q.relationData = element
+        return q
+    }
 }

GoInfoGame/GoInfoGame/quests/BusStopLit/BusStopLitForm.swift

@@ -11,8 +11,6 @@ import SwiftUI
 struct BusStopLitForm: View, QuestForm {
     var action: ((Bool) -> Void)?
 
-    func applyAnswer(answer: Bool) {
-    }
     typealias AnswerClass = Bool
     var body: some View {
         VStack{

GoInfoGame/GoInfoGame/quests/CrossingMarking/CrossMarking.swift

@@ -20,7 +20,7 @@ class CrossMarking :Quest {
     var wikiLink: String = ""
     var changesetComment: String = ""
     var form: AnyView = AnyView(CrossMarkingForm())
-    var relationData: Any? = nil
+    var relationData: Element? = nil
     var displayUnit: DisplayUnit {
         DisplayUnit(title: self.title, description: "",parent: self,sheetSize:.MEDIUM )
     }
@@ -38,6 +38,12 @@ class CrossMarking :Quest {
             return _internalExpression
         }
     }
+    
+    func copyWithElement(element: Element) -> any Quest {
+        let q = CrossMarking()
+        q.relationData = element
+        return q
+    }
 }
 
 enum CrossingAnswer: String, CaseIterable {

GoInfoGame/GoInfoGame/quests/CrossingMarking/CrossMarkingForm.swift

@@ -13,8 +13,7 @@ struct CrossMarkingForm : View,QuestForm{
 
     @State private var selectedAnswer: CrossingAnswer?
     @State private var showAlert = false
-    func applyAnswer(answer: CrossingAnswer) {
-    }
+    
     typealias AnswerClass = CrossingAnswer
     let items = [
         TextItem(value: CrossingAnswer.yes, titleId: LocalizedStrings.questCrossingYes.localized),
@@ -30,7 +29,7 @@ struct CrossMarkingForm : View,QuestForm{
                     ForEach(items, id: \.titleId) { item in
                         RadioItem(textItem: item, isSelected: item.value == selectedAnswer) {
                             selectedAnswer = item.value
-                            applyAnswer(answer: selectedAnswer ?? .no)
+                            action?(selectedAnswer ?? .no)
                         }
                     }}.padding(.top,10)
                 Divider()

GoInfoGame/GoInfoGame/quests/Handrail/HandRail.swift

@@ -44,7 +44,7 @@ class HandRail: QuestBase,Quest {
         }
     }
 
-    var relationData: Any? = nil
+    var relationData: Element? = nil
 
     var displayUnit: DisplayUnit {
         DisplayUnit(title: self.title, description: "",parent: self,sheetSize: .SMALL)
@@ -67,4 +67,10 @@ class HandRail: QuestBase,Quest {
             onAnswer(answer: yesNo)
         })
     }
+    
+    func copyWithElement(element: Element) -> any Quest {
+        let q = HandRail()
+        q.relationData = element
+        return q
+    }
 }

GoInfoGame/GoInfoGame/quests/Handrail/HandRailForm.swift

@@ -11,10 +11,6 @@ struct HandRailForm: View, QuestForm {
     var action: ((Bool) -> Void)?
 
 
-    func applyAnswer(answer: Bool) {
-        
-    }
-    
     typealias AnswerClass = Bool
 
 

GoInfoGame/GoInfoGame/quests/QuestProtocols.swift

@@ -19,15 +19,35 @@ protocol Quest {
     var wikiLink: String {get}
     var changesetComment: String {get}
     var form : AnyView {get}
-    var relationData : Any? {get set}
+    var relationData : Element? {get set}
     func onAnswer(answer:AnswerClass)
-    
     var displayUnit: DisplayUnit { get}
     var filterExpression : ElementFilterExpression? { get  }
+    
+    func copyWithElement(element: Element) -> any Quest // Not sure.
 }
 
 class QuestBase {
    public var internalForm: (any QuestForm)? = nil
+    // Add a custom implementation
+    
+   public func updateTags(id: Int64, tags:[String:String], type: ElementType){
+       // Convert from ElementType enum to StoredElementEnum
+       let storedElementType: StoredElementEnum = type == .way ? .way : .node
+       let storedId = String(id)
+       // Create a changeset
+       let newChangeset = DatabaseConnector.shared.createChangeset(id: storedId, type: storedElementType, tags: tags)
+       switch (storedElementType){
+       case .way:
+           DatabaseConnector.shared.addWayTags(id: storedId, tags: tags)
+       case .node:
+           DatabaseConnector.shared.addNodeTags(id: storedId, tags: tags)
+       case .unknown:
+           print("Unknown Stored element type received")
+       }
+       // Sync using datasyncmanager
+
+    }
 
 }
 // Adds default method and implementation
@@ -49,6 +69,7 @@ extension Quest {
 
         return try? filter.toElementFilterExpression() // This is a costly operation
     }
+    
 }
 
 
@@ -63,8 +84,6 @@ struct DisplayUnit : Identifiable {
 protocol QuestForm {
     associatedtype AnswerClass
 
-    func applyAnswer(answer:AnswerClass)
-    
     var action: ((_ answer:AnswerClass)->Void)? {get set}
 }
 

GoInfoGame/GoInfoGame/quests/SideWalkValidation/SideWalkValidation.swift

@@ -7,6 +7,7 @@
 
 import Foundation
 import SwiftUI
+import osmparser
 
 class SideWalkValidation :Quest {
     func onAnswer(answer: SideWalkValidationAnswer) {
@@ -18,10 +19,16 @@ class SideWalkValidation :Quest {
     var wikiLink: String = ""
     var changesetComment: String = ""
     var form : AnyView = AnyView(SideWalkValidationForm())
-    var relationData: Any? = nil
+    var relationData: Element? = nil
     var displayUnit: DisplayUnit {
         DisplayUnit(title: self.title, description: "",parent: self,sheetSize:.LARGE )
     }
+    
+    func copyWithElement(element: Element) -> any Quest {
+        let q = SideWalkValidation()
+        q.relationData = element
+        return q
+    }
 }
 enum SideWalkValidationAnswer {
     case left