pass error message to failure closure

Author: Achyut Kumar M

GoInfoGame/GoInfoGame/Login/PasswordAuthenticationViewModel.swift

@@ -16,12 +16,12 @@ class PasswordAuthenticationViewModel: ObservableObject {
         username: String,
         environment: APIEnvironment,
         onSuccess: @escaping () -> Void,
-        onFailure: @escaping () -> Void
+        onFailure: @escaping (String) -> Void
     ) {
         isLoading = true
         errorMessage = ""
 
-        SessionManager.shared.performLogin(username: username, password: password, environment: environment) { success in
+        SessionManager.shared.performLogin(username: username, password: password, environment: environment) { success, error  in
             DispatchQueue.main.async {
                 if success {
                     BiometricAuthManager.authenticate(reason: "Enable biometric login") { result in
@@ -34,14 +34,14 @@ class PasswordAuthenticationViewModel: ObservableObject {
                                 onSuccess()
                             case .failure(let msg), .unavailable(let msg):
                                 self.errorMessage = msg
-                                onFailure()
+                                onFailure("An error occured. Please try again.")
                             }
                         }
                     }
                 } else {
                     self.isLoading = false
                     self.errorMessage = "Invalid username or password."
-                    onFailure()
+                    onFailure("Invalid username or password.")
                 }
             }
         }

GoInfoGame/GoInfoGame/Login/SessionManager.swift

@@ -17,11 +17,11 @@ final class SessionManager: ObservableObject {
 
     var lastLoginPassword: String?
 
-    func performLogin(username: String, password: String, environment: APIEnvironment, completion: @escaping (Bool) -> Void) {
+    func performLogin(username: String, password: String, environment: APIEnvironment, completion: @escaping (Bool, String) -> Void) {
         let userName = KeychainManager.load(.username, for: environment) ?? username
         let postParams = ["username": userName, "password": password]
         guard let postBody = try? JSONSerialization.data(withJSONObject: postParams) else {
-            completion(false)
+            completion(false, "Failed to serialize JSON")
             return
         }
 
@@ -39,13 +39,13 @@ final class SessionManager: ObservableObject {
 
                     self.isLoginSuccessful = true
                     self.hasLoginFailed = false
-                    completion(true)
+                    completion(true, "")
 
                 case .failure(let error):
                     print("Login failed:", error)
                     self.isLoginSuccessful = false
                     self.hasLoginFailed = true
-                    completion(false)
+                    completion(false, "Invalid credentials")
                 }
             }
         }
@@ -68,11 +68,11 @@ final class SessionManager: ObservableObject {
         lastLoginPassword = nil
     }
 
-    func loginWithBiometrics(for environment: APIEnvironment, completion: @escaping (Bool) -> Void) {
+    func loginWithBiometrics(for environment: APIEnvironment, completion: @escaping (Bool, String) -> Void) {
         guard let user = KeychainManager.load(.username, for: environment),
               let pass = KeychainManager.load(.password, for: environment) else {
             print(" Missing credentials for biometric login")
-            completion(false)
+            completion(false, "Missing credentials for biometric login")
             return
         }
         performLogin(username: user, password: pass, environment: environment, completion: completion)

GoInfoGame/GoInfoGame/Login/ViewModel/PosmLoginViewModel.swift

@@ -40,7 +40,7 @@ class PosmLoginViewModel: ObservableObject {
 
         isLoading = true
 
-        SessionManager.shared.performLogin(username: username, password: password, environment: environment) { [weak self] success in
+        SessionManager.shared.performLogin(username: username, password: password, environment: environment) { [weak self] success, error  in
             guard let self = self else { return }
 
             DispatchQueue.main.async {