Skip to content

Commit 05bb80a

Browse files
committed
Docs
1 parent e680d92 commit 05bb80a

File tree

2 files changed

+24
-2
lines changed

2 files changed

+24
-2
lines changed

docker-compose.build.yml

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
#
2+
# This file is only used by the CI/CD pipeline to build/push images to Azure CR.
3+
#
4+
# For any local dev work, see docker-compose.yml and *overrides.yml.
5+
#
6+
17
services:
28
# workspaces FE (Vue app)
39
frontend:
@@ -9,7 +15,10 @@ services:
915
cache_to:
1016
- type=registry,ref=${WS_DOCKER_REGISTRY}/workspaces-frontend:buildcache,mode=max
1117

12-
# these get baked into the JavaScript at build time--so ARGS not ENVS
18+
# WARNING: these get baked into the JavaScript at build time--so ARGS not ENVS
19+
#
20+
# NB: this also makes images environment-specific! (FIXME?)
21+
#
1322
args:
1423
VITE_TDEI_API_URL: ${WS_TDEI_API_URL}
1524
VITE_TDEI_USER_API_URL: ${WS_TDEI_BACKEND_URL}
@@ -86,6 +95,10 @@ services:
8695
# OSM website/OSM API
8796
osm-rails:
8897
image: ${WS_DOCKER_REGISTRY}/workspaces-osm-rails:${ENV}
98+
99+
# These have been commented out so as not to embed these variables in the images themselves
100+
# DO NOT CHANGE THIS PLEASE.
101+
#
89102
# environment:
90103
# RAILS_ENV: production
91104
# SECRET_KEY_BASE: ${WS_OSM_SECRET_KEY_BASE}
@@ -163,7 +176,10 @@ services:
163176
context: ./leaderboard/frontend
164177
dockerfile: Dockerfile
165178

166-
# these get baked into the JavaScript at build time--so ARGS not ENVS
179+
# WARNING: these get baked into the JavaScript at build time--so ARGS not ENVS
180+
#
181+
# NB: this also makes images environment-specific! (FIXME?)
182+
#
167183
args:
168184
VITE_TDEI_API_URL: ${WS_TDEI_API_URL}
169185
VITE_TDEI_USER_API_URL: ${WS_TDEI_BACKEND_URL}

docker-compose.deploy.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
#
2+
# This file is only used by the CI/CD pipeline to deploy images to the environment's VM.
3+
#
4+
# For any local dev work, see docker-compose.yml and *overrides.yml.
5+
#
6+
17
################################################################################
28

39
x-osm-rails-base:

0 commit comments

Comments
 (0)