Skip to content

Commit b3f3386

Browse files
authored
Merge pull request #49 from TaskarCenterAtUW/2205-leaderboard-env-variables
moving env vars out of deploy into build
2 parents 021f7f3 + 26549df commit b3f3386

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

docker-compose.build.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,12 @@ services:
177177
- type=registry,ref=${WS_DOCKER_REGISTRY}/workspaces-leaderboard-frontend:buildcache,mode=max
178178
context: ./leaderboard/frontend
179179
dockerfile: Dockerfile
180-
180+
args:
181+
VITE_TDEI_API_URL: ${WS_TDEI_API_URL}
182+
VITE_TDEI_USER_API_URL: ${WS_TDEI_BACKEND_URL}
183+
VITE_API_URL: ${WS_API_URL}
184+
VITE_OSM_URL: ${WS_OSM_URL}
185+
181186
leaderboard-frontend_tag:
182187
extends: leaderboard-frontend
183188
image: ${WS_DOCKER_REGISTRY}/workspaces-leaderboard-frontend:${CODE_VERSION}

docker-compose.deploy.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -202,11 +202,6 @@ services:
202202
# leaderboard FE/backend
203203
leaderboard-frontend:
204204
image: ${WS_DOCKER_REGISTRY}/workspaces-leaderboard-frontend:${WS_DOCKER_TAG}
205-
environment:
206-
VITE_TDEI_API_URL: ${WS_TDEI_API_URL}
207-
VITE_TDEI_USER_API_URL: ${WS_TDEI_BACKEND_URL}
208-
VITE_API_URL: ${WS_API_URL}
209-
VITE_OSM_URL: ${WS_OSM_URL}
210205
labels:
211206
- traefik.enable=true
212207
- traefik.http.routers.leaderboard-frontend.rule=Host(`${LB_FRONTEND_HOST}`)

0 commit comments

Comments
 (0)