#26 fix bug with basic interrupt abstraction and update example to configure input. Tested fully on AVR.

dave · dave · commit 711ff1aa9fd3 · 2021-04-14T09:13:02.000+01:00
diff --git a/examples/marshalInterrupt/marshalInterrupt.ino b/examples/marshalInterrupt/marshalInterrupt.ino
@@ -34,6 +34,8 @@ void setup() {
     Serial.begin(115200);
     Serial.println("Starting interrupt example");
 
+    pinMode(interruptPin, INPUT_PULLUP);
+
     taskManager.setInterruptCallback(interruptTask);
     taskManager.addInterrupt(&interruptAbstraction, interruptPin, CHANGE);
 }
diff --git a/src/BasicInterruptAbstraction.h b/src/BasicInterruptAbstraction.h
@@ -16,7 +16,7 @@ inline void internalHandleInterrupt(pintype_t pin, RawIntHandler fn, uint8_t mod
 #elif defined(PARTICLE)
     ::attachInterrupt(pin, fn, (InterruptMode)mode);
 #else
-    ::attachInterrupt(pin, fn, mode);
+    ::attachInterrupt(digitalPinToInterrupt(pin), fn, mode);
 #endif // Interrupt mode conditionals
 }
 

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,8 @@ void setup() {`
`34`	`34`	`Serial.begin(115200);`
`35`	`35`	`Serial.println("Starting interrupt example");`
`36`	`36`
	`37`	`+ pinMode(interruptPin, INPUT_PULLUP);`
	`38`	`+`
`37`	`39`	`taskManager.setInterruptCallback(interruptTask);`
`38`	`40`	`taskManager.addInterrupt(&interruptAbstraction, interruptPin, CHANGE);`
`39`	`41`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ inline void internalHandleInterrupt(pintype_t pin, RawIntHandler fn, uint8_t mod`
`16`	`16`	`#elif defined(PARTICLE)`
`17`	`17`	`::attachInterrupt(pin, fn, (InterruptMode)mode);`
`18`	`18`	`#else`
`19`		`- ::attachInterrupt(pin, fn, mode);`
	`19`	`+ ::attachInterrupt(digitalPinToInterrupt(pin), fn, mode);`
`20`	`20`	`#endif // Interrupt mode conditionals`
`21`	`21`	`}`
`22`	`22`