Skip to content

Commit 7f1bc35

Browse files
author
dave
committed
#30 small fix up on enable task
1 parent eca4e49 commit 7f1bc35

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

examples/longSchedule/longSchedule.ino

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public:
2525

2626
void exec() override {
2727
callCount++;
28-
Serial.print("Called my task executable");
28+
Serial.print("Called my task executable ");
2929
Serial.println(callCount);
3030

3131
taskManager.setTaskEnabled(taskToSuspend, enableTask);
@@ -48,7 +48,9 @@ void setup() {
4848
Serial.begin(115200);
4949

5050
Serial.println("Started long schedule example");
51-
// First two long schedules are global variables. If you use references to a variable like this it must be global
51+
52+
// First two long schedules are global variables.
53+
// IMPORTANT NOTE: If you use references to a variable like this THEY MUST BE GLOBAL
5254
taskManager.registerEvent(&hourAndHalfSchedule);
5355
taskManager.registerEvent(&onceADaySchedule);
5456

src/TaskTypes.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ unsigned long TimerTask::microsFromNow() {
8585
void TimerTask::execute() {
8686
RunningState runningState(this);
8787

88+
if(!isEnabled()) return;
89+
8890
auto execType = (ExecutionType) (executeMode & EXECTYPE_MASK);
8991
switch (execType) {
9092
case EXECTYPE_EVENT:

src/TmLongSchedule.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ uint32_t makeDaySchedule(int days, int hours) {
1818
}
1919

2020
TmLongSchedule::TmLongSchedule(uint32_t milliScheduleNext, Executable* toExecute) : milliSchedule(milliScheduleNext),
21-
theExecutable(toExecute), lastScheduleTime(0), isTimerFn(true) { }
21+
theExecutable(toExecute), lastScheduleTime(0), isTimerFn(false) { }
2222

2323
TmLongSchedule::TmLongSchedule(uint32_t milliScheduleNext, TimerFn toExecute) : milliSchedule(milliScheduleNext),
2424
fnCallback(toExecute), lastScheduleTime(0), isTimerFn(true) { }

0 commit comments

Comments
 (0)