#436 test coverage

Author: dave

embedCONTROLCore/src/main/java/com/thecoderscorner/embedcontrol/core/controlmgr/color/ControlColor.java

@@ -3,6 +3,10 @@
 import com.thecoderscorner.menu.domain.state.PortableColor;
 import javafx.scene.paint.Color;
 
+import java.util.Map;
+
+import static com.thecoderscorner.embedcontrol.core.controlmgr.color.ConditionalColoring.ColorComponentType.*;
+
 /**
  * This represents a color for a control, it has a background and a foreground in portable color format. Portable color
  * is an API level construct that is not tied to any implementation.
@@ -24,6 +28,26 @@ public class ControlColor {
     public static final PortableColor BLUE = new PortableColor(0, 0, 255);
     public static final PortableColor GREEN = new PortableColor(0, 255, 0);
 
+    public final static Map<ConditionalColoring.ColorComponentType, ControlColor> DEFAULT_LIGHT_COLORS = Map.ofEntries(
+            Map.entry(CUSTOM, new ControlColor("#000000", "#0A81F7")),
+            Map.entry(TEXT_FIELD, new ControlColor(BLACK, WHITE)),
+            Map.entry(HIGHLIGHT, new ControlColor("#000000", "#0A81F7")),
+            Map.entry(BUTTON, new ControlColor(WHITE, DARK_SLATE_BLUE)),
+            Map.entry(DIALOG, new ControlColor(WHITE, DARK_BLUE)),
+            Map.entry(ERROR, new ControlColor(WHITE, RED)),
+            Map.entry(PENDING, new ControlColor(LIGHT_GRAY, GREY))
+    );
+
+    public final static Map<ConditionalColoring.ColorComponentType, ControlColor> DEFAULT_DARK_COLORS = Map.ofEntries(
+            Map.entry(CUSTOM, new ControlColor("#FEFFFF", "#2D1E8C")),
+            Map.entry(TEXT_FIELD, new ControlColor("#FEFFFF", "#000")),
+            Map.entry(HIGHLIGHT, new ControlColor("#FEFFFF", "#9D5BBA")),
+            Map.entry(BUTTON, new ControlColor("#FEFFFF", "#33084A")),
+            Map.entry(DIALOG, new ControlColor("#FEFFFF", "#214F82")),
+            Map.entry(ERROR, new ControlColor("#FEFFFF", "#A80B0D")),
+            Map.entry(PENDING, new ControlColor(LIGHT_GRAY, DARK_GREY))
+    );
+
     private PortableColor fg;
     private PortableColor bg;
     private boolean inUse;

embedCONTROLCore/src/main/java/com/thecoderscorner/embedcontrol/core/service/GlobalSettings.java

@@ -17,25 +17,6 @@
  * font sizes, control colors, and other setup values.
  */
 public class GlobalSettings {
-
-    final static Map<ConditionalColoring.ColorComponentType, ControlColor> DEFAULT_LIGHT_COLORS = Map.ofEntries(
-            Map.entry(CUSTOM, new ControlColor("#000000", "#0A81F7")),
-            Map.entry(TEXT_FIELD, new ControlColor(BLACK, WHITE)),
-            Map.entry(HIGHLIGHT, new ControlColor("#000000", "#0A81F7")),
-            Map.entry(BUTTON, new ControlColor(WHITE, DARK_SLATE_BLUE)),
-            Map.entry(DIALOG, new ControlColor(WHITE, DARK_BLUE)),
-            Map.entry(ERROR, new ControlColor(WHITE, RED)),
-            Map.entry(PENDING, new ControlColor(LIGHT_GRAY, GREY))
-    );
-    final static Map<ConditionalColoring.ColorComponentType, ControlColor> DEFAULT_DARK_COLORS = Map.ofEntries(
-            Map.entry(CUSTOM, new ControlColor("#FEFFFF", "#2D1E8C")),
-            Map.entry(TEXT_FIELD, new ControlColor("#FEFFFF", "#000")),
-            Map.entry(HIGHLIGHT, new ControlColor("#FEFFFF", "#9D5BBA")),
-            Map.entry(BUTTON, new ControlColor("#FEFFFF", "#33084A")),
-            Map.entry(DIALOG, new ControlColor("#FEFFFF", "#214F82")),
-            Map.entry(ERROR, new ControlColor("#FEFFFF", "#A80B0D")),
-            Map.entry(PENDING, new ControlColor(LIGHT_GRAY, DARK_GREY))
-    );
     private static int globalFontSize = 14;
 
     private ControlColor updateColor;

tcMenuGenerator/src/test/java/com/thecoderscorner/menu/editorint/uitests/uimenuitem/UIActionItemAndCoreTest.java

@@ -12,6 +12,9 @@
 import com.thecoderscorner.menu.domain.Rgb32MenuItemBuilder;
 import com.thecoderscorner.menu.domain.state.MenuTree;
 import com.thecoderscorner.menu.editorui.generator.core.VariableNameGenerator;
+import com.thecoderscorner.menu.persist.LocaleMappingHandler;
+import com.thecoderscorner.menu.persist.PropertiesLocaleEnabledHandler;
+import com.thecoderscorner.menu.persist.SafeBundleLoader;
 import javafx.application.Platform;
 import javafx.scene.control.TextField;
 import javafx.stage.Stage;
@@ -24,6 +27,11 @@
 import org.testfx.framework.junit5.Start;
 import org.testfx.matcher.control.TextInputControlMatchers;
 
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.Comparator;
 import java.util.HashSet;
 import java.util.Set;
 
@@ -36,13 +44,21 @@
 @ExtendWith(ApplicationExtension.class)
 public class UIActionItemAndCoreTest extends UIMenuItemTestBase {
 
+    private Path tempPath;
+
     @Start
-    public void setup(Stage stage) {
+    public void setup(Stage stage) throws IOException {
+        tempPath = Files.createTempDirectory("i18ntest");
         init(stage);
     }
 
     @AfterEach
-    protected void closeWindow() {
+    protected void closeWindow() throws Exception {
+        Files.walk(tempPath)
+                .sorted(Comparator.reverseOrder())
+                .map(Path::toFile)
+                .forEach(File::delete);
+
         Platform.runLater(() -> stage.close());
     }
 
@@ -190,4 +206,14 @@ void testSelectingAndClearingReadonlyLocal(FxRobot robot) throws InterruptedExce
         assertTrue(captor.getValue().isReadOnly());
         assertTrue(captor.getValue().isLocalOnly());
     }
+
+    @Override
+    protected LocaleMappingHandler getTestLocaleHandler() throws IOException {
+        var coreFile = tempPath.resolve("temp.properties");
+        Files.writeString(coreFile, """
+                menu.item.name=hello world
+                """);
+
+        return new PropertiesLocaleEnabledHandler(new SafeBundleLoader(tempPath, "temp"));
+    }
 }

tcMenuGenerator/src/test/java/com/thecoderscorner/menu/editorint/uitests/uimenuitem/UIMenuItemTestBase.java

@@ -33,6 +33,7 @@
 import org.testfx.api.FxRobot;
 import org.testfx.matcher.control.TextInputControlMatchers;
 
+import java.io.IOException;
 import java.util.Optional;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeUnit;
@@ -120,11 +121,15 @@ protected void createMainPanel(Optional<UIMenuItem<?>> uiSubItem) throws Interru
         Platform.runLater(() -> {
             BorderPane borderLayout = new BorderPane();
             borderLayout.setMinSize(500, 500);
-            borderLayout.centerProperty().set(uiSubItem.get().initPanel(menuTree, LocaleMappingHandler.NOOP_IMPLEMENTATION));
+            borderLayout.centerProperty().set(uiSubItem.get().initPanel(menuTree, getTestLocaleHandler()));
             dialogPane.getChildren().add(borderLayout);
             stage.show();
             latch.countDown();
         });
         if(!latch.await(2000, TimeUnit.MILLISECONDS)) throw new IllegalStateException("panel timeout");
     }
+
+    protected LocaleMappingHandler getTestLocaleHandler() throws IOException {
+        return LocaleMappingHandler.NOOP_IMPLEMENTATION;
+    }
 }