Skip to content

Commit efd36cb

Browse files
committed
#436 more testing
1 parent 446e205 commit efd36cb

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

tcMenuGenerator/src/main/java/com/thecoderscorner/menu/editorui/uimodel/UIMenuItem.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@ public GridPane initPanel(MenuTree tree, LocaleMappingHandler handler) {
146146
nameField.setId("nameField");
147147
nameField.setTooltip(new Tooltip("The name of the menu item as shown on the device and sent remotely"));
148148
nameTranslation = new Label(localHandler.getFromLocaleWithDefault(nameField.getText(), nameField.getText()));
149+
nameTranslation.setId("nameTranslation");
149150
if(localHandler.isLocalSupportEnabled()) {
150151
grid.add(nameField, 1, idx);
151152
grid.add(nameTranslation, 2, idx);

tcMenuGenerator/src/test/java/com/thecoderscorner/menu/editorint/uitests/uimenuitem/UIActionItemAndCoreTest.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import org.testfx.api.FxRobot;
2626
import org.testfx.framework.junit5.ApplicationExtension;
2727
import org.testfx.framework.junit5.Start;
28+
import org.testfx.matcher.control.LabeledMatchers;
2829
import org.testfx.matcher.control.TextInputControlMatchers;
2930

3031
import java.io.File;
@@ -82,12 +83,15 @@ void testEnteringAcceptableValuesIntoActionEditor(FxRobot robot) throws Interrup
8283
writeIntoFunctionFieldAndVerifyOK(robot, "öôóòLatin");
8384
writeIntoFunctionFieldAndVerifyOK(robot, "onChange");
8485

86+
writeIntoField(robot, "nameField", "%menu.item.name");
87+
verifyThat("#nameTranslation", LabeledMatchers.hasText("hello world"));
88+
8589
verifyThatThereAreNoErrorsReported();
8690

8791
ArgumentCaptor<MenuItem> captor = ArgumentCaptor.forClass(MenuItem.class);
8892
verify(mockedConsumer, atLeastOnce()).accept(isA(ActionMenuItem.class), captor.capture());
8993
assertEquals(-1, captor.getValue().getEepromAddress());
90-
assertEquals("One Shot", captor.getValue().getName());
94+
assertEquals("%menu.item.name", captor.getValue().getName());
9195
assertEquals("onChange", captor.getValue().getFunctionName());
9296
}
9397

@@ -163,6 +167,9 @@ void testEnteringBadValuesIntoBaseEditor(FxRobot robot) throws InterruptedExcept
163167
tryToEnterBadValueIntoField(robot, "nameField", "variableField", "",
164168
"Name: field must be populated");
165169

170+
tryToEnterBadValueIntoField(robot, "nameField", "variableField", "%unknown",
171+
"WARNING Name: no locale entry in bundle");
172+
166173
tryToEnterBadValueIntoField(robot, "functionNameTextField", "variableField", "name spaces",
167174
"Field must use only letters, digits, and '_'");
168175

0 commit comments

Comments
 (0)