Extract DefaultWorkerSettings.

Author: johnteee

worker/pool.go

@@ -32,19 +32,40 @@ type WorkerPool interface {
 	ScheduleWithTimeout(func(), time.Duration) error
 }
 
-//
+// DefaultWorkerSettings Settings for DefaultWorkerPool
+type DefaultWorkerSettings struct {
+	// JobQueue
+
+	isJobQueueClosedWhenClose bool
+	workerBatchSize           int
+
+	// Worker
+
+	workerSizeStandBy    int
+	workerSizeMaximum    int
+	spawnWorkerDuration  time.Duration
+	workerExpiryDuration time.Duration
+
+	// Panic Handler
+
+	panicHandler func(interface{})
+}
+
 var defaultPanicHandler = func(panic interface{}) {
 	log.Printf("panic from worker: %v\n", panic)
 	buf := make([]byte, 4096)
 	log.Printf("panic from worker: %s\n", string(buf[:runtime.Stack(buf, false)]))
 }
 
-type (
-	workerRecord struct {
-		LastAccessTime time.Time
-		TerminatedCh   fpgo.ChannelQueue[int]
-	}
-)
+var defaultDefaultWorkerSettings = &DefaultWorkerSettings{
+	isJobQueueClosedWhenClose: true,
+	workerBatchSize:           5,
+	workerSizeStandBy:         5,
+	workerSizeMaximum:         1000,
+	spawnWorkerDuration:       100 * time.Millisecond,
+	workerExpiryDuration:      5000 * time.Millisecond,
+	panicHandler:              defaultPanicHandler,
+}
 
 // DefaultWorkerPool DefaultWorkerPool inspired by Java ExecutorService
 type DefaultWorkerPool struct {
@@ -58,39 +79,21 @@ type DefaultWorkerPool struct {
 	lastAccessTime time.Time
 
 	// Settings
-
-	// JobQueue
-
-	isJobQueueClosedWhenClose bool
-	workerBatchSize           int
-
-	// Worker
-
-	workerSizeStandBy    int
-	workerSizeMaximum    int
-	spawnWorkerDuration  time.Duration
-	workerExpiryDuration time.Duration
-
-	// Panic Handler
-
-	panicHandler func(interface{})
+	DefaultWorkerSettings
 }
 
 // NewDefaultWorkerPool New a DefaultWorkerPool
-func NewDefaultWorkerPool(jobQueue *fpgo.BufferedChannelQueue[func()]) *DefaultWorkerPool {
+func NewDefaultWorkerPool(jobQueue *fpgo.BufferedChannelQueue[func()], settings *DefaultWorkerSettings) *DefaultWorkerPool {
+	if settings == nil {
+		settings = defaultDefaultWorkerSettings
+	}
 	workerPool := &DefaultWorkerPool{
 		jobQueue: jobQueue,
 
 		spawnWorkerCh: fpgo.NewChannelQueue[int](1),
 
 		// Settings
-		isJobQueueClosedWhenClose: true,
-		workerBatchSize:           5,
-		workerSizeStandBy:         5,
-		workerSizeMaximum:         1000,
-		spawnWorkerDuration:       100 * time.Millisecond,
-		workerExpiryDuration:      5000 * time.Millisecond,
-		panicHandler:              defaultPanicHandler,
+		DefaultWorkerSettings: *settings,
 	}
 	go workerPool.spawnLoop()
 

worker/pool_test.go

@@ -13,7 +13,7 @@ import (
 func TestWorkerPool(t *testing.T) {
 	var workerPool WorkerPool
 	var err error
-	defaultWorkerPool := NewDefaultWorkerPool(fpgo.NewBufferedChannelQueue[func()](3, 10000, 100)).
+	defaultWorkerPool := NewDefaultWorkerPool(fpgo.NewBufferedChannelQueue[func()](3, 10000, 100), nil).
 		SetSpawnWorkerDuration(1 * time.Millisecond / 10).
 		SetWorkerExpiryDuration(2 * time.Millisecond).
 		SetWorkerSizeMaximum(5).