Make Actor.AskOnce & Actor.AskOnceWithTimeout isolated.(No more if timeout == nil codes)

Author: johnteee

README.md

@@ -313,12 +313,12 @@ timeout = 10 * time.Millisecond
 
 // Normal cases
 // Result would be 10
-result, _ = Ask.New(1).AskOnce(actorRoot, nil)
+result = Ask.New(1).AskOnce(actorRoot)
 actual, _ = Maybe.Just(result).ToInt()
 assert.Equal(t, expectedInt, actual)
 // Ask with Timeout
 // Result would be 20
-result, _ = Ask.New(2).AskOnce(actorRoot, &timeout)
+result, _ = Ask.New(2).AskOnceWithTimeout(actorRoot, timeout)
 actual, _ = Maybe.Just(result).ToInt()
 // Ask channel
 // Result would be 30
@@ -328,7 +328,7 @@ close(ch)
 
 // Timeout cases
 // Result would be 0 (zero value, timeout)
-result, err = Ask.New(-1).AskOnce(actorRoot, &timeout)
+result, err = Ask.New(-1).AskOnceWithTimeout(actorRoot, timeout)
 actual, _ = Maybe.Just(result).ToInt()
 ```
 

actor.go

@@ -145,19 +145,23 @@ func AskNewByOptionsGenerics(message interface{}, ioCh chan interface{}) *AskDef
 }
 
 // AskOnce Sender Ask
-func (askSelf *AskDef) AskOnce(target ActorHandle, timeout *time.Duration) (interface{}, error) {
+func (askSelf *AskDef) AskOnce(target ActorHandle) interface{} {
 	ch := askSelf.AskChannel(target)
 	defer close(ch)
-	var result interface{}
 	// var err error
-	if timeout == nil {
-		result = <-ch
-	} else {
-		select {
-		case result = <-ch:
-		case <-time.After(*timeout):
-			return result, ErrActorAskTimeout
-		}
+
+	return <-ch
+}
+
+// AskOnce Sender Ask with timeout
+func (askSelf *AskDef) AskOnceWithTimeout(target ActorHandle, timeout time.Duration) (interface{}, error) {
+	ch := askSelf.AskChannel(target)
+	defer close(ch)
+	var result interface{}
+	select {
+	case result = <-ch:
+	case <-time.After(timeout):
+		return result, ErrActorAskTimeout
 	}
 
 	return result, nil

actor_test.go

@@ -113,12 +113,12 @@ func TestActorAsk(t *testing.T) {
 
 	// Normal cases
 	expectedInt = 10
-	result, _ = Ask.New(1).AskOnce(actorRoot, nil)
+	result = Ask.New(1).AskOnce(actorRoot)
 	actual, _ = Maybe.Just(result).ToInt()
 	assert.Equal(t, expectedInt, actual)
 	// Ask with Timeout
 	expectedInt = 20
-	result, _ = Ask.New(2).AskOnce(actorRoot, &timeout)
+	result, _ = Ask.New(2).AskOnceWithTimeout(actorRoot, timeout)
 	actual, _ = Maybe.Just(result).ToInt()
 	assert.Equal(t, expectedInt, actual)
 	// Ask channel
@@ -130,7 +130,7 @@ func TestActorAsk(t *testing.T) {
 
 	// Timeout cases
 	expectedInt = 0
-	result, err = Ask.New(-1).AskOnce(actorRoot, &timeout)
+	result, err = Ask.New(-1).AskOnceWithTimeout(actorRoot, timeout)
 	actual, _ = Maybe.Just(result).ToInt()
 	assert.Equal(t, expectedInt, actual)
 	assert.Equal(t, ErrActorAskTimeout, err)