Fix queue potential bugs

johnteee · johnteee · commit cbc470e39b19 · 2022-05-19T18:20:53.000+08:00
diff --git a/queue.go b/queue.go
@@ -420,11 +420,11 @@ func (q *LinkedListQueue) Shift() (interface{}, error) {
 	if q.first == nil {
 		q.last = nil
 	}
-	val := node.Val
+	val := *node.Val
 
 	q.recycleNode(node)
 
-	return *val, nil
+	return val, nil
 }
 
 // Unshift Unshift the val to the first position(non-blocking)
@@ -460,10 +460,10 @@ func (q *LinkedListQueue) Pop() (interface{}, error) {
 	if q.last == nil {
 		q.first = nil
 	}
-	val := node.Val
+	val := *node.Val
 	q.recycleNode(node)
 
-	return *val, nil
+	return val, nil
 }
 
 // Push Push the data to the last position(non-blocking)

Original file line number	Diff line number	Diff line change
`@@ -420,11 +420,11 @@ func (q *LinkedListQueue) Shift() (interface{}, error) {`
`420`	`420`	`if q.first == nil {`
`421`	`421`	`q.last = nil`
`422`	`422`	`}`
`423`		`- val := node.Val`
	`423`	`+ val := *node.Val`
`424`	`424`
`425`	`425`	`q.recycleNode(node)`
`426`	`426`
`427`		`- return *val, nil`
	`427`	`+ return val, nil`
`428`	`428`	`}`
`429`	`429`
`430`	`430`	`// Unshift Unshift the val to the first position(non-blocking)`
`@@ -460,10 +460,10 @@ func (q *LinkedListQueue) Pop() (interface{}, error) {`
`460`	`460`	`if q.last == nil {`
`461`	`461`	`q.first = nil`
`462`	`462`	`}`
`463`		`- val := node.Val`
	`463`	`+ val := *node.Val`
`464`	`464`	`q.recycleNode(node)`
`465`	`465`
`466`		`- return *val, nil`
	`466`	`+ return val, nil`
`467`	`467`	`}`
`468`	`468`
`469`	`469`	`// Push Push the data to the last position(non-blocking)`