replace println with logging macros

Author: ucabc46

extra/weak_scaling/run_particleda.jl

@@ -3,6 +3,7 @@ using TimerOutputs
 using MPI
 using LinearAlgebra
 using YAML
+using Logging
 
 # Verify BLAS implementation is OpenBLAS
 @assert occursin("openblas", string(BLAS.get_config()))
@@ -27,7 +28,7 @@ summary_stat_type = NaiveMeanSummaryStat
 
 my_rank = MPI.Comm_rank(MPI.COMM_WORLD)
 
-println("Rank $(my_rank): # Julia threads = $(Threads.nthreads()), # BLAS threads = $(BLAS.get_num_threads())")
+@info "Rank $(my_rank): # Julia threads = $(Threads.nthreads()), # BLAS threads = $(BLAS.get_num_threads())"
 
 if my_rank == 0 && !isfile(observation_file)
     observation_sequence = simulate_observations_from_model(
@@ -48,7 +49,7 @@ open(parameters_file, "w") do io
     YAML.write(io, parameters)
 end
 
-println("Optimized resampling enabled: ", parameters["filter"]["optimize_resampling"])
+@info "Optimized resampling enabled: ", parameters["filter"]["optimize_resampling"]
 
 final_states, final_statistics = run_particle_filter(
   LLW2d.init, parameters_file, observation_file, filter_type, summary_stat_type

test/integration_test_7.yaml

@@ -1,6 +1,6 @@
 filter:
   nprt: 10
-  optimize_resampling: true
+  optimize_resampling: false
 
 model:
   llw2d:

test/mpi_optimized_copy_states.jl

@@ -1,4 +1,4 @@
-using Test, ParticleDA, MPI, Random, TimerOutputs, HDF5, Serialization
+using Test, ParticleDA, MPI, Random, TimerOutputs, HDF5, Serialization, Logging
 TimerOutputs.enable_debug_timings(ParticleDA)
 
 const rng = Random.TaskLocalRNG()
@@ -37,7 +37,7 @@ MPI.Init()
 my_rank = MPI.Comm_rank(MPI.COMM_WORLD)
 my_size = MPI.Comm_size(MPI.COMM_WORLD)
 
-println("Number of threads available: ", Threads.nthreads())
+@info "Number of threads available: ", Threads.nthreads()
 
 n_particle_per_rank = 1000
 n_particle = n_particle_per_rank * my_size
@@ -48,13 +48,13 @@ if output_timer
         error("Please provide the output filename for timers.")
     end
     output_filename = ARGS[2]
-    println("Outputting timers to HDF5 file '$output_filename'")
+    @info "Outputting timers to HDF5 file '$output_filename'"
 end
 # default: dedup enabled for testing
 no_dedup = "-nd" in ARGS || "--no-dedup" in ARGS
-println("Deduplication enabled: ", !no_dedup)
+@info "Deduplication enabled: ", !no_dedup
 optimize_resample = "-o" in ARGS || "--optimize-resample" in ARGS
-println("Optimized resampling enabled: ", optimize_resample)
+@info "Optimized resampling enabled: ", optimize_resample
 
 n_float_per_particle = 100000
 # total number of floats per rank
@@ -68,7 +68,7 @@ local_states = similar(init_local_states)
 if verbose
     for i = 1:my_size
         if i == my_rank + 1
-            println("rank ", my_rank, ": local states: ", local_states)
+            @info "rank $(my_rank): local states: ", local_states
         end
         MPI.Barrier(MPI.COMM_WORLD)
     end
@@ -88,14 +88,12 @@ local_timer_dicts = Dict{String, Dict{String,Any}}()
 
 for (trial_name, indices_func) in trial_sets
     if verbose && my_rank == 0
-        println()
-        println("Resampling particles to indices ", indices)
-        println()
+        @info "Resampling particles to indices ", indices
     end
     indices = collect(1:n_particle)  # Placeholder for actual indices
     # repeat experiment 10 times to get average time
     # warm up run
-    println("Warm up run...")
+    @info "Warm up run..."
     ParticleDA.optimized_resample!(indices, my_size)
     ParticleDA.copy_states!(
         local_states,
@@ -104,7 +102,7 @@ for (trial_name, indices_func) in trial_sets
         my_rank, 
         n_particle_per_rank
     )
-    println("Starting timed runs for trial '$trial_name'...")
+    @info "Starting timed runs for trial '$trial_name'..."
 
     timer = TimerOutputs.TimerOutput("copy_states")
     for _ in 1:10
@@ -141,11 +139,11 @@ for (trial_name, indices_func) in trial_sets
                 # compare
                 match = local_states == expected
 
-                println("rank ", my_rank, ": local_states =")
-                show(stdout, "text/plain", local_states); println()
-                println("rank ", my_rank, ": expected =")
-                show(stdout, "text/plain", expected); println()
-                println("rank ", my_rank, ": match = ", match)
+                @info "rank $(my_rank): local_states ="
+                show(stdout, "text/plain", local_states);
+                @info "rank $(my_rank): expected ="
+                show(stdout, "text/plain", expected);
+                @info "rank $(my_rank): match = ", match
             end
             MPI.Barrier(MPI.COMM_WORLD)
         end