Skip to content

Commit 09da5ad

Browse files
committed
Merge branch 'develop' into test
2 parents 6a85625 + fe306f4 commit 09da5ad

File tree

7 files changed

+22
-22
lines changed

7 files changed

+22
-22
lines changed

src/main/java/potatoes/server/chat/dto/ParticipantsInfoResponse.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import potatoes.server.user.entity.User;
44

55
public record ParticipantsInfoResponse(
6-
String user,
6+
String nickname,
77
String email,
88
String description,
99
long travelCount,

src/main/java/potatoes/server/travel/controller/TravelController.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import static org.springframework.http.MediaType.*;
44

5+
import java.util.List;
56
import java.util.Optional;
67

78
import org.springframework.http.ResponseEntity;
@@ -19,6 +20,7 @@
1920
import jakarta.validation.Valid;
2021
import lombok.RequiredArgsConstructor;
2122
import potatoes.server.travel.dto.CreateTravelRequest;
23+
import potatoes.server.travel.dto.SimpleTravelResponse;
2224
import potatoes.server.travel.dto.TravelDetailResponse;
2325
import potatoes.server.travel.service.TravelService;
2426
import potatoes.server.utils.CommonResponse;
@@ -66,6 +68,15 @@ public ResponseEntity<CommonResponse<?>> deleteTravelByOrganizer(
6668
return ResponseEntity.ok(CommonResponse.create());
6769
}
6870

71+
@Operation(summary = "이번 주 인기 여행 조회", description = "이번 주 인기가 많은 여행 모임 반환")
72+
@GetMapping("/popular")
73+
public ResponseEntity<CommonResponse<List<SimpleTravelResponse>>> getPopularTravels(
74+
@NonLoginAuthorization @Parameter(hidden = true) Optional<Long> userId
75+
) {
76+
// TODO - 조회수 카운트 방법 논의 필요
77+
return ResponseEntity.ok(CommonResponse.from(travelService.getPopularTravels(userId)));
78+
}
79+
6980
@Operation(summary = "동행 (참여자)", description = "여행을 동행합니다.")
7081
@PostMapping("{travelId}/participation")
7182
public ResponseEntity<CommonResponse<?>> participateInTravel(

src/main/java/potatoes/server/travel/controller/TravelPaginationController.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import io.swagger.v3.oas.annotations.tags.Tag;
1414
import lombok.RequiredArgsConstructor;
1515
import potatoes.server.travel.dto.GetMyTravelResponse;
16-
import potatoes.server.travel.dto.SimpleTravelResponse;
1716
import potatoes.server.travel.dto.TravelSummaryResponse;
1817
import potatoes.server.travel.service.TravelService;
1918
import potatoes.server.utils.CommonResponse;
@@ -47,17 +46,6 @@ public ResponseEntity<CommonResponse<PageResponse<TravelSummaryResponse>>> getTr
4746
travelService.getTravelList(page, size, isDomestic, startAt, endAt, sortOrder, query, userId)));
4847
}
4948

50-
@Operation(summary = "이번 주 인기 여행 조회", description = "이번 주 인기가 많은 여행 모임 반환")
51-
@GetMapping("/popular")
52-
public ResponseEntity<CommonResponse<PageResponse<SimpleTravelResponse>>> getPopularTravels(
53-
@RequestParam(required = false, defaultValue = "0") int page,
54-
@RequestParam(required = false, defaultValue = "8") int size,
55-
@NonLoginAuthorization @Parameter(hidden = true) Optional<Long> userId
56-
) {
57-
// TODO - 조회수 카운트 방법 논의 필요
58-
return ResponseEntity.ok(CommonResponse.from(travelService.getPopularTravels(page, size, userId)));
59-
}
60-
6149
@Operation(summary = "내가 만든 여행", description = "내 프로필에서 사용하는 사용자가 생성한 여행리스트를 조회합니다.")
6250
@GetMapping("/mine")
6351
public ResponseEntity<CommonResponse<PageResponse<GetMyTravelResponse>>> getMyTravels(

src/main/java/potatoes/server/travel/dto/SimpleTravelResponse.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ public record SimpleTravelResponse(
1010
int maxTravelMateCount,
1111
int currentTravelMateCount,
1212
boolean isDomestic,
13-
Boolean isBookmark,
13+
Boolean bookmarkFlag,
1414
String travelLocation,
1515
String travelImage,
1616
String startAt,

src/main/java/potatoes/server/travel/repository/TravelRepository.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package potatoes.server.travel.repository;
22

33
import java.time.Instant;
4+
import java.util.List;
45

56
import org.springframework.data.domain.Page;
67
import org.springframework.data.domain.Pageable;
@@ -26,5 +27,5 @@ Page<Travel> findTravels(@Param("isDomestic") Boolean isDomestic,
2627
@Param("query") String query,
2728
Pageable pageable);
2829

29-
Page<Travel> findAllByOrderByIdDesc(Pageable pageable);
30+
List<Travel> findTop8ByOrderByIdDesc();
3031
}

src/main/java/potatoes/server/travel/service/TravelService.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import java.time.ZoneOffset;
99
import java.util.List;
1010
import java.util.Optional;
11+
import java.util.stream.Collectors;
1112

1213
import org.springframework.data.domain.Page;
1314
import org.springframework.data.domain.PageRequest;
@@ -208,9 +209,9 @@ private String getSortField(TravelSortType sortOrder) {
208209
};
209210
}
210211

211-
public PageResponse<SimpleTravelResponse> getPopularTravels(int page, int size, Optional<Long> userId) {
212-
Pageable pageable = PageRequest.of(page, size);
213-
Page<SimpleTravelResponse> travels = travelRepository.findAllByOrderByIdDesc(pageable)
212+
public List<SimpleTravelResponse> getPopularTravels(Optional<Long> userId) {
213+
return travelRepository.findTop8ByOrderByIdDesc()
214+
.stream()
214215
.map(travel -> {
215216
int currentTravelMate = (int)travelUserRepository.countByTravel(travel);
216217

@@ -219,9 +220,8 @@ public PageResponse<SimpleTravelResponse> getPopularTravels(int page, int size,
219220
.orElse(null);
220221

221222
return SimpleTravelResponse.from(travel, currentTravelMate, isBookmark);
222-
});
223-
224-
return PageResponse.from(travels);
223+
})
224+
.collect(Collectors.toList());
225225
}
226226

227227
@Transactional

src/main/java/potatoes/server/user/dto/PopularUserResponse.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
public record PopularUserResponse(
44
Long userId,
55
String profileImage,
6-
String nickName,
6+
String nickname,
77
int openTravelCount,
88
long reviewCount,
99
String hashTags

0 commit comments

Comments
 (0)