Skip to content

Commit 4551ef5

Browse files
committed
feat :: 면접후기완료 화면 백프레스 구현
1 parent 97ed80a commit 4551ef5

File tree

6 files changed

+17
-9
lines changed

6 files changed

+17
-9
lines changed

app/src/main/java/team/retum/jobisandroidv2/navigation/MainNavigation.kt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,10 @@ internal fun NavGraphBuilder.mainNavigation(
127127
onBackPressed = navigator::popBackStackIfNotHome,
128128
onPostReviewCompleteClick = navigator::navigateToPostReviewComplete,
129129
)
130-
postReviewComplete(navigateToPostReview = navigator::navigateToPostReview)
130+
postReviewComplete(
131+
onBackPressed = navigator::popBackStackIfNotHome,
132+
navigateToPostReview = navigator::navigateToPostReview
133+
)
131134
reviewDetails(navigator::popBackStackIfNotHome)
132135
reviewFilter(onBackPressed = navigator::popBackStackIfNotHome)
133136
searchReview(

feature/home/src/main/java/team/retum/home/ui/HomeScreen.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,7 @@ private fun HomeScreen(
201201
onCompaniesClick = onCompaniesClick,
202202
onWinterInternClick = onWinterInternClick,
203203
)
204+
// TODO :: 지원 했을 때 홈 진입 시 ui에 바로 반영
204205
ApplyStatus(
205206
modifier = Modifier.padding(
206207
vertical = 12.dp,

feature/post-review/src/main/java/team/retum/post_review/navigation/PostReviewCompleteNavigation.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,14 @@ import team.retum.post_review.ui.PostReviewComplete
88
const val NAVIGATION_POST_REVIEW_COMPLETE = "postReviewComplete"
99

1010
fun NavGraphBuilder.postReviewComplete(
11+
onBackPressed: () -> Unit,
1112
navigateToPostReview: (String, Long) -> Unit,
1213
) {
1314
composable(
1415
route = NAVIGATION_POST_REVIEW_COMPLETE,
1516
) {
1617
PostReviewComplete(
18+
onBackPressed = onBackPressed,
1719
navigateToPostReview = navigateToPostReview,
1820
)
1921
}

feature/post-review/src/main/java/team/retum/post_review/ui/PostExpectReviewScreen.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ internal fun PostExpectReview(
5959
LaunchedEffect(Unit) {
6060
postReviewViewModel.sideEffect.collect {
6161
if (it is PostReviewSideEffect.Success)
62-
onPostReviewCompleteClick
62+
onPostReviewCompleteClick()
6363
}
6464
}
6565

@@ -108,8 +108,8 @@ private fun PostExpectReviewScreen(
108108
)
109109
}
110110
JobisTextField(
111-
value = answer,
112-
onValueChange = onAnswerChange,
111+
value = question,
112+
onValueChange = onQuestionChange,
113113
hint = "받았던 질문을 작성해 주세요.",
114114
)
115115
Row(
@@ -128,8 +128,8 @@ private fun PostExpectReviewScreen(
128128
}
129129
JobisTextField(
130130
modifier = Modifier.heightIn(min = 120.dp, max = 300.dp),
131-
value = question,
132-
onValueChange = onQuestionChange,
131+
value = answer,
132+
onValueChange = onAnswerChange,
133133
hint = "예상 질문 답변을 성심성의껏 작성해 주세요!",
134134
singleLine = false,
135135
)

feature/post-review/src/main/java/team/retum/post_review/ui/PostReviewCompleteScreen.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,17 @@ const val SCREEN_TIME = 1500L
2828

2929
@Composable
3030
internal fun PostReviewComplete(
31+
onBackPressed: () -> Unit,
3132
navigateToPostReview: (String, Long) -> Unit,
3233
postReviewViewModel: PostReviewViewModel = hiltViewModel(),
3334
) {
3435
val state by postReviewViewModel.state.collectAsStateWithLifecycle()
3536

36-
3737
LaunchedEffect(Unit) {
38+
// TODO :: 빈번하게 일어나는 api 요청 개선
3839
delay(SCREEN_TIME)
39-
navigateToPostReview(postReviewViewModel.companyName.value, postReviewViewModel.companyId.value)
40+
onBackPressed()
41+
navigateToPostReview("", 0)
4042
}
4143

4244
PostReviewCompleteScreen(

feature/post-review/src/main/java/team/retum/post_review/viewmodel/PostNextReviewViewModel.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ internal class PostNextReviewViewModel @Inject constructor(
3636
qnaElements = updatedQuestions.zip(answers).map { (q, a) ->
3737
PostReviewContent(
3838
question = q,
39-
answer = a.toString()
39+
answer = a
4040
)
4141
}
4242
)

0 commit comments

Comments
 (0)