Merge pull request #4290 from yashwanthgajji/issue/4277

Author: EmmanuelMess

app/src/main/java/com/amaze/filemanager/ui/dialogs/GeneralDialogCreation.java

@@ -209,14 +209,22 @@ public static void deleteFilesDialog(
         sharedPreferences.getBoolean(
             PreferencesConstants.PREFERENCE_DELETE_CONFIRMATION,
             PreferencesConstants.DEFAULT_PREFERENCE_DELETE_CONFIRMATION);
+    boolean deletePermanently =
+        sharedPreferences.getBoolean(
+            PreferencesConstants.PREFERENCE_DELETE_PERMANENTLY_WITHOUT_CONFIRMATION,
+            PreferencesConstants.DEFAULT_PREFERENCE_DELETE_PERMANENTLY_WITHOUT_CONFIRMATION);
     View dialogView = LayoutInflater.from(context).inflate(R.layout.dialog_delete, null);
     TextView deleteDisclaimerTextView = dialogView.findViewById(R.id.dialog_delete_disclaimer);
     final AppCompatCheckBox deletePermanentlyCheckbox =
         dialogView.findViewById(R.id.delete_permanently_checkbox);
     if (positions.get(0).generateBaseFile().isLocal()) {
       // FIXME: make sure dialog is not shown for zero items
       // allow trash bin delete only for local files for now
-      deletePermanentlyCheckbox.setVisibility(View.VISIBLE);
+      if (deletePermanently) {
+        deletePermanentlyCheckbox.setVisibility(View.GONE);
+      } else {
+        deletePermanentlyCheckbox.setVisibility(View.VISIBLE);
+      }
     } else {
       deleteDisclaimerTextView.setText(context.getString(R.string.dialog_delete_disclaimer));
     }

app/src/main/java/com/amaze/filemanager/ui/fragments/preferencefragments/PreferencesConstants.kt

@@ -77,6 +77,7 @@ object PreferencesConstants {
     const val PREFERENCE_ZIP_EXTRACT_PATH = "extractpath"
     const val PREFERENCE_TEXTEDITOR_NEWSTACK = "texteditor_newstack"
     const val PREFERENCE_DELETE_CONFIRMATION = "delete_confirmation"
+    const val PREFERENCE_DELETE_PERMANENTLY_WITHOUT_CONFIRMATION = "delete_permanently_without_confirmation"
     const val PREFERENCE_DISABLE_PLAYER_INTENT_FILTERS = "disable_player_intent_filters"
     const val PREFERENCE_TRASH_BIN_RETENTION_NUM_OF_FILES = "retention_num_of_files"
     const val PREFERENCE_TRASH_BIN_RETENTION_DAYS = "retention_days"
@@ -122,4 +123,5 @@ object PreferencesConstants {
     const val KEY_TRASH_BIN_CLEANUP_INTERVAL_HOURS = "trash_bin_cleanup_interval_hours"
 
     const val DEFAULT_PREFERENCE_DELETE_CONFIRMATION = true
+    const val DEFAULT_PREFERENCE_DELETE_PERMANENTLY_WITHOUT_CONFIRMATION = false
 }

app/src/main/res/values/strings.xml

@@ -801,6 +801,8 @@ You only need to do this once, until the next time you select a new location for
     <string name="error_cannot_get_package_info">Unable to get package info from file \"%s\". Either the specified file is not an APK, or the package file is corrupt.</string>
     <string name="preference_delete_confirmation">Delete confirmation</string>
     <string name="preference_delete_confirmation_summary">Ask for confirmation before deleting files. Disabling this is highly discouraged!</string>
+    <string name="preference_delete_permanently_without_confirmation">Delete permanently (Disable Trashbin)</string>
+    <string name="preference_delete_permanently_without_confirmation_summary">Delete files permanently without moving to trashbin. Enabling this is highly discouraged!</string>
     <string name="protocol_ssh" translatable="false">SSH/SFTP</string>
     <string name="protocol_ftp" translatable="false">FTP</string>
     <string name="protocol_ftps">Secure FTP</string>

app/src/main/res/xml/behavior_prefs.xml

@@ -30,6 +30,13 @@
         app:key="delete_confirmation"
         app:summary="@string/preference_delete_confirmation_summary"
         app:title="@string/preference_delete_confirmation" />
+    <com.amaze.filemanager.ui.views.preference.CheckBox
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        app:defaultValue="false"
+        app:key="delete_permanently_without_confirmation"
+        app:summary="@string/preference_delete_permanently_without_confirmation_summary"
+        app:title="@string/preference_delete_permanently_without_confirmation" />
     <Preference
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"