Skip to content

Icons sometimes fail after switching gamemode #12

@MattLavalleeMA

Description

@MattLavalleeMA

Occasionally, icons will fail to load after switching gamemodes between creative/survival. I haven't been able to nail down exact repro steps because it often does work fine but sometimes does not.

I suspect this may trace back to JourneyMap itself, as sometimes the minimap also loses the icons.

Stack trace:

09:25:56.345
File at resource location not found: minecraft:squid
09:25:56.347
File at resource location not found: minecraft:fish_tropical_a
09:25:56.348
File at resource location not found: minecraft:fish_pufferfish
09:25:56.354
File at resource location not found: minecraft:fish_tropical_b

09:25:56.348
Uncaught exception
java.lang.NullPointerException: Cannot invoke "java.net.URL.openStream()" because the return value of "java.lang.Class.getResource(String)" is null
	at knot//journeymap_webmap.routes.Resources.getDefaultImage(Resources.java:108)
	at knot//journeymap_webmap.routes.Resources.resourcesGet(Resources.java:67)
	at knot//io.javalin.router.Endpoint.handle(Endpoint.kt:52)
	at knot//io.javalin.router.ParsedEndpoint.handle(ParsedEndpoint.kt:15)
	at knot//io.javalin.http.servlet.DefaultTasks.HTTP$lambda$9$lambda$7$lambda$6(DefaultTasks.kt:52)
	at knot//io.javalin.http.servlet.JavalinServlet.handleTask(JavalinServlet.kt:99)
	at knot//io.javalin.http.servlet.JavalinServlet.handleSync(JavalinServlet.kt:64)
	at knot//io.javalin.http.servlet.JavalinServlet.handle(JavalinServlet.kt:50)
	at knot//io.javalin.http.servlet.JavalinServlet.service(JavalinServlet.kt:30)
	at knot//jakarta.servlet.http.HttpServlet.service(HttpServlet.java:723)
	at knot//org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:764)
	at knot//org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:529)
	at knot//org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:221)
	at knot//org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1580)
	at knot//org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:221)
	at knot//org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1381)
	at knot//org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:176)
	at knot//org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:484)
	at knot//org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1553)
	at knot//org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:174)
	at knot//org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1303)
	at knot//org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:129)
	at knot//org.eclipse.jetty.server.handler.StatisticsHandler.handle(StatisticsHandler.java:173)
	at knot//org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:122)
	at knot//org.eclipse.jetty.server.Server.handle(Server.java:563)
	at knot//org.eclipse.jetty.server.HttpChannel$RequestDispatchable.dispatch(HttpChannel.java:1598)
	at knot//org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:753)
	at knot//org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:501)
	at knot//org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:287)
	at knot//org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:314)
	at knot//org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:100)
	at knot//org.eclipse.jetty.io.SelectableChannelEndPoint$1.run(SelectableChannelEndPoint.java:53)
	at knot//org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.runTask(AdaptiveExecutionStrategy.java:421)
	at knot//org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.consumeTask(AdaptiveExecutionStrategy.java:390)
	at knot//org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.tryProduce(AdaptiveExecutionStrategy.java:277)
	at knot//org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.produce(AdaptiveExecutionStrategy.java:193)
	at knot//org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:969)
	at knot//org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.doRunJob(QueuedThreadPool.java:1194)
	at knot//org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1149)
	at java.base/java.lang.Thread.run(Thread.java:1583)

Related JourneyMap log entry:

[09:25:29] [JettyServerThreadPool-109/ERROR] [MobIconCache] Could not load Mob icon: java.lang.IllegalStateException: Rendersystem called from wrong thread
	at knot//com.mojang.blaze3d.systems.RenderSystem.constructThreadException(RenderSystem.java:129)
	at knot//com.mojang.blaze3d.systems.RenderSystem.assertOnRenderThread(RenderSystem.java:124)
	at knot//com.mojang.blaze3d.opengl.GlStateManager.clearGlErrors(GlStateManager.java:539)
	at knot//net.minecraft.class_10865.createTexture(class_10865.java:104)
	at knot//net.minecraft.class_10865.createTexture(class_10865.java:94)
	at knot//net.minecraft.class_1043.<init>(class_1043.java:22)
	at knot//journeymap.client.render.draw.MobIconCache.addIcon(MobIconCache.java:256)
	at knot//journeymap.client.render.draw.MobIconCache.ensureMobIconsLoaded(MobIconCache.java:222)
	at knot//journeymap.client.render.draw.MobIconCache.getMobIcon(MobIconCache.java:102)
	at knot//journeymap.client.model.EntityDTO.update(EntityDTO.java:301)
	at knot//journeymap.client.model.EntityHelper.getEntitiesNearby(EntityHelper.java:90)
	at knot//journeymap.client.model.EntityHelper.getAmbientCreaturesNearby(EntityHelper.java:154)
	at knot//journeymap.client.data.AmbientCreatureData.load(AmbientCreatureData.java:27)
	at knot//journeymap.client.data.AmbientCreatureData.load(AmbientCreatureData.java:16)
	at knot//com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3574)
	at knot//com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2316)
	at knot//com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2189)
	at knot//com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2079)
	at knot//com.google.common.cache.LocalCache.get(LocalCache.java:4017)
	at knot//com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:4040)
	at knot//com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4989)
	at knot//journeymap.client.data.DataCache.getAmbientCreatures(DataCache.java:303)
	at knot//journeymap_webmap.routes.Data.dataGet(Data.java:50)
	at knot//io.javalin.router.Endpoint.handle(Endpoint.kt:52)
	at knot//io.javalin.router.ParsedEndpoint.handle(ParsedEndpoint.kt:15)
	at knot//io.javalin.http.servlet.DefaultTasks.HTTP$lambda$9$lambda$7$lambda$6(DefaultTasks.kt:52)
	at knot//io.javalin.http.servlet.JavalinServlet.handleTask(JavalinServlet.kt:99)
	at knot//io.javalin.http.servlet.JavalinServlet.handleSync(JavalinServlet.kt:64)
	at knot//io.javalin.http.servlet.JavalinServlet.handle(JavalinServlet.kt:50)
	at knot//io.javalin.http.servlet.JavalinServlet.service(JavalinServlet.kt:30)
	at knot//jakarta.servlet.http.HttpServlet.service(HttpServlet.java:723)
	at knot//org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:764)
	at knot//org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:529)
	at knot//org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:221)
	at knot//org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1580)
	at knot//org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:221)
	at knot//org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1381)
	at knot//org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:176)
	at knot//org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:484)
	at knot//org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1553)
	at knot//org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:174)
	at knot//org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1303)
	at knot//org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:129)
	at knot//org.eclipse.jetty.server.handler.StatisticsHandler.handle(StatisticsHandler.java:173)
	at knot//org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:122)
	at knot//org.eclipse.jetty.server.Server.handle(Server.java:563)
	at knot//org.eclipse.jetty.server.HttpChannel$RequestDispatchable.dispatch(HttpChannel.java:1598)
	at knot//org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:753)
	at knot//org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:501)
	at knot//org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:287)
	at knot//org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:314)
	at knot//org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:100)
	at knot//org.eclipse.jetty.io.SelectableChannelEndPoint$1.run(SelectableChannelEndPoint.java:53)
	at knot//org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.runTask(AdaptiveExecutionStrategy.java:421)
	at knot//org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.consumeTask(AdaptiveExecutionStrategy.java:390)
	at knot//org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.tryProduce(AdaptiveExecutionStrategy.java:277)
	at knot//org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.run(AdaptiveExecutionStrategy.java:199)
	at knot//org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:411)
	at knot//org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:969)
	at knot//org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.doRunJob(QueuedThreadPool.java:1194)
	at knot//org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1149)
	at java.base/java.lang.Thread.run(Thread.java:1583)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions