Better error message, when fetching metadat fails

Author: litetex

app/src/main/java/org/schabi/newpipe/settings/services/instances/AbstractServiceInstanceListFragment.java

@@ -2,6 +2,7 @@
 
 import android.annotation.SuppressLint;
 import android.os.Bundle;
+import android.util.Log;
 import android.view.LayoutInflater;
 import android.view.Menu;
 import android.view.MenuInflater;
@@ -23,6 +24,7 @@
 import androidx.recyclerview.widget.LinearLayoutManager;
 import androidx.recyclerview.widget.RecyclerView;
 
+import org.schabi.newpipe.MainActivity;
 import org.schabi.newpipe.R;
 import org.schabi.newpipe.databinding.FragmentInstanceListBinding;
 import org.schabi.newpipe.databinding.InstanceTypeFloatingItemBinding;
@@ -45,7 +47,7 @@
 import io.reactivex.rxjava3.schedulers.Schedulers;
 
 public abstract class AbstractServiceInstanceListFragment<I extends Instance> extends Fragment {
-
+    protected static final String TAG = "AbsServiceInstanceLFrag";
     protected static final int TYPES_CONTAINER_ANIMATION_DURATION = 500;
 
     @StringRes
@@ -253,9 +255,14 @@ protected void addInstance(final I createdInstance) {
                     add(instance);
                 }, e -> {
                     binding.loadingProgressBar.setVisibility(View.GONE);
+                    if (MainActivity.DEBUG) {
+                        Log.w(TAG, "Failed to validate instance", e);
+                    }
                     Toast.makeText(getActivity(),
-                            R.string.could_not_validate_instance,
-                            Toast.LENGTH_SHORT).show();
+                            requireContext().getString(
+                                    R.string.could_not_validate_instance,
+                                    e.getMessage() != null ? e.getMessage() : "no message"),
+                            Toast.LENGTH_LONG).show();
                 });
         disposables.add(disposable);
     }

app/src/main/res/values-ar/strings.xml

@@ -457,7 +457,6 @@
     <string name="peertube_instance_url_title">مثيلات خوادم پيرتيوب</string>
     <string name="peertube_instance_url_summary">حدد مثيلات PeerTube المفضلة لديك</string>
     <string name="enter_instance_url">أدخل عنوان للمثيل</string>
-    <string name="could_not_validate_instance">لا يمكن التحقق من صحة المثال</string>
     <string name="instance_already_exists">مثيل الخادم موجود بالفعل</string>
     <string name="local">محلي</string>
     <string name="recently_added">أُضيف مؤخرًا</string>

app/src/main/res/values-b+ast/strings.xml

@@ -260,7 +260,6 @@
     <string name="import_complete_toast">Importóse</string>
     <string name="could_not_import_all_files">Alvertencia: nun pudieron importase tolos ficheros.</string>
     <string name="settings_category_updates_title">Anovamientos</string>
-    <string name="could_not_validate_instance">Nun pudo validase la instancia</string>
     <plurals name="minutes">
         <item quantity="one">%d minutu</item>
         <item quantity="other">%d minutos</item>

app/src/main/res/values-b+uz+Latn/strings.xml

@@ -144,7 +144,6 @@
     <string name="settings_category_player_behavior_title">Xatti-harakat</string>
     <string name="settings_category_player_title">Ijro etish</string>
     <string name="instance_already_exists">Namuna allaqachon mavjud</string>
-    <string name="could_not_validate_instance">Namunani tasdiqlab bo\'lmadi</string>
     <string name="enter_instance_url">Namuna URL manzilini kiriting</string>
     <string name="peertube_instance_url_summary">Sevimli PeerTube nusxalarini tanlang</string>
     <string name="peertube_instance_url_title">PeerTube misollari</string>

app/src/main/res/values-b+zh+HANS+CN/strings.xml

@@ -431,7 +431,6 @@
     <string name="peertube_instance_url_title">PeerTube 服务器</string>
     <string name="peertube_instance_url_summary">设置自定义 PeerTube 服务器</string>
     <string name="enter_instance_url">输入服务器网址（URL）</string>
-    <string name="could_not_validate_instance">无法验证服务器</string>
     <string name="instance_already_exists">该服务器已存在</string>
     <string name="local">本地</string>
     <string name="recently_added">最近添加</string>

app/src/main/res/values-be/strings.xml

@@ -435,7 +435,6 @@
     <string name="show_original_time_ago_summary">Арыгінальныя тэксты з сэрвісаў будуць бачны ў ленце элементаў</string>
     <string name="clear_cookie_summary">Ачысціце cookie, якія NewPipe захоўвае пры рашэнні reCAPTCHA</string>
     <string name="instance_already_exists">Экзэмпляр ужо існуе</string>
-    <string name="could_not_validate_instance">Немагчыма праверыць экзэмпляр</string>
     <string name="enter_instance_url">Увесці URL экзэмпляра</string>
     <string name="peertube_instance_url_summary">Абярыце любімыя экзэмпляры PeerTube</string>
     <string name="clear_queue_confirmation_description">Актыўны плэер быў зменены</string>

app/src/main/res/values-bn/strings.xml

@@ -345,7 +345,6 @@
     <string name="empty_subscription_feed_subtitle">ঝিঝিপোকা ছাড়া কিছুই নেই এখানে</string>
     <string name="invalid_source">এই ধরনের কোন ফাইল/বিষয়বস্তুর উৎস নেই</string>
     <string name="player_unrecoverable_failure">অপুনরুদ্ধারযোগ্য প্লেয়ার ত্রুটি ঘটেছে</string>
-    <string name="could_not_validate_instance">ইন্সট্যান্সটি যাচাই করা যায়নি</string>
     <string name="recaptcha_cookies_cleared">রিক্যাপচা কুকিগুলো পরিষ্কার করা হয়েছে</string>
     <string name="remove_watched_popup_yes_and_partially_watched_videos">হ্যাঁ, এবং আংশিকভাবে দেখা ভিডিও</string>
     <string name="permission_denied">ব্যবস্থা দ্বারা ক্রিয়া অস্বীকার করা হয়েছে</string>

app/src/main/res/values-ca/strings.xml

@@ -451,7 +451,6 @@
 \nSi desitgeu visualitzar-lo, activeu \"%1$s\" a paràmetres.</string>
     <string name="youtube_restricted_mode_enabled_title">Activa el \"mode restringit\" de YouTube</string>
     <string name="instance_already_exists">La instància introduïda ja existeix</string>
-    <string name="could_not_validate_instance">No ha estat possible validar la instància</string>
     <string name="enter_instance_url">Introdueix l\'enllaç d\'una instància</string>
     <string name="peertube_instance_url_summary">Selecciona les teves instàncies preferides del PeerTube</string>
     <string name="peertube_instance_url_title">Instàncies del PeerTube</string>

app/src/main/res/values-ckb/strings.xml

@@ -475,7 +475,6 @@
     <string name="error_report_title">هەڵە لە سكاڵا</string>
     <string name="metadata_cache_wipe_summary">سڕینەوەی پاشماوەی هەموو ماڵپه‌ڕه‌كان</string>
     <string name="kore_not_found">بەرنامەکە نه‌دۆزرایه‌وه‌. دابمه‌زرێت؟</string>
-    <string name="could_not_validate_instance">ناتوانرێ پشتگیری دۆخەکە بکرێ</string>
     <string name="install">دامەزراندن</string>
     <string name="videos_string">ڤیدیۆکان</string>
     <string name="unsupported_url">بەستەرەکە پشتگیری نەکراوە</string>

app/src/main/res/values-cs/strings.xml

@@ -442,7 +442,6 @@
     <string name="peertube_instance_url_title">Instance PeerTube</string>
     <string name="peertube_instance_url_summary">Vybrat oblíbené instance PeerTube</string>
     <string name="enter_instance_url">Zadat URL instance</string>
-    <string name="could_not_validate_instance">Instanci nebylo možno potvrdit</string>
     <string name="instance_already_exists">Instance již existuje</string>
     <string name="local">Místní</string>
     <string name="recently_added">Přidány nedávno</string>