Skip to content

Commit 09e4bea

Browse files
authored
Merge pull request #12699 from Zer0tier/issue#12499
Fix Long Audio/Dubs text label puses UI Controls on Player Off Screen in Portrait mode.
2 parents eee1172 + fbc664d commit 09e4bea

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

app/src/main/java/org/schabi/newpipe/player/ui/MainPlayerUi.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,7 @@ protected void setupElementsVisibility() {
289289
binding.topControls.setClickable(true);
290290
binding.topControls.setFocusable(true);
291291

292+
binding.metadataView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE);
292293
binding.titleTextView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE);
293294
binding.channelTextView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE);
294295
}
@@ -934,6 +935,7 @@ public void toggleFullscreen() {
934935
}
935936
fragmentListener.onFullscreenStateChanged(isFullscreen);
936937

938+
binding.metadataView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE);
937939
binding.titleTextView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE);
938940
binding.channelTextView.setVisibility(isFullscreen ? View.VISIBLE : View.GONE);
939941
binding.playerCloseButton.setVisibility(isFullscreen ? View.GONE : View.VISIBLE);

app/src/main/res/layout/player.xml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@
123123
android:layout_width="0dp"
124124
android:layout_height="wrap_content"
125125
android:layout_marginTop="6dp"
126-
android:layout_marginRight="8dp"
126+
android:layout_marginEnd="8dp"
127127
android:layout_weight="1"
128128
android:gravity="top"
129129
android:orientation="vertical"
@@ -160,12 +160,15 @@
160160

161161
<org.schabi.newpipe.views.NewPipeTextView
162162
android:id="@+id/audioTrackTextView"
163-
android:layout_width="wrap_content"
163+
android:layout_width="0dp"
164164
android:layout_height="35dp"
165165
android:layout_marginEnd="8dp"
166+
android:layout_weight="1"
166167
android:background="?attr/selectableItemBackground"
167168
android:gravity="center"
168169
android:minWidth="0dp"
170+
android:singleLine="true"
171+
android:ellipsize="end"
169172
android:padding="@dimen/player_main_buttons_padding"
170173
android:textColor="@android:color/white"
171174
android:textStyle="bold"

0 commit comments

Comments
 (0)