Skip to content

Commit 42f9099

Browse files
TobiGrStypox
authored andcommitted
Bump checkstyle and make inner classes final
Updating checkstyle fixed a vulnerability and fixed a final class check in version 10.12.2 for local classes without constructor. Local classes without a constructor should be marked as final. That is done in this commit. For more info see https://github.com/checkstyle/checkstyle/releases/tag/checkstyle-10.12.2
1 parent c8e294b commit 42f9099

File tree

7 files changed

+10
-7
lines changed

7 files changed

+10
-7
lines changed

app/src/main/java/org/schabi/newpipe/fragments/list/search/SuggestionListAdapter.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,8 @@ private void updateFrom(final SuggestionItem item) {
7676
}
7777
}
7878

79-
private static class SuggestionItemCallback extends DiffUtil.ItemCallback<SuggestionItem> {
79+
private static final class SuggestionItemCallback
80+
extends DiffUtil.ItemCallback<SuggestionItem> {
8081
@Override
8182
public boolean areItemsTheSame(@NonNull final SuggestionItem oldItem,
8283
@NonNull final SuggestionItem newItem) {

app/src/main/java/org/schabi/newpipe/settings/PeertubeInstanceListFragment.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,8 @@ void bind(final int position) {
396396
}
397397
}
398398

399-
private static class PeertubeInstanceCallback extends DiffUtil.ItemCallback<PeertubeInstance> {
399+
private static final class PeertubeInstanceCallback
400+
extends DiffUtil.ItemCallback<PeertubeInstance> {
400401
@Override
401402
public boolean areItemsTheSame(@NonNull final PeertubeInstance oldItem,
402403
@NonNull final PeertubeInstance newItem) {

app/src/main/java/org/schabi/newpipe/settings/SelectChannelFragment.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ public interface OnCancelListener {
174174
void onCancel();
175175
}
176176

177-
private class SelectChannelAdapter
177+
private final class SelectChannelAdapter
178178
extends RecyclerView.Adapter<SelectChannelAdapter.SelectChannelItemHolder> {
179179
@NonNull
180180
@Override

app/src/main/java/org/schabi/newpipe/settings/SelectFeedGroupFragment.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ public interface OnCancelListener {
175175
void onCancel();
176176
}
177177

178-
private class SelectFeedGroupAdapter
178+
private final class SelectFeedGroupAdapter
179179
extends RecyclerView.Adapter<SelectFeedGroupAdapter.SelectFeedGroupItemHolder> {
180180
@NonNull
181181
@Override

app/src/main/java/org/schabi/newpipe/settings/SelectPlaylistFragment.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ public interface OnSelectedListener {
138138
void onRemotePlaylistSelected(int serviceId, String url, String name);
139139
}
140140

141-
private class SelectPlaylistAdapter
141+
private final class SelectPlaylistAdapter
142142
extends RecyclerView.Adapter<SelectPlaylistAdapter.SelectPlaylistItemHolder> {
143143
@NonNull
144144
@Override

app/src/main/java/org/schabi/newpipe/settings/preferencesearch/PreferenceSearchAdapter.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,8 @@ static class PreferenceViewHolder extends RecyclerView.ViewHolder {
6969
}
7070
}
7171

72-
private static class PreferenceCallback extends DiffUtil.ItemCallback<PreferenceSearchItem> {
72+
private static final class PreferenceCallback
73+
extends DiffUtil.ItemCallback<PreferenceSearchItem> {
7374
@Override
7475
public boolean areItemsTheSame(@NonNull final PreferenceSearchItem oldItem,
7576
@NonNull final PreferenceSearchItem newItem) {

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ assertj = "3.24.2"
1111
autoservice = "1.1.1"
1212
bridge = "v2.0.2"
1313
cardview = "1.0.0"
14-
checkstyle = "10.12.1"
14+
checkstyle = "10.26.1"
1515
constraintlayout = "2.1.4"
1616
core = "1.12.0"
1717
desugar = "2.0.4"

0 commit comments

Comments
 (0)