Merge branch 'dev' into refactor

Had to make some adjustments to make #12188 work

Author: Stypox

.github/workflows/image-minimizer.js

@@ -33,11 +33,11 @@ module.exports = async ({github, context}) => {
 
     // Regex for finding images (simple variant) ![ALT_TEXT](https://*.githubusercontent.com/<number>/<variousHexStringsAnd->.<fileExtension>)
     const REGEX_USER_CONTENT_IMAGE_LOOKUP = /\!\[([^\]]*)\]\((https:\/\/[-a-z0-9]+\.githubusercontent\.com\/\d+\/[-0-9a-f]{32,512}\.(jpg|gif|png))\)/gm;
-    const REGEX_ASSETS_IMAGE_LOCKUP = /\!\[([^\]]*)\]\((https:\/\/github\.com\/[-\w\d]+\/[-\w\d]+\/assets\/\d+\/[\-0-9a-f]{32,512})\)/gm;
+    const REGEX_ASSETS_IMAGE_LOOKUP = /\!\[([^\]]*)\]\((https:\/\/github\.com\/(?:user-attachments\/assets|[-\w\d]+\/[-\w\d]+\/assets\/\d+)\/[\-0-9a-f]{32,512})\)/gm;
 
     // Check if we found something
     let foundSimpleImages = REGEX_USER_CONTENT_IMAGE_LOOKUP.test(initialBody)
-        || REGEX_ASSETS_IMAGE_LOCKUP.test(initialBody);
+        || REGEX_ASSETS_IMAGE_LOOKUP.test(initialBody);
     if (!foundSimpleImages) {
         console.log('Found no simple images to process');
         return;
@@ -52,7 +52,7 @@ module.exports = async ({github, context}) => {
 
     // Try to find and replace the images with minimized ones
     let newBody = await replaceAsync(initialBody, REGEX_USER_CONTENT_IMAGE_LOOKUP, minimizeAsync);
-    newBody = await replaceAsync(newBody, REGEX_ASSETS_IMAGE_LOCKUP, minimizeAsync);
+    newBody = await replaceAsync(newBody, REGEX_ASSETS_IMAGE_LOOKUP, minimizeAsync);
 
     if (!wasMatchModified) {
         console.log('Nothing was modified. Skipping update');

app/build.gradle

@@ -27,9 +27,9 @@ android {
         if (System.properties.containsKey('versionCodeOverride')) {
             versionCode System.getProperty('versionCodeOverride') as Integer
         } else {
-            versionCode 1003
+            versionCode 1004
         }
-        versionName "0.27.6"
+        versionName "0.27.7"
         if (System.properties.containsKey('versionNameSuffix')) {
             versionNameSuffix System.getProperty('versionNameSuffix')
         }

app/src/main/java/org/schabi/newpipe/local/BaseLocalListFragment.java

@@ -194,9 +194,6 @@ public void showLoading() {
         if (itemsList != null) {
             animateHideRecyclerViewAllowingScrolling(itemsList);
         }
-        if (headerRootBinding != null) {
-            animate(headerRootBinding.getRoot(), false, 200);
-        }
     }
 
     @Override
@@ -205,9 +202,6 @@ public void hideLoading() {
         if (itemsList != null) {
             animate(itemsList, true, 200);
         }
-        if (headerRootBinding != null) {
-            animate(headerRootBinding.getRoot(), true, 200);
-        }
     }
 
     @Override
@@ -253,9 +247,6 @@ public void handleError() {
         if (itemsList != null) {
             animateHideRecyclerViewAllowingScrolling(itemsList);
         }
-        if (headerRootBinding != null) {
-            animate(headerRootBinding.getRoot(), false, 200);
-        }
     }
 
     @Override

app/src/main/java/org/schabi/newpipe/ui/components/video/comment/Comment.kt

@@ -99,10 +99,12 @@ fun Comment(comment: CommentsInfoItem, onCommentAuthorOpened: () -> Unit) {
                 }
 
                 val nameAndDate = remember(comment) {
-                    val date = Localization.relativeTimeOrTextual(
-                        context, comment.uploadDate, comment.textualUploadDate
+                    Localization.concatenateStrings(
+                        Localization.localizeUserName(comment.uploaderName),
+                        Localization.relativeTimeOrTextual(
+                            context, comment.uploadDate, comment.textualUploadDate
+                        )
                     )
-                    Localization.concatenateStrings(comment.uploaderName, date)
                 }
                 Text(
                     text = nameAndDate,

app/src/main/java/org/schabi/newpipe/util/Localization.java

@@ -11,6 +11,7 @@
 import android.os.Build;
 import android.text.TextUtils;
 import android.text.format.DateUtils;
+import android.text.BidiFormatter;
 import android.util.DisplayMetrics;
 import android.util.Log;
 
@@ -85,6 +86,25 @@ public static String concatenateStrings(final String delimiter, final List<Strin
                 .collect(Collectors.joining(delimiter));
     }
 
+    /**
+     * Localize a user name like <code>@foobar</code>.
+     *
+     * Will correctly handle right-to-left usernames by using a {@link BidiFormatter}.
+     *
+     * @param plainName username, with an optional leading <code>@</code>
+     * @return a usernames that can include RTL-characters
+     */
+    @NonNull
+    public static String localizeUserName(final String plainName) {
+        final BidiFormatter bidi = BidiFormatter.getInstance();
+
+        if (plainName.startsWith("@")) {
+            return "@" + bidi.unicodeWrap(plainName.substring(1));
+        } else {
+            return bidi.unicodeWrap(plainName);
+        }
+    }
+
     public static org.schabi.newpipe.extractor.localization.Localization getPreferredLocalization(
             final Context context) {
         return org.schabi.newpipe.extractor.localization.Localization

fastlane/metadata/android/ar/changelogs/1004.txt

@@ -0,0 +1 @@
+تم إصلاح YouTube الذي لا يقوم بتشغيل أي دفق

fastlane/metadata/android/az/changelogs/1004.txt

@@ -0,0 +1 @@
+YouTube-un heç bir yayım oynatmaması düzəldildi

fastlane/metadata/android/cs/changelogs/1004.txt

@@ -0,0 +1 @@
+Opraveno nepřehrávání jakéhokoli streamu ve službě YouTube

fastlane/metadata/android/de/changelogs/1004.txt

@@ -0,0 +1 @@
+Behoben, dass YouTube keinen Stream abspielte

fastlane/metadata/android/en-US/changelogs/1004.txt

@@ -0,0 +1,3 @@
+This release fixes YouTube only providing a 360p stream.
+
+Note that the solution employed in this version is likely temporary, and in the long run the SABR video protocol needs to be implemented, but TeamNewPipe members are currently busy so any help would be greatly appreciated! https://github.com/TeamNewPipe/NewPipe/issues/12248