Merge pull request #12716 from Isaac-75/12194-notification-prompt-after-rotation

Notifications are no longer requested again after rotating the phone

Author: TobiGr

app/src/main/java/org/schabi/newpipe/App.java

@@ -65,13 +65,23 @@ public class App extends Application {
     private static final String TAG = App.class.toString();
 
     private boolean isFirstRun = false;
+    private boolean notificationsRequested = false;
+
     private static App app;
 
     @NonNull
     public static App getApp() {
         return app;
     }
 
+    public boolean getNotificationsRequested() {
+        return notificationsRequested;
+    }
+
+    public void setNotificationsRequested() {
+        notificationsRequested = true;
+    }
+
     @Override
     protected void attachBaseContext(final Context base) {
         super.attachBaseContext(base);

app/src/main/java/org/schabi/newpipe/util/PermissionHelper.java

@@ -17,6 +17,7 @@
 import androidx.core.app.ActivityCompat;
 import androidx.core.content.ContextCompat;
 
+import org.schabi.newpipe.App;
 import org.schabi.newpipe.R;
 import org.schabi.newpipe.settings.NewPipeSettings;
 
@@ -89,9 +90,12 @@ public static boolean checkPostNotificationsPermission(final Activity activity,
                 && ContextCompat.checkSelfPermission(activity,
                 Manifest.permission.POST_NOTIFICATIONS)
                 != PackageManager.PERMISSION_GRANTED) {
-            ActivityCompat.requestPermissions(activity,
-                    new String[] {Manifest.permission.POST_NOTIFICATIONS}, requestCode);
-            return false;
+            if (!App.getApp().getNotificationsRequested()) {
+                ActivityCompat.requestPermissions(activity,
+                        new String[]{Manifest.permission.POST_NOTIFICATIONS}, requestCode);
+                App.getApp().setNotificationsRequested();
+                return false;
+            }
         }
         return true;
     }