Skip to content

Commit d55d6a1

Browse files
Artem ShtefanArtem Shtefan
authored andcommitted
Move silence skipping duration settings to ExoPlayer settings
1 parent 293914d commit d55d6a1

File tree

4 files changed

+13
-13
lines changed

4 files changed

+13
-13
lines changed

app/src/main/res/values/settings_keys.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@
123123
<string name="default_popup_resolution_key">default_popup_resolution</string>
124124
<string name="default_popup_resolution_value">480p</string>
125125
<string name="best_resolution_key">best_resolution</string>
126-
<string name="max_silence_duration_value">1000</string>
126+
<string name="max_silence_duration_value">500</string>
127127
<string name="max_silence_duration_min">100</string>
128128
<string name="max_silence_duration_max">5000</string>
129129
<string name="max_silence_duration_key">max_silence_duration</string>

app/src/main/res/values/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
<string name="default_popup_resolution_title">Default popup resolution</string>
5151
<string name="show_higher_resolutions_title">Show higher resolutions</string>
5252
<string name="show_higher_resolutions_summary">Only some devices can play 2K/4K videos</string>
53-
<string name="max_silence_duration_title">Maximal silence duration in milliseconds that remains when &quot;fast forwarding during silence&quot; is enabled</string>
53+
<string name="max_silence_duration_title">Maximal silence duration in milliseconds that remains when \"fast forwarding during silence\" is enabled</string>
5454
<string name="play_with_kodi_title">Play with Kodi</string>
5555
<string name="kore_not_found">Install missing Kore app\?</string>
5656
<string name="show_play_with_kodi_title">Show \"Play with Kodi\" option</string>

app/src/main/res/xml/exoplayer_settings.xml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,15 @@
3737
app:singleLineTitle="false"
3838
app:iconSpaceReserved="false" />
3939

40+
<SeekBarPreference
41+
android:defaultValue="@string/max_silence_duration_value"
42+
app:min="@string/max_silence_duration_min"
43+
android:max="@string/max_silence_duration_max"
44+
android:key="@string/max_silence_duration_key"
45+
android:title="@string/max_silence_duration_title"
46+
app:singleLineTitle="false"
47+
app:iconSpaceReserved="false"
48+
app:useSimpleSummaryProvider="true"
49+
app:showSeekBarValue="true" />
50+
4051
</PreferenceScreen>

app/src/main/res/xml/video_audio_settings.xml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -77,17 +77,6 @@
7777
app:singleLineTitle="false"
7878
app:iconSpaceReserved="false"/>
7979

80-
<SeekBarPreference
81-
android:defaultValue="@string/max_silence_duration_value"
82-
app:min="@string/max_silence_duration_min"
83-
android:max="@string/max_silence_duration_max"
84-
android:key="@string/max_silence_duration_key"
85-
android:title="@string/max_silence_duration_title"
86-
app:singleLineTitle="false"
87-
app:iconSpaceReserved="false"
88-
app:useSimpleSummaryProvider="true"
89-
app:showSeekBarValue="true" />
90-
9180
<PreferenceScreen
9281
android:fragment="org.schabi.newpipe.settings.ExoPlayerSettingsFragment"
9382
android:key="@string/exoplayer_settings_key"

0 commit comments

Comments
 (0)