From c4e6e4d4c4afbf37645fa1aa47d2230d3047eb33 Mon Sep 17 00:00:00 2001 From: Isaac Date: Sun, 19 Oct 2025 03:41:52 +1100 Subject: [PATCH 1/2] Notifications are no longer requested again after rotating the phone --- app/src/main/java/org/schabi/newpipe/App.java | 9 +++++++++ .../java/org/schabi/newpipe/util/PermissionHelper.java | 10 +++++++--- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/org/schabi/newpipe/App.java b/app/src/main/java/org/schabi/newpipe/App.java index a8827c33e73..364f62114d5 100644 --- a/app/src/main/java/org/schabi/newpipe/App.java +++ b/app/src/main/java/org/schabi/newpipe/App.java @@ -66,12 +66,21 @@ public class App extends Application { private boolean isFirstRun = false; private static App app; + private boolean notificationsRequested = false; @NonNull public static App getApp() { return app; } + public boolean getNotificationsRequested() { + return notificationsRequested; + } + + public void setNotificationsRequested() { + notificationsRequested = true; + } + @Override protected void attachBaseContext(final Context base) { super.attachBaseContext(base); diff --git a/app/src/main/java/org/schabi/newpipe/util/PermissionHelper.java b/app/src/main/java/org/schabi/newpipe/util/PermissionHelper.java index 2785afab0f8..969d787d74d 100644 --- a/app/src/main/java/org/schabi/newpipe/util/PermissionHelper.java +++ b/app/src/main/java/org/schabi/newpipe/util/PermissionHelper.java @@ -17,6 +17,7 @@ import androidx.core.app.ActivityCompat; import androidx.core.content.ContextCompat; +import org.schabi.newpipe.App; import org.schabi.newpipe.R; import org.schabi.newpipe.settings.NewPipeSettings; @@ -89,9 +90,12 @@ public static boolean checkPostNotificationsPermission(final Activity activity, && ContextCompat.checkSelfPermission(activity, Manifest.permission.POST_NOTIFICATIONS) != PackageManager.PERMISSION_GRANTED) { - ActivityCompat.requestPermissions(activity, - new String[] {Manifest.permission.POST_NOTIFICATIONS}, requestCode); - return false; + if (!App.getApp().getNotificationsRequested()) { + ActivityCompat.requestPermissions(activity, + new String[]{Manifest.permission.POST_NOTIFICATIONS}, requestCode); + App.getApp().setNotificationsRequested(); + return false; + } } return true; } From 88eb32be3ab461acf9624dc3b25600676c0babc5 Mon Sep 17 00:00:00 2001 From: Isaac Date: Sun, 26 Oct 2025 05:32:12 +1100 Subject: [PATCH 2/2] moved field as requested --- app/src/main/java/org/schabi/newpipe/App.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/org/schabi/newpipe/App.java b/app/src/main/java/org/schabi/newpipe/App.java index 364f62114d5..cf41aad46cd 100644 --- a/app/src/main/java/org/schabi/newpipe/App.java +++ b/app/src/main/java/org/schabi/newpipe/App.java @@ -65,9 +65,10 @@ public class App extends Application { private static final String TAG = App.class.toString(); private boolean isFirstRun = false; - private static App app; private boolean notificationsRequested = false; + private static App app; + @NonNull public static App getApp() { return app;