Skip to content

Commit 33347ac

Browse files
committed
Removed unused methods
``contentFilters`` and ``sortfilter`` are get inside the ``ListLinkHandler`` and not the ``ListLinkHandlerFactory`` ``ListLinkHandlerFactory`` only passes these values through when ``fromQuery`` is called
1 parent ec5b54c commit 33347ac

File tree

4 files changed

+11
-23
lines changed

4 files changed

+11
-23
lines changed

extractor/src/main/java/org/schabi/newpipe/extractor/linkhandler/ListLinkHandler.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package org.schabi.newpipe.extractor.linkhandler;
22

3+
import static org.schabi.newpipe.extractor.utils.Utils.EMPTY_STRING;
4+
35
import java.util.Collections;
46
import java.util.List;
57

@@ -25,14 +27,12 @@ public ListLinkHandler(final ListLinkHandler handler) {
2527
handler.sortFilter);
2628
}
2729

28-
public ListLinkHandler(final LinkHandler handler,
29-
final List<String> contentFilters,
30-
final String sortFilter) {
30+
public ListLinkHandler(final LinkHandler handler) {
3131
this(handler.originalUrl,
3232
handler.url,
3333
handler.id,
34-
contentFilters,
35-
sortFilter);
34+
Collections.emptyList(),
35+
EMPTY_STRING);
3636
}
3737

3838
public List<String> getContentFilters() {

extractor/src/main/java/org/schabi/newpipe/extractor/linkhandler/ListLinkHandlerFactory.java

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,6 @@ public abstract class ListLinkHandlerFactory extends LinkHandlerFactory {
1313
// To Override
1414
///////////////////////////////////
1515

16-
@SuppressWarnings({"RedundantThrows", "unused"})
17-
public List<String> getContentFilter(final String url) throws ParsingException {
18-
return Collections.emptyList();
19-
}
20-
21-
@SuppressWarnings({"RedundantThrows", "unused"})
22-
public String getSortFilter(final String url) throws ParsingException {
23-
return "";
24-
}
25-
2616
public abstract String getUrl(String id, List<String> contentFilter, String sortFilter)
2717
throws ParsingException;
2818

@@ -50,18 +40,17 @@ public ListLinkHandler fromUrl(final String url, final String baseUrl) throws Pa
5040
throw new IllegalArgumentException("url may not be null");
5141
}
5242

53-
return new ListLinkHandler(super.fromUrl(url, baseUrl), getContentFilter(url),
54-
getSortFilter(url));
43+
return new ListLinkHandler(super.fromUrl(url, baseUrl));
5544
}
5645

5746
@Override
5847
public ListLinkHandler fromId(final String id) throws ParsingException {
59-
return new ListLinkHandler(super.fromId(id), new ArrayList<>(0), "");
48+
return new ListLinkHandler(super.fromId(id));
6049
}
6150

6251
@Override
6352
public ListLinkHandler fromId(final String id, final String baseUrl) throws ParsingException {
64-
return new ListLinkHandler(super.fromId(id, baseUrl), new ArrayList<>(0), "");
53+
return new ListLinkHandler(super.fromId(id, baseUrl));
6554
}
6655

6756
public ListLinkHandler fromQuery(final String id,

extractor/src/main/java/org/schabi/newpipe/extractor/linkhandler/SearchQueryHandlerFactory.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import org.schabi.newpipe.extractor.exceptions.ParsingException;
44

55
import java.util.ArrayList;
6+
import java.util.Collections;
67
import java.util.List;
78

89
import static org.schabi.newpipe.extractor.utils.Utils.EMPTY_STRING;
@@ -39,7 +40,7 @@ public SearchQueryHandler fromQuery(final String query,
3940
}
4041

4142
public SearchQueryHandler fromQuery(final String query) throws ParsingException {
42-
return fromQuery(query, new ArrayList<>(0), EMPTY_STRING);
43+
return fromQuery(query, Collections.emptyList(), EMPTY_STRING);
4344
}
4445

4546
/**

extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/linkHandler/YoutubePlaylistLinkHandlerFactory.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,7 @@ public ListLinkHandler fromUrl(final String url) throws ParsingException {
9797
}
9898
final String newUrl = "https://www.youtube.com/watch?v=" + videoID
9999
+ "&list=" + listID;
100-
return new ListLinkHandler(new LinkHandler(url, newUrl, listID),
101-
getContentFilter(url),
102-
getSortFilter(url));
100+
return new ListLinkHandler(new LinkHandler(url, newUrl, listID));
103101
}
104102
} catch (final MalformedURLException exception) {
105103
throw new ParsingException("Error could not parse URL: " + exception.getMessage(),

0 commit comments

Comments
 (0)