Started fixing YoutubeDashManifestCreatorsTest

Author: litetex

extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/dashmanifestcreator/AbstractYoutubeDashManifestCreator.java

@@ -284,7 +284,7 @@ protected void generateRepresentationElement() {
             final String codec = itagInfo.getCodec();
             if (isNullOrEmpty(codec)) {
                 throw DashManifestCreationException.couldNotAddElement(ADAPTATION_SET,
-                        "the codec value of the ItagItem is null or empty");
+                        "invalid codec=" + codec);
             }
 
             appendNewAttrWithValue(
@@ -326,7 +326,7 @@ protected void generateRepresentationElement() {
 
                 if (videoQualityData.fps() > 0) {
                     appendNewAttrWithValue(
-                            representationElement, "height", videoQualityData.fps());
+                            representationElement, "frameRate", videoQualityData.fps());
                 }
             }
 

extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/dashmanifestcreator/YoutubeProgressiveDashManifestCreator.java

@@ -34,6 +34,7 @@ public String generateManifest() {
         }
 
         generateDocumentAndCommonElements(streamDurationMs);
+        generateBaseUrlElement(itagInfo.getStreamUrl());
         generateSegmentBaseElement();
         generateInitializationElement();
 

extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java

@@ -840,7 +840,7 @@ public void onFetchPage(@Nonnull final Downloader downloader)
                 .getBytes(StandardCharsets.UTF_8);
         nextResponse = getJsonPostResponse(NEXT, body, localization);
 
-        if ((!isAgeRestricted && !isLive && !isPostLive())
+        if ((!isAgeRestricted && !isLive && !isPostLive)
                 || isAndroidClientFetchForced) {
             try {
                 fetchAndroidMobileJsonPlayer(contentCountry, localization, videoId);
@@ -1318,7 +1318,7 @@ private <I extends ItagFormat<?>> ItagInfo<I> buildItagInfo(
             itagInfo.setFps(getNullableInteger(formatData, "fps"));
         }
 
-        itagInfo.setBitRate(getNullableInteger(formatData, "bitRate"));
+        itagInfo.setBitRate(getNullableInteger(formatData, "bitrate"));
         itagInfo.setQuality(formatData.getString("quality"));
 
         final String mimeType = formatData.getString("mimeType", "");

extractor/src/main/java/org/schabi/newpipe/extractor/streamdata/delivery/simpleimpl/SimpleDASHManifestDeliveryDataImpl.java

@@ -39,7 +39,7 @@ public DashManifestCreator getDashManifestCreator() {
 
     @Override
     public String getCachedDashManifestAsString() {
-        if (cachedDashManifest != null) {
+        if (cachedDashManifest == null) {
             cachedDashManifest = getDashManifestCreator().generateManifest();
         }
         return cachedDashManifest;

extractor/src/main/java/org/schabi/newpipe/extractor/utils/ManifestCreatorCache.java

@@ -1,25 +1,20 @@
 package org.schabi.newpipe.extractor.utils;
 
-import java.io.Serializable;
 import java.util.Objects;
 
 /**
- * Serializable class to create a pair of objects.
+ * class to create a pair of objects.
  *
- * <p>
- * The two objects of the pair must be {@link Serializable serializable} and can be of the same
- * type.
- * </p>
  *
  * <p>
  * Note that this class is not intended to be used as a general-purpose pair and should only be
  * used when interfacing with the extractor.
  * </p>
  *
- * @param <F> the type of the first object, which must be {@link Serializable}
- * @param <S> the type of the second object, which must be {@link Serializable}
+ * @param <F> the type of the first object
+ * @param <S> the type of the second object
  */
-public class Pair<F extends Serializable, S extends Serializable> implements Serializable {
+public class Pair<F, S> {
 
     /**
      * The first object of the pair.