Skip to content

Commit a719b7d

Browse files
committed
AudioStream: remove unused youtube-specific fields
These fields were added in #810 in preparation for a DASH support that never materialized … well it did materialize, but did not use any of these variables. Since they are youtube-specific, it does not make much sense to export them in the generic API, lest people start depending on them as if they belonged to all backends. Well, 4 variables are actually already depended on in places, they will have to be checked separately. But this is the low-hanging fruit.
1 parent 3402cdb commit a719b7d

File tree

1 file changed

+1
-96
lines changed

1 file changed

+1
-96
lines changed

extractor/src/main/java/org/schabi/newpipe/extractor/stream/AudioStream.java

Lines changed: 1 addition & 96 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,7 @@ public final class AudioStream extends Stream {
3333

3434
private final int averageBitrate;
3535

36-
// Fields for DASH
37-
private int itag = ITAG_NOT_AVAILABLE_OR_NOT_APPLICABLE;
38-
private int bitrate;
39-
private int initStart;
40-
private int initEnd;
41-
private int indexStart;
42-
private int indexEnd;
36+
// Fields specific to the Youtube backend
4337
private String quality;
4438
private String codec;
4539

@@ -348,14 +342,7 @@ private AudioStream(@Nonnull final String id,
348342
@Nullable final ItagItem itagItem) {
349343
super(id, content, isUrl, format, deliveryMethod, manifestUrl);
350344
if (itagItem != null) {
351-
this.itagItem = itagItem;
352-
this.itag = itagItem.id;
353345
this.quality = itagItem.getQuality();
354-
this.bitrate = itagItem.getBitrate();
355-
this.initStart = itagItem.getInitStart();
356-
this.initEnd = itagItem.getInitEnd();
357-
this.indexStart = itagItem.getIndexStart();
358-
this.indexEnd = itagItem.getIndexEnd();
359346
this.codec = itagItem.getCodec();
360347
}
361348
this.averageBitrate = averageBitrate;
@@ -386,88 +373,6 @@ public int getAverageBitrate() {
386373
return averageBitrate;
387374
}
388375

389-
/**
390-
* Get the itag identifier of the stream.
391-
*
392-
* <p>
393-
* Always equals to {@link #ITAG_NOT_AVAILABLE_OR_NOT_APPLICABLE} for other streams than the
394-
* ones of the YouTube service.
395-
* </p>
396-
*
397-
* @return the number of the {@link ItagItem} passed in the constructor of the audio stream.
398-
*/
399-
public int getItag() {
400-
return itag;
401-
}
402-
403-
/**
404-
* Get the bitrate of the stream.
405-
*
406-
* @return the bitrate set from the {@link ItagItem} passed in the constructor of the stream.
407-
*/
408-
public int getBitrate() {
409-
return bitrate;
410-
}
411-
412-
/**
413-
* Get the initialization start of the stream.
414-
*
415-
* @return the initialization start value set from the {@link ItagItem} passed in the
416-
* constructor of the stream.
417-
*/
418-
public int getInitStart() {
419-
return initStart;
420-
}
421-
422-
/**
423-
* Get the initialization end of the stream.
424-
*
425-
* @return the initialization end value set from the {@link ItagItem} passed in the constructor
426-
* of the stream.
427-
*/
428-
public int getInitEnd() {
429-
return initEnd;
430-
}
431-
432-
/**
433-
* Get the index start of the stream.
434-
*
435-
* @return the index start value set from the {@link ItagItem} passed in the constructor of the
436-
* stream.
437-
*/
438-
public int getIndexStart() {
439-
return indexStart;
440-
}
441-
442-
/**
443-
* Get the index end of the stream.
444-
*
445-
* @return the index end value set from the {@link ItagItem} passed in the constructor of the
446-
* stream.
447-
*/
448-
public int getIndexEnd() {
449-
return indexEnd;
450-
}
451-
452-
/**
453-
* Get the quality of the stream.
454-
*
455-
* @return the quality label set from the {@link ItagItem} passed in the constructor of the
456-
* stream.
457-
*/
458-
public String getQuality() {
459-
return quality;
460-
}
461-
462-
/**
463-
* Get the codec of the stream.
464-
*
465-
* @return the codec set from the {@link ItagItem} passed in the constructor of the stream.
466-
*/
467-
public String getCodec() {
468-
return codec;
469-
}
470-
471376
/**
472377
* Get the id of the audio track.
473378
*

0 commit comments

Comments
 (0)