Skip to content

Commit b6ffda5

Browse files
committed
Adjusted checkstyle
Removed suppression file and use inline comments: Modifying the suppression file is no longer required when moving code in affected classes
1 parent 797cdc8 commit b6ffda5

File tree

4 files changed

+6
-21
lines changed

4 files changed

+6
-21
lines changed

checkstyle/checkstyle.xml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,6 @@
2020
<property name="fileNamePattern" value="module\-info\.java$"/>
2121
</module>
2222

23-
<!-- https://checkstyle.org/config_filters.html#SuppressionFilter -->
24-
<module name="SuppressionFilter">
25-
<property name="file" value="${config_loc}/suppressions.xml" />
26-
<property name="optional" value="true"/>
27-
</module>
28-
2923
<!-- Checks that a package-info.java file exists for each package. -->
3024
<!-- See https://checkstyle.org/config_javadoc.html#JavadocPackage -->
3125
<!--<module name="JavadocPackage"/>-->
@@ -68,6 +62,8 @@
6862

6963
<module name="SuppressWarningsFilter" />
7064

65+
<module name="SuppressWithPlainTextCommentFilter"/>
66+
7167
<module name="TreeWalker">
7268
<!-- Checks for Javadoc comments. -->
7369
<!-- See https://checkstyle.org/config_javadoc.html -->

checkstyle/suppressions.xml

Lines changed: 0 additions & 15 deletions
This file was deleted.

extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampExtractorHelper.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,13 @@ public static String getStreamUrlFromIds(final long bandId,
4949

5050
}
5151

52+
// CHECKSTYLE:OFF - url has to be there in one piece
5253
/**
5354
* Fetch artist details from mobile endpoint.
5455
* <a href=https://notabug.org/fynngodau/bandcampDirect/wiki/rewindBandcamp+%E2%80%93+Fetching+artist+details>
5556
* More technical info.</a>
5657
*/
58+
// CHECKSTYLE:ON
5759
public static JsonObject getArtistDetails(final String id) throws ParsingException {
5860
try {
5961
return

extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/shared/ItagItem.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,12 @@
1414
import org.schabi.newpipe.extractor.exceptions.ParsingException;
1515

1616
public class ItagItem {
17+
// CHECKSTYLE:OFF - url has to be there in one piece
1718
/**
1819
* List can be found here
1920
* https://github.com/ytdl-org/youtube-dl/blob/9fc5eafb8e384453a49f7cfe73147be491f0b19d/youtube_dl/extractor/youtube.py#L1071
2021
*/
22+
// CHECKSTYLE:ON
2123
private static final ItagItem[] ITAG_LIST = {
2224
/////////////////////////////////////////////////////
2325
// VIDEO ID Type Format Resolution FPS ///

0 commit comments

Comments
 (0)