Skip to content

Commit b55ee7a

Browse files
authored
Merge pull request #254 from TeamPINGLE/hotfix-snackbar-view
[hotfix] Snackbar로 인한 앱 터지는 현상
2 parents b463eb0 + bf54428 commit b55ee7a

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

app/src/main/java/org/sopt/pingle/presentation/ui/newgroup/newgroupinput/NewGroupInputFragment.kt

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,8 @@ class NewGroupInputFragment :
5858
private fun collectNewGroupName() {
5959
newGroupViewModel.newGroupName.flowWithLifecycle(viewLifecycleOwner.lifecycle)
6060
.distinctUntilChanged().onEach { newGroupName ->
61-
binding.etNewGroupInputGroupName.btnEditTextCheck.isEnabled = newGroupName.isNotBlank()
61+
binding.etNewGroupInputGroupName.btnEditTextCheck.isEnabled =
62+
newGroupName.isNotBlank()
6263
newGroupViewModel.setIsGroupNameDuplicatedCheck(false)
6364
}.launchIn(viewLifecycleOwner.lifecycleScope)
6465
}
@@ -71,18 +72,18 @@ class NewGroupInputFragment :
7172
is UiState.Success -> {
7273
if (uiState.data.result) {
7374
PingleSnackbar.makeSnackbar(
74-
binding.root,
75-
stringOf(R.string.new_group_input_snackbar_guide),
76-
SNACKBAR_BOTTOM_MARGIN,
77-
SnackbarType.GUIDE
75+
view = requireView(),
76+
message = stringOf(R.string.new_group_input_snackbar_guide),
77+
bottomMarin = SNACKBAR_BOTTOM_MARGIN,
78+
snackbarType = SnackbarType.GUIDE
7879
)
7980
newGroupViewModel.setIsGroupNameDuplicatedCheck(true)
8081
} else {
8182
PingleSnackbar.makeSnackbar(
82-
binding.root,
83-
stringOf(R.string.new_group_input_snackbar_warning),
84-
SNACKBAR_BOTTOM_MARGIN,
85-
SnackbarType.WARNING
83+
view = requireView(),
84+
message = stringOf(R.string.new_group_input_snackbar_warning),
85+
bottomMarin = SNACKBAR_BOTTOM_MARGIN,
86+
snackbarType = SnackbarType.WARNING
8687
)
8788
newGroupViewModel.setIsGroupNameDuplicatedCheck(false)
8889
}

app/src/main/java/org/sopt/pingle/presentation/ui/plan/plandatetime/PlanDateTimeFragment.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ class PlanDateTimeFragment :
5959
if (selectedLocalDate != null) {
6060
if (selectedLocalDate.before(todayLocalDate)) {
6161
PingleSnackbar.makeSnackbar(
62-
binding.root,
62+
requireView(),
6363
getString(R.string.plan_future_date_snackbar),
6464
SNACKBAR_BOTTOM_MARGIN
6565
)
@@ -84,7 +84,7 @@ class PlanDateTimeFragment :
8484
START_TIME -> {
8585
if (planViewModel.endTime.value.isNotBlank() && time24Hour > planViewModel.endTime.value) {
8686
PingleSnackbar.makeSnackbar(
87-
binding.root,
87+
requireView(),
8888
getString(R.string.plan_later_time_snackbar),
8989
SNACKBAR_BOTTOM_MARGIN
9090
)
@@ -98,7 +98,7 @@ class PlanDateTimeFragment :
9898
END_TIME -> {
9999
if (planViewModel.startTime.value.isNotBlank() && time24Hour < planViewModel.startTime.value) {
100100
PingleSnackbar.makeSnackbar(
101-
binding.root,
101+
requireView(),
102102
getString(R.string.plan_later_time_snackbar),
103103
SNACKBAR_BOTTOM_MARGIN
104104
)

0 commit comments

Comments
 (0)