Skip to content

support react version 17 in peerDependencies #18

@mosijava

Description

@mosijava

can you please add react version 17 into package.json peerDependencies?
when i want to update my packages in npm version 7 i get this error:

Found: react@17.0.2
npm ERR! node_modules/react
npm ERR!   react@"^17.0.1" from the root project
npm ERR!   peer react@"^16.8.0 || ^17.0.0" from @material-ui/core@4.11.3
npm ERR!   node_modules/@material-ui/core
npm ERR!     @material-ui/core@"^4.11.3" from the root project
npm ERR!     peer @material-ui/core@"^1.0.0 || ^3.0.0 || ^4.0.0" from material-ui-toggle-icon@1.1.2
npm ERR!     node_modules/material-ui-toggle-icon
npm ERR!       material-ui-toggle-icon@"^1.1.2" from the root project
npm ERR!   1 more (react-dom)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.3.0" from material-ui-toggle-icon@1.1.2
npm ERR! node_modules/material-ui-toggle-icon
npm ERR!   material-ui-toggle-icon@"^1.1.2" from the root project`

sorry if I'm wrong but: I think you can support react version 17 by changing the peerDependecy to:

"react": "^16.3.0 || ^17.0.0",

p.s:
I know that you have to test this component in react version 17 first, but FYI material-ui-toggle-icon works fine with react version 17 in my project.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions