More efficient imports

[mbrevda]

When importing an icon using a destructuring (i.e. with named imports), it seems necessary (at least for some compilers?) to transverse the entire list of icons. This can lead to a relatively large performance penalty vs default exports. Here is feedback from one compiler and some ideas on how this can be improved.

[leMaik]

Apparently someone already changed this repo to make it more efficient, so... PR?

[mbrevda]

I don't have that code, but it seems pretty straightforward (assuming you'd be happy with esbuild). Are you ok with having all the icons inlined to a single file? (while improving bundle speed, which will effectively duplicate the package size)

[leMaik]

Not sure about that. I just checked @mui/material-icons and they also have one icon per file and re-exports in the index file. Webpack handles "pure" modules just fine and can optimize it ("sideEffects": false in the package.json file).

Sounds like a bundler issue to me, not like an issue that library maintainers should handle. 🤔

[mbrevda]

If this isn't project related, feel free to close.
Would you care to comment on the original issue and see if there is some way forward here?

[leMaik]

@mbrevda I did, but the issue over there is already closed. Apparently it's not an esbuild issue.

[mbrevda]

thanks!