Skip to content

Commit da98cef

Browse files
committed
0.2.1 - Fixed some StyleSheet type issues
1 parent f8e4a5b commit da98cef

File tree

3 files changed

+23
-17
lines changed

3 files changed

+23
-17
lines changed

CHANGELOG.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,13 @@ This project does its best to adhere to [Semantic Versioning](http://semver.org/
44

55

66
--------
7-
### [0.2.0](N/A) - 2017-06-29
7+
### [0.2.1](N/A) - 2017-06-29
8+
#### Changed
9+
* Fixed some StyleSheet type issues
10+
11+
12+
--------
13+
### [0.2.0](https://github.com/TeamworkGuy2/excel-builder-ts/commit/f8e4a5b0a06ca8c26154441b6b81ed7e0746b903) - 2017-06-29
814
#### Changed
915
* Added missing types and improved existing types (mostly in StyleSheet)
1016
* Removed `new ActiveXObject("Microsoft.XMLDOM")` fallback from Util.createXmlDoc() since `document.implementation.createDocument()` is supported by all major browsers

StyleSheet.ts

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,12 @@ class StyleSheet {
7575
}
7676

7777

78-
public createFill(fillInstructions: Partial<StyleSheet.Fill>) {
78+
public createFill(fillInstructions: StyleSheet.Fill): StyleSheet.Fill & { id: number } {
7979
var id = this.fills.length;
8080
var fill = fillInstructions;
8181
fill.id = id;
8282
this.fills.push(<StyleSheet.Fill>fill);
83-
return fill;
83+
return <any>fill;
8484
}
8585

8686

@@ -99,9 +99,9 @@ class StyleSheet {
9999
* horizontal: http://www.schemacentral.com/sc/ooxml/t-ssml_ST_HorizontalAlignment.html
100100
* vertical: http://www.schemacentral.com/sc/ooxml/t-ssml_ST_VerticalAlignment.html
101101
*/
102-
public createFormat(styleInstructions: { font?: object | number; format?: string | number; border?: { [key: string]: any } | number; fill?: Partial<StyleSheet.Fill> | number; alignment?: Partial<StyleSheet.Alignment>; }) {
102+
public createFormat(styleInstructions: { font?: object | number; format?: string | number; border?: { [key: string]: any } | number; fill?: StyleSheet.Fill | number; alignment?: Partial<StyleSheet.Alignment>; }) {
103103
var sid = this.masterCellFormats.length;
104-
var style: StyleSheet.CellFormat = {
104+
var style: StyleSheet.CellFormat & { id: number } = {
105105
id: sid,
106106
fontId: undefined,
107107
numFmtId: undefined,
@@ -165,7 +165,7 @@ class StyleSheet {
165165

166166
public createDifferentialStyle(styleInstructions: { font?: StyleSheet.FontStyle; border?: object; fill?: StyleSheet.Fill; alignment?: object; format?: string; }) {
167167
var id = this.differentialStyles.length;
168-
var style: StyleSheet.DifferentialStyle = {
168+
var style: StyleSheet.DifferentialStyle & { id: number } = {
169169
id: id,
170170
alignment: undefined,
171171
border: undefined,
@@ -227,7 +227,7 @@ class StyleSheet {
227227
* }
228228
*/
229229
public createBorderFormatter(border?: { top?; left?; right?; bottom?; diagonal?; outline?: boolean; diagonalUp?: boolean; diagonalDown?: boolean;[id: string]: any; }) {
230-
var res: StyleSheet.Border = Util.defaults(border, {
230+
var res: StyleSheet.Border & { id: number } = Util.defaults(border, {
231231
top: {},
232232
left: {},
233233
right: {},
@@ -257,7 +257,7 @@ class StyleSheet {
257257
*/
258258
public createFontStyle(instructions: { bold?: boolean; color?; fontName?: string; italic?: boolean; size?: number; shadow?: boolean; strike?: boolean; superscript?: boolean; subscript?: boolean; underline?: boolean | string; outline?: boolean; }) {
259259
var fontId = this.fonts.length;
260-
var fontStyle: StyleSheet.FontStyle = {
260+
var fontStyle: StyleSheet.FontStyle & { id: number } = {
261261
id: fontId,
262262
bold: undefined,
263263
color: undefined,
@@ -707,13 +707,13 @@ module StyleSheet {
707707
export interface Alignment {
708708
horizontal?: string;
709709
//indent?: number; // TODO
710-
justifyLastLine?: boolean;
710+
justifyLastLine?: 0 | 1;
711711
readingOrder?: number;
712712
relativeIndent?: number;
713-
shrinkToFit?: boolean;
713+
shrinkToFit?: 0 | 1;
714714
textRotation?: number;
715715
vertical?: string;
716-
wrapText?: boolean;
716+
wrapText?: 0 | 1;
717717
}
718718

719719

@@ -724,9 +724,9 @@ module StyleSheet {
724724
top?: BorderProperty;
725725
bottom?: BorderProperty;
726726
diagonal?: BorderProperty;
727-
diagonalDown?: boolean;
728-
diagonalUp?: boolean;
729-
outline?: boolean;
727+
diagonalDown?: 0 | 1;
728+
diagonalUp?: 0 | 1;
729+
outline?: 0 | 1;
730730
}
731731

732732

@@ -765,7 +765,7 @@ module StyleSheet {
765765

766766

767767
export interface DifferentialStyle {
768-
id: number;
768+
id?: number;
769769
alignment?: { [key: string]: any };
770770
border?: Border;
771771
fill?: Fill;
@@ -793,7 +793,7 @@ module StyleSheet {
793793

794794

795795
export interface FontStyle {
796-
id: number;
796+
id?: number;
797797
bold?: boolean;
798798
color?: string;
799799
fontName?: string;

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "excel-builder-ts",
3-
"version": "0.2.0",
3+
"version": "0.2.1",
44
"description": "TypeScript Port of the excel-builder.js Library - 'A way to build excel files with javascript'",
55
"dependencies": {
66
},

0 commit comments

Comments
 (0)