Skip to content

Commit 0a35e02

Browse files
Merge pull request #9620 from jonathanhefner/nextjs-enable-fortunes-test
[nextjs] Enable Fortunes test
2 parents 0032e17 + 2ca7562 commit 0a35e02

File tree

2 files changed

+1
-19
lines changed

2 files changed

+1
-19
lines changed

frameworks/TypeScript/nextjs/README.md

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -27,21 +27,3 @@
2727
[`app/updates/route.ts`]: ./app/updates/route.ts
2828
[`app/plaintext/route.ts`]: ./app/plaintext/route.ts
2929
[`app/cached-queries/route.ts`]: ./app/cached-queries/route.ts
30-
31-
## TODO
32-
33-
The Fortunes test is currently disabled because the benchmark expects exact HTML output — see [TechEmpower/FrameworkBenchmarks#9505](https://github.com/TechEmpower/FrameworkBenchmarks/pull/9505). After that issue is resolved, the Fortunes test can be re-enabled by applying the following diff:
34-
35-
```diff
36-
--- a/frameworks/TypeScript/nextjs/benchmark_config.json
37-
+++ b/frameworks/TypeScript/nextjs/benchmark_config.json
38-
@@ -20,7 +20,7 @@
39-
"json_url": "/json",
40-
"db_url": "/db",
41-
"query_url": "/queries?queries=",
42-
- "TEMPORARILY DISABLED fortune_url": "/fortunes",
43-
+ "fortune_url": "/fortunes",
44-
"update_url": "/updates?queries=",
45-
"plaintext_url": "/plaintext",
46-
"cached_query_url": "/cached-queries?queries="
47-
```

frameworks/TypeScript/nextjs/benchmark_config.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"json_url": "/json",
2121
"db_url": "/db",
2222
"query_url": "/queries?queries=",
23-
"TEMPORARILY DISABLED fortune_url": "/fortunes",
23+
"fortune_url": "/fortunes",
2424
"update_url": "/updates?queries=",
2525
"plaintext_url": "/plaintext",
2626
"cached_query_url": "/cached-queries?queries="

0 commit comments

Comments
 (0)