Skip to content

Commit 2fd2be7

Browse files
authored
Optimize sharaf framework SQL (#9739)
* Update sharaf dependency on squery that contains a perf fix. Disable sharaf logging and optimize hikaricp * Revert sharaf.dockerfile jar change
1 parent 9be8abf commit 2fd2be7

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

frameworks/Scala/sharaf/build.mill

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,9 @@ object `package` extends RootModule with ScalaModule {
77
def scalaVersion = "3.6.2"
88
def ivyDeps = Agg(
99
ivy"ba.sake::sharaf:0.8.1",
10-
ivy"ba.sake::squery:0.6.4",
10+
ivy"ba.sake::squery:0.7.0",
1111
ivy"org.postgresql:postgresql:42.6.0",
12-
ivy"com.zaxxer:HikariCP:5.0.1"
12+
ivy"com.zaxxer:HikariCP:5.0.1",
13+
ivy"org.slf4j:slf4j-nop:2.0.17" // disable logging
1314
)
14-
}
15+
}

frameworks/Scala/sharaf/sharaf.dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ RUN ./mill assembly
1111

1212
EXPOSE 8080
1313

14-
CMD ["java", "-server", "-Xms1g", "-Xmx1g", "-jar", "out/assembly.dest/out.jar"]
14+
CMD ["java", "-server", "-Xms2g", "-Xmx2g", "-jar", "out/assembly.dest/out.jar"]

frameworks/Scala/sharaf/src/db.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ class DAO {
1010
ds.setJdbcUrl("jdbc:postgresql://tfb-database:5432/hello_world")
1111
ds.setUsername("benchmarkdbuser")
1212
ds.setPassword("benchmarkdbpass")
13-
ds.setMaximumPoolSize(48)
13+
ds.setMaximumPoolSize(Runtime.getRuntime().availableProcessors() * 2 + 1)
1414
private val squeryContext = SqueryContext(ds)
1515

1616
def getRandomWorld(): WorldRow = squeryContext.run {

frameworks/Scala/sharaf/src/main.scala

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ import ba.sake.sharaf.*
77
@main def run(): Unit = {
88
val dao = DAO()
99
val benchmarkRoutes = BenchmarkRoutes(dao)
10+
// set to slf4j, thus disabling logging (slf4j-nop)
11+
System.setProperty("org.jboss.logging.provider", "slf4j")
1012
val server = Undertow
1113
.builder()
1214
.addHttpListener(8080, "0.0.0.0")
@@ -18,5 +20,5 @@ import ba.sake.sharaf.*
1820
.setServerOption(UndertowOptions.ALWAYS_SET_KEEP_ALIVE, false)
1921
.build()
2022
server.start()
21-
println(s"Started HTTP server at localhost:8080")
23+
//println(s"Started HTTP server at localhost:8080")
2224
}

0 commit comments

Comments
 (0)