Skip to content

Commit 5b5877f

Browse files
authored
Salvo: upgrade rust version (#7105)
* salvo: remove socket2 * salvo: upgrade rust version * salvo: remove salvo-db * salvo: rename req to _req
1 parent e7fa465 commit 5b5877f

File tree

9 files changed

+38
-39
lines changed

9 files changed

+38
-39
lines changed

frameworks/Rust/faf/Cargo.lock

Lines changed: 15 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

frameworks/Rust/salvo/Cargo.toml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ name = "main-pg"
1616
path = "src/main_pg.rs"
1717

1818
[dependencies]
19-
anyhow = "1"
19+
anyhow = "1.0"
2020
async-trait = "0.1.51"
2121
diesel = { version = "1.4", features = ["postgres", "r2d2"] }
2222
futures = "0.3"
@@ -32,7 +32,6 @@ serde_derive = "1.0.125"
3232
serde_json = "1.0.64"
3333
smallvec = "1.6.1"
3434
snmalloc-rs = { version = "0.2.24", features = ["1mib", "native-cpu"] }
35-
socket2 = { version = "0.4.2", features = ["all"] }
3635
tokio = { version = "1", features = ["macros", "rt"] }
3736
tokio-postgres = "0.7.2"
3837
v_htmlescape = "0.14"
@@ -42,3 +41,5 @@ lto = true
4241
opt-level = 3
4342
codegen-units = 1
4443
panic = "abort"
44+
debug = false
45+
incremental = false

frameworks/Rust/salvo/salvo-db.dockerfile

Lines changed: 0 additions & 13 deletions
This file was deleted.

frameworks/Rust/salvo/salvo-diesel.dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM rust:1.56
1+
FROM rust:1.58.1
22

33
RUN apt-get update -yqq && apt-get install -yqq cmake g++
44

frameworks/Rust/salvo/salvo-pg.dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM rust:1.56
1+
FROM rust:1.58.1
22

33
RUN apt-get update -yqq && apt-get install -yqq cmake g++
44

frameworks/Rust/salvo/salvo.dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM rust:1.56
1+
FROM rust:1.58.1
22

33
# Disable simd at jsonescape
44
ENV CARGO_CFG_JSONESCAPE_DISABLE_AUTO_SIMD=

frameworks/Rust/salvo/src/main.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
#[global_allocator]
2-
static ALLOC: snmalloc_rs::SnMalloc = snmalloc_rs::SnMalloc;
1+
// #[global_allocator]
2+
// static ALLOC: snmalloc_rs::SnMalloc = snmalloc_rs::SnMalloc;
33
// #[global_allocator]
44
// static GLOBAL: mimalloc::MiMalloc = mimalloc::MiMalloc;
55

frameworks/Rust/salvo/src/main_diesel.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ fn build_pool(database_url: &str, size: u32) -> Result<PgPool, PoolError> {
4646
}
4747

4848
#[fn_handler]
49-
async fn world_row(_req: &mut Request, res: &mut Response) -> Result<(), Error> {
49+
async fn world_row(res: &mut Response) -> Result<(), Error> {
5050
let mut rng = SmallRng::from_entropy();
5151
let random_id = rng.gen_range(1..10_001);
5252
let conn = connect()?;
@@ -121,7 +121,7 @@ async fn updates(req: &mut Request, res: &mut Response) -> Result<(), Error> {
121121
}
122122

123123
#[fn_handler]
124-
async fn fortunes(_req: &mut Request, res: &mut Response) -> Result<(), Error> {
124+
async fn fortunes(res: &mut Response) -> Result<(), Error> {
125125
let conn = connect()?;
126126
let mut items = fortune::table.get_results::<Fortune>(&conn)?;
127127
items.push(Fortune {

frameworks/Rust/salvo/src/server.rs

Lines changed: 13 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,31 @@
11
use std::io;
2-
use std::net::SocketAddr;
2+
use std::net::{Ipv4Addr, SocketAddr};
33

44
use salvo::hyper::server::conn::AddrIncoming;
55
use salvo::hyper;
6-
use socket2::{Domain, Socket, Type};
7-
use tokio::net::TcpListener;
6+
use tokio::net::{TcpListener, TcpSocket};
87

98
pub fn builder() -> hyper::server::Builder<AddrIncoming> {
10-
let addr = SocketAddr::from(([0, 0, 0, 0], 8080));
9+
let addr = SocketAddr::from((Ipv4Addr::UNSPECIFIED, 8080));
1110
let listener = reuse_listener(addr).expect("couldn't bind to addr");
1211
let incoming = AddrIncoming::from_listener(listener).unwrap();
1312
hyper::Server::builder(incoming).http1_only(true).tcp_nodelay(true)
1413
}
1514

1615
fn reuse_listener(addr: SocketAddr) -> io::Result<TcpListener> {
1716
let socket = match addr {
18-
SocketAddr::V4(_) => Socket::new(Domain::IPV4, Type::STREAM, None)?,
19-
SocketAddr::V6(_) => Socket::new(Domain::IPV6, Type::STREAM, None)?,
17+
SocketAddr::V4(_) => TcpSocket::new_v4()?,
18+
SocketAddr::V6(_) => TcpSocket::new_v6()?,
2019
};
2120

2221
#[cfg(unix)]
23-
{
24-
if let Err(e) = socket.set_reuse_port(true) {
25-
eprintln!("error setting SO_REUSEPORT: {}", e);
22+
{
23+
if let Err(e) = socket.set_reuseport(true) {
24+
eprintln!("error setting SO_REUSEPORT: {}", e);
25+
}
2626
}
27-
}
2827

29-
socket.set_reuse_address(true)?;
30-
socket.set_nonblocking(true)?;
31-
socket.set_nodelay(true)?;
32-
socket.bind(&addr.into())?;
33-
socket.listen(1024)?;
34-
Ok(TcpListener::from_std(socket.into())?)
35-
}
28+
socket.set_reuseaddr(true)?;
29+
socket.bind(addr)?;
30+
socket.listen(1024)
31+
}

0 commit comments

Comments
 (0)