Skip to content

Commit d8d4431

Browse files
authored
[ruby/roda-sequel] Remove Unicorn variant (#9890)
Unicorn hasn't been updated for 4 years and seems unmaintained. It isn't the fastest on any of the benchmarks either.
1 parent 3757c9c commit d8d4431

File tree

8 files changed

+1
-139
lines changed

8 files changed

+1
-139
lines changed

frameworks/Ruby/roda-sequel/Gemfile

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,3 @@ end
2323
group :puma, optional: true do
2424
gem "puma", "~> 6.2", require: false
2525
end
26-
27-
group :unicorn, optional: true do
28-
gem 'logger' # required by unicorn on Ruby 3.5
29-
gem "unicorn", "~> 6.1", platforms: %i[ruby mswin], require: false
30-
end

frameworks/Ruby/roda-sequel/Gemfile.lock

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,12 @@ GEM
66
erubi (1.13.1)
77
iodine (0.7.58)
88
json (2.11.3)
9-
kgio (2.11.4)
10-
logger (1.7.0)
119
mysql2 (0.5.6)
1210
nio4r (2.7.4)
1311
pg (1.5.9)
1412
puma (6.6.0)
1513
nio4r (~> 2.0)
1614
rack (3.1.12)
17-
raindrops (0.20.1)
1815
roda (3.90.0)
1916
rack
2017
sequel (5.90.0)
@@ -23,9 +20,6 @@ GEM
2320
pg (>= 0.18.0, != 1.2.0)
2421
sequel (>= 4.38.0)
2522
tilt (2.6.0)
26-
unicorn (6.1.0)
27-
kgio (~> 2.6)
28-
raindrops (~> 0.7)
2923

3024
PLATFORMS
3125
ruby
@@ -37,15 +31,13 @@ DEPENDENCIES
3731
erubi (~> 1.12)
3832
iodine (~> 0.7)
3933
json (~> 2.8)
40-
logger
4134
mysql2 (~> 0.5)
4235
pg (~> 1.4)
4336
puma (~> 6.2)
4437
roda (~> 3.66)
4538
sequel (~> 5.67)
4639
sequel_pg (~> 1.17)
4740
tilt (~> 2.1)
48-
unicorn (~> 6.1)
4941

5042
BUNDLED WITH
5143
2.6.2

frameworks/Ruby/roda-sequel/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ The tests will be run with:
1414

1515
* [Ruby 3.4](http://www.ruby-lang.org)
1616
* [Puma 6](http://puma.io)
17-
* [Unicorn 6](https://bogomips.org/unicorn/)
1817
* [Iodine](https://github.com/boazsegev/iodine)
1918
* [Roda 3](http://roda.jeremyevans.net)
2019
* [Sequel 5](http://sequel.jeremyevans.net)

frameworks/Ruby/roda-sequel/benchmark_config.json

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -65,26 +65,6 @@
6565
"display_name": "roda-sequel-postgres-iodine-mri",
6666
"versus": "rack-sequel-postgres-iodine-mri",
6767
"notes": ""
68-
},
69-
"postgres-unicorn-mri": {
70-
"db_url": "/db",
71-
"query_url": "/queries?queries=",
72-
"fortune_url": "/fortunes",
73-
"update_url": "/updates?queries=",
74-
"port": 8080,
75-
"approach": "Realistic",
76-
"classification": "Micro",
77-
"database": "Postgres",
78-
"framework": "roda-sequel",
79-
"language": "Ruby",
80-
"orm": "Full",
81-
"platform": "Rack",
82-
"webserver": "Unicorn",
83-
"os": "Linux",
84-
"database_os": "Linux",
85-
"display_name": "roda-sequel-postgres-unicorn-mri",
86-
"versus": "rack-sequel-postgres-unicorn-mri",
87-
"notes": ""
8868
}
8969
}
9070
]

frameworks/Ruby/roda-sequel/boot.rb

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,7 @@
88
QUERIES_MAX = 500
99
SEQUEL_NO_ASSOCIATIONS = true
1010

11-
SERVER_STRING =
12-
if defined?(Iodine)
13-
"Iodine"
14-
elsif defined?(Puma)
15-
"Puma"
16-
elsif defined?(Unicorn)
17-
"Unicorn"
18-
end
11+
SERVER_STRING = "roda"
1912

2013
Bundler.require(:default) # Load core modules
2114

@@ -45,8 +38,6 @@ def connect(dbtype)
4538
(threads = Puma.cli_config.options.fetch(:max_threads)) > 1
4639
opts[:max_connections] = (2 * Math.log(threads)).floor
4740
opts[:pool_timeout] = 10
48-
elsif defined?(Unicorn)
49-
Sequel.single_threaded = true
5041
end
5142

5243
Sequel.connect "%{adapter}://%{host}/%{database}?user=%{user}&password=%{password}" %

frameworks/Ruby/roda-sequel/config.toml

Lines changed: 0 additions & 68 deletions
Original file line numberDiff line numberDiff line change
@@ -34,71 +34,3 @@ orm = "Full"
3434
platform = "Rack"
3535
webserver = "Puma"
3636
versus = "rack-sequel-puma-mri"
37-
38-
[postgres-passenger-mri]
39-
urls.plaintext = "/plaintext"
40-
urls.json = "/json"
41-
urls.db = "/db"
42-
urls.query = "/queries?queries="
43-
urls.update = "/updates?queries="
44-
urls.fortune = "/fortunes"
45-
approach = "Realistic"
46-
classification = "Micro"
47-
database = "Postgres"
48-
database_os = "Linux"
49-
os = "Linux"
50-
orm = "Full"
51-
platform = "Rack"
52-
webserver = "Passenger"
53-
versus = "rack-sequel-postgres-passenger-mri"
54-
55-
[postgres-unicorn-mri]
56-
urls.plaintext = "/plaintext"
57-
urls.json = "/json"
58-
urls.db = "/db"
59-
urls.query = "/queries?queries="
60-
urls.update = "/updates?queries="
61-
urls.fortune = "/fortunes"
62-
approach = "Realistic"
63-
classification = "Micro"
64-
database = "Postgres"
65-
database_os = "Linux"
66-
os = "Linux"
67-
orm = "Full"
68-
platform = "Rack"
69-
webserver = "Unicorn"
70-
versus = "rack-sequel-postgres-unicorn-mri"
71-
72-
[passenger-mri]
73-
urls.plaintext = "/plaintext"
74-
urls.json = "/json"
75-
urls.db = "/db"
76-
urls.query = "/queries?queries="
77-
urls.update = "/updates?queries="
78-
urls.fortune = "/fortunes"
79-
approach = "Realistic"
80-
classification = "Micro"
81-
database = "MySQL"
82-
database_os = "Linux"
83-
os = "Linux"
84-
orm = "Full"
85-
platform = "Rack"
86-
webserver = "Passenger"
87-
versus = "rack-sequel-passenger-mri"
88-
89-
[unicorn-mri]
90-
urls.plaintext = "/plaintext"
91-
urls.json = "/json"
92-
urls.db = "/db"
93-
urls.query = "/queries?queries="
94-
urls.update = "/updates?queries="
95-
urls.fortune = "/fortunes"
96-
approach = "Realistic"
97-
classification = "Micro"
98-
database = "MySQL"
99-
database_os = "Linux"
100-
os = "Linux"
101-
orm = "Full"
102-
platform = "Rack"
103-
webserver = "Unicorn"
104-
versus = "rack-sequel-unicorn-mri"

frameworks/Ruby/roda-sequel/config/mri_unicorn.rb

Lines changed: 0 additions & 6 deletions
This file was deleted.

frameworks/Ruby/roda-sequel/roda-sequel-postgres-unicorn-mri.dockerfile

Lines changed: 0 additions & 21 deletions
This file was deleted.

0 commit comments

Comments
 (0)