Runtime improvements #9722
Runtime improvements #9722
Conversation
|
Looks good. Let's review and merge please :) |
|
|
||
| get("/json") { | ||
| call.respondText(Json.encodeToString(Message("Hello, world!")), ContentType.Application.Json) | ||
| call.respondText(jsonResponse, ContentType.Application.Json) |
There was a problem hiding this comment.
Hey, I was just making some updates for Ktor and I noticed this might be in violation of one of the test rules:
For each request, an object mapping the key message to Hello, World! must be instantiated.
Is this not applicable here, or should I change it?
There was a problem hiding this comment.
@bjhham I just checked, you are correct, I missed this rule. We should fix this.
There was a problem hiding this comment.
Bah, I'm going too quickly this morning. You are correct - you need to instantiate the object on every request with the json test.
Your plaintext is fine.
Unfortunately, Github won't let me un-merge - can you please open a second PR and resolve?
There was a problem hiding this comment.
Yep, I'll open one soon with a few tweaks to response streaming and an update to 3.1.2. as well. Thanks for updating it to 3.0 btw, I had intended to in 2024 but it slipped my mind.
There was a problem hiding this comment.
No worries, I really enjoy using Ktor.
I struggled to optimize "/update" endpoint though, maybe you know a better way 😅
3 participants
Uh oh!
There was an error while loading. Please reload this page.