-
Notifications
You must be signed in to change notification settings - Fork 2k
Runtime improvements #9722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Runtime improvements #9722
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c21e8fa
upgrade ktor depds
inemtsev b44474e
Update build.gradle.kts
inemtsev 1c19580
Update pom.xml
inemtsev 7d30e3b
Update pom.xml
inemtsev 19e8695
some optimizations
inemtsev f0d67da
improved r2dbc
inemtsev 28fc661
upgrade kotlin version
inemtsev 19de049
Merge branch 'master' into update-ktor
inemtsev 2e35849
fixed update
inemtsev d16be8c
cleanup
inemtsev e083c6d
cleanup 2
inemtsev a7714ad
fix db params
inemtsev aea722c
simplify update
inemtsev 19b4f5b
added null checks
inemtsev 6762569
revert /update change
inemtsev 12d0c58
cleanup update
inemtsev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 10 additions & 10 deletions
20
frameworks/Kotlin/ktor/ktor-r2dbc/src/main/resources/logback.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,21 @@ | ||
| <configuration> | ||
| <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender"> | ||
| <encoder> | ||
| <pattern>%d{YYYY-MM-dd HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n</pattern> | ||
| <pattern>%msg%n</pattern> | ||
| </encoder> | ||
| </appender> | ||
|
|
||
| <appender name="ASYNC" class="ch.qos.logback.classic.AsyncAppender"> | ||
| <neverBlock>true</neverBlock> | ||
| <appender-ref ref="STDOUT" /> | ||
| </appender> | ||
|
|
||
| <appender name="ASYNC" class="ch.qos.logback.classic.AsyncAppender"> | ||
| <neverBlock>true</neverBlock> | ||
| <appender-ref ref="STDOUT" /> | ||
| </appender> | ||
|
|
||
| <root level="INFO"> | ||
| <root level="WARN"> | ||
| <appender-ref ref="ASYNC"/> | ||
| </root> | ||
|
|
||
| <logger name="org.eclipse.jetty" level="INFO"/> | ||
| <logger name="io.netty" level="INFO"/> | ||
|
|
||
| <logger name="org.eclipse.jetty" level="WARN"/> | ||
| <logger name="io.netty" level="WARN"/> | ||
| <logger name="io.r2dbc" level="WARN"/> | ||
| <logger name="reactor" level="WARN"/> | ||
| </configuration> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I was just making some updates for Ktor and I noticed this might be in violation of one of the test rules:
Is this not applicable here, or should I change it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bjhham I just checked, you are correct, I missed this rule. We should fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bah, I'm going too quickly this morning. You are correct - you need to instantiate the object on every request with the
jsontest.Your
plaintextis fine.Unfortunately, Github won't let me un-merge - can you please open a second PR and resolve?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I'll open one soon with a few tweaks to response streaming and an update to 3.1.2. as well. Thanks for updating it to 3.0 btw, I had intended to in 2024 but it slipped my mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, I really enjoy using Ktor.
I struggled to optimize "/update" endpoint though, maybe you know a better way 😅