Skip to content

Conversation

@joanhey
Copy link
Contributor

@joanhey joanhey commented May 6, 2025

The namespace for the Timer change in Workerman/5.
We fix it with this PR, or the next run will fail almost all.

We add also reuseport.
Actually all AdapterMan implementations are not using JIT.

joanhey added 2 commits May 6, 2025 12:22
In Workerman/5 it is NOT automatic
@joanhey
Copy link
Contributor Author

joanhey commented May 6, 2025

Only fail PHP with Caddy server, that this PR don't touch, and also fail in the last runs.
It's a problem with the Server header in the last Caddy/2.10.0 (3 weeks ago) that change when send also via header.

I'll try to fix it in another PR.

@joanhey
Copy link
Contributor Author

joanhey commented May 7, 2025

This PR is ready to be merged !!

@joanhey
Copy link
Contributor Author

joanhey commented May 7, 2025

@msmith-techempower

@joanhey
Copy link
Contributor Author

joanhey commented May 7, 2025

If this PR is not merged, I can't fix the PHP with Caddy server !!!

@msmith-techempower msmith-techempower merged commit 3991208 into TechEmpower:master May 7, 2025
2 of 3 checks passed
@joanhey joanhey deleted the Adapterman-workerman/5 branch May 7, 2025 18:27
litongjava pushed a commit to litongjava/FrameworkBenchmarks that referenced this pull request May 30, 2025
* [php] Update for Workerman/5

* Use reusePort
In Workerman/5 it is NOT automatic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants