Merge pull request #21 from TechNobre/develop

Fix `System.IndexOutOfRangeException` when format the properties name to camel case;

Author: NelsonBN

.github/workflows/publish-nuget.yml

@@ -1,33 +1,47 @@
-name: 'Publish Nuget'
+name: 'Publish nuget'
+
+
 
 on:
   push:
     branches:
-      - main
+      - deploy-nuget
+
+
+
+env:
+  SDK_VERSION: '6.0.300'
+  PACKAGE_PATH: ./src/**/*.nupkg
+  NUGET_SERVER: https://api.nuget.org/v3/index.json
+
 
 
 jobs:
 
   deploy-nuget:
-    name: "Deploy NuGet"
+    name: "Deploy nuget"
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@main
+    - name: "Checkout"
+      uses: actions/checkout@v3
 
-    - name: Setup .NET
+    - name: "Setup .NET"
       uses: actions/setup-dotnet@v2
       with:
-        dotnet-version: '6.0.201'
+        dotnet-version: ${{ env.SDK_VERSION }}
 
-    - name: Restore dependencies
+    - name: "Restore dependencies"
       run: dotnet restore
 
-    - name: Build
-      run: dotnet build --configuration Release
+    - name: "Build"
+      run: dotnet build --configuration Release --no-restore
+
+    - name: "Test"
+      run: dotnet test --configuration Release --no-build
 
-    - name: Create the Package
-      run: dotnet pack --configuration Release
+    - name: "Pack"
+      run: dotnet pack --configuration Release --no-build
 
-    - name: Publish
-      run: dotnet nuget push "./src/bin/PowerUtils.AspNetCore.ErrorHandler.*.nupkg" -k ${{ secrets.NUGET_TOKEN }} -s https://api.nuget.org/v3/index.json
+    - name: "Publish nuget"
+      run: dotnet nuget push ${{ env.PACKAGE_PATH }} --api-key ${{ secrets.NUGET_TOKEN }} --source ${{ env.NUGET_SERVER }} --skip-duplicate

.github/workflows/sonarcloud.yml

@@ -1,5 +1,7 @@
 name: 'SonarCloud'
 
+
+
 on:
   push:
     branches:
@@ -10,57 +12,64 @@ on:
       - main
 
 
+
+env:
+  SDK_VERSION: '6.0.300'
+
+
+
 jobs:
 
   sonar-scanner:
     name: "Sonar scanner"
     runs-on: windows-latest
-    steps:
 
-    - name: Setup .NET
+    steps:
+    - name: "Setup .NET"
       uses: actions/setup-dotnet@v2
       with:
-        dotnet-version: '6.0.201'
+        dotnet-version: ${{ env.SDK_VERSION }}
 
-    - name: Set up JDK 11
-      uses: actions/setup-java@v3.0.0
+    - name: "Set up JDK 11"
+      uses: actions/setup-java@v3.3.0
       with:
         distribution: 'adopt'
         java-version: '11'
 
-    - uses: actions/checkout@v2
+    - name: "Checkout"
+      uses: actions/checkout@v3
       with:
         fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
 
-    - name: Cache SonarCloud packages
-      uses: actions/cache@v2.1.7
+    - name: "Cache SonarCloud packages"
+      uses: actions/cache@v3
       with:
         path: ~\sonar\cache
         key: ${{ runner.os }}-sonar
         restore-keys: ${{ runner.os }}-sonar
 
-    - name: Cache SonarCloud scanner
+    - name: "Cache SonarCloud scanner"
       id: cache-sonar-scanner
-      uses: actions/cache@v2.1.7
+      uses: actions/cache@v3
       with:
         path: .\.sonar\scanner
         key: ${{ runner.os }}-sonar-scanner
         restore-keys: ${{ runner.os }}-sonar-scanner
 
-    - name: Install SonarCloud scanner
+    - name: "Install SonarCloud scanner"
       if: steps.cache-sonar-scanner.outputs.cache-hit != 'true'
       shell: pwsh
       run: |
         New-Item -Path .\.sonar\scanner -ItemType Directory
         dotnet tool update dotnet-sonarscanner --tool-path .\.sonar\scanner
 
-    - name: Build and analyze
+    - name: "Build and analyze"
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}  # Needed to get PR information, if any
         SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
       shell: pwsh
       run: |
         .\.sonar\scanner\dotnet-sonarscanner begin /k:"${{ secrets.SONAR_PROJECT_KEY }}" /o:"${{ secrets.SONAR_ORGANIZATION }}" /d:sonar.login="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io"
-        dotnet build --configuration Release
-        dotnet test /p:CollectCoverage=true /p:CoverletOutputFormat=opencover
-        .\.sonar\scanner\dotnet-sonarscanner end /d:sonar.login="${{ secrets.SONAR_TOKEN }}"
+        dotnet build
+        dotnet test /p:CollectCoverage=true /p:CoverletOutputFormat=opencover --no-build
+        .\.sonar\scanner\dotnet-sonarscanner end /d:sonar.login="${{ secrets.SONAR_TOKEN }}"

.github/workflows/test-project.yml

@@ -1,34 +1,40 @@
 name: 'Tests'
 
+
+
 on:
-  push:
-    branches:
-      - develop
   pull_request:
     types: [opened, reopened, synchronize]
     branches:
       - main
 
 
+
+env:
+  SDK_VERSION: '6.0.300'
+
+
+
 jobs:
 
   test-project:
-    name: "Testing project"
+    name: "Test nuget"
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v2
+    - name: "Checkout"
+      uses: actions/checkout@v3
 
-    - name: Setup .NET
+    - name: "Setup .NET"
       uses: actions/setup-dotnet@v2
       with:
-        dotnet-version: '6.0.201'
+        dotnet-version: ${{ env.SDK_VERSION }}
 
-    - name: Restore dependencies
+    - name: "Restore dependencies"
       run: dotnet restore
 
-    - name: Build
-      run: dotnet build --no-restore
+    - name: "Build"
+      run: dotnet build --configuration Release --no-restore
 
-    - name: Test
-      run: dotnet test --no-build
+    - name: "Test"
+      run: dotnet test --configuration Release --no-build

CHANGELOG.md

@@ -3,6 +3,17 @@
 
 
 
+## [1.0.1] - 2022-05-28
+[Full Changelog](https://github.com/TechNobre/PowerUtils.AspNetCore.ErrorHandler/compare/v1.0.0...v1.0.1)
+
+
+### Fixes
+
+- Fix `System.IndexOutOfRangeException` when format the properties name to camel case;
+
+
+
+
 ## [1.0.0] - 2022-03-15
 
 - Kickoff;

global.json

@@ -1,5 +1,5 @@
 {
   "sdk": {
-    "version": "6.0.201"
+    "version": "6.0.300"
   }
 }

samples/PowerUtils.AspNetCore.ErrorHandler.Samples/Samples.csproj

@@ -14,13 +14,13 @@
     <PackageReference Include="PowerUtils.AspNetCore.Authentication.BasicAuth" Version="1.0.0" />
     <PackageReference Include="PowerUtils.AspNetCore.Authentication.JwtBearer" Version="1.0.0" />
     <PackageReference Include="PowerUtils.Security" Version="1.1.0" />
-    <PackageReference Include="Swashbuckle.AspNetCore" Version="6.3.0" />
+    <PackageReference Include="Swashbuckle.AspNetCore" Version="6.3.1" />
     <!-- LOGS -->
     <PackageReference Include="Serilog.AspNetCore" Version="5.0.0" />
     <PackageReference Include="Serilog.Sinks.Console" Version="4.0.1" />
     <PackageReference Include="Serilog.Sinks.File" Version="5.0.0" />
     <PackageReference Include="Serilog.Sinks.Async" Version="1.5.0" />
-    <PackageReference Include="Serilog.Exceptions" Version="8.1.0" />
+    <PackageReference Include="Serilog.Exceptions" Version="8.2.0+build.634" />
     <PackageReference Include="Serilog.Enrichers.Environment" Version="2.2.0" />
   </ItemGroup>
 

src/PowerUtils.AspNetCore.ErrorHandler.csproj

@@ -3,6 +3,9 @@
   <PropertyGroup>
     <ProjectGuid>848b072c-e1a1-4fcf-b00a-f14750be758b</ProjectGuid>
 
+    <CurrentYear>$([System.DateTime]::UtcNow.ToString(yyyy))</CurrentYear>
+
+
     <!-- Assembly and projecto details -->
     <!-- https://docs.microsoft.com/en-us/dotnet/standard/frameworks -->
     <TargetFrameworks>net6.0;net5.0;netcoreapp3.1</TargetFrameworks>
@@ -15,19 +18,17 @@
     <PackageId>PowerUtils.AspNetCore.ErrorHandler</PackageId>
     <title>PowerUtils.AspNetCore.ErrorHandler</title>
     <Product>PowerUtils.AspNetCore.ErrorHandler</Product>
-    <Version>1.0.0</Version>
+    <Version>1.0.1</Version>
 
     <Authors>Nelson Nobre</Authors>
     <Company>TechNobre</Company>
 
     <License>MIT</License>
     <PackageLicenseFile>LICENSE</PackageLicenseFile>
-    <Copyright>Copyright © 2022 by TechNobre</Copyright>
+    <Copyright>Copyright © $(CurrentYear) by TechNobre</Copyright>
 
     <Description>Hendler to standardize error responses</Description>
-    <PackageReleaseNotes>
-      Kickoff
-    </PackageReleaseNotes>
+    <PackageReleaseNotes>https://github.com/TechNobre/PowerUtils.AspNetCore.ErrorHandler/blob/main/CHANGELOG.md</PackageReleaseNotes>
     <Summary>Hendler to standardize error responses</Summary>
     <PackageTags>PowerUtils;Utils;Helpers;AspNetCore;ProblemDetails;ErrorHandler</PackageTags>
     <RepositoryUrl>https://github.com/TechNobre/PowerUtils.AspNetCore.ErrorHandler</RepositoryUrl>
@@ -66,23 +67,12 @@
     <PlatformTarget>AnyCPU</PlatformTarget>
     <DebugType>none</DebugType>
     <Optimize>true</Optimize>
-    <DefineConstants>RELEASE;TRACE</DefineConstants>
+    <DefineConstants>RELEASE</DefineConstants>
     <ErrorReport>none</ErrorReport>
     <WarningLevel>4</WarningLevel>
   </PropertyGroup>
 
 
-  <PropertyGroup Condition=" '$(TargetFramework)' == 'netcoreapp3.1' ">
-    <DefineConstants>NETCOREAPP;NETCOREAPP3_1</DefineConstants>
-  </PropertyGroup>
-  <PropertyGroup Condition=" '$(TargetFramework)' == 'net5.0' ">
-    <DefineConstants>NET;NET5</DefineConstants>
-  </PropertyGroup>
-  <PropertyGroup Condition=" '$(TargetFramework)' == 'net6.0' ">
-    <DefineConstants>NET;NET6</DefineConstants>
-  </PropertyGroup>
-
-
   <ItemGroup>
     <None Include="..\LICENSE" Pack="true" PackagePath="" />
   </ItemGroup>

src/ProblemDetailsFactory.cs

@@ -7,7 +7,6 @@
 using Microsoft.AspNetCore.WebUtilities;
 using Microsoft.Extensions.Options;
 using PowerUtils.Net.Constants;
-using PowerUtils.Text;
 
 namespace PowerUtils.AspNetCore.ErrorHandler
 {
@@ -22,16 +21,14 @@ internal static ProblemDetailsResponse Create(HttpContext httpContext)
         {
             var result = new ProblemDetailsResponse();
 
-            result.Status = httpContext.GetStatusCode() ?? 0;
+            result.Status = httpContext.GetStatusCode() ?? 0; // Default value is 0
             result.Type = result.Status.GetStatusCodeLinkOrDefault();
             result.Title = result.Status == 0 ? null : ReasonPhrases.GetReasonPhrase(result.Status);
 
             result.Instance = httpContext.GetRequestEndpoint();
 
             result.TraceID = httpContext.GetCorrelationId();
 
-            result.Errors = new Dictionary<string, string>();
-
             return result;
         }
 
@@ -74,12 +71,6 @@ private IDictionary<string, string> _mappingModelState(ModelStateDictionary mode
 
         private (string Property, string Error) _mappingModelStateError(KeyValuePair<string, ModelStateEntry> modelStateError)
         {
-            var error = modelStateError
-                .Value
-                .Errors
-                .Select(s => s.ErrorMessage)
-                .First();
-
             if(modelStateError.Key.StartsWith("$."))
             {
                 return (
@@ -88,6 +79,12 @@ private IDictionary<string, string> _mappingModelState(ModelStateDictionary mode
                 );
             }
 
+            var error = modelStateError
+                .Value
+                .Errors
+                .Select(s => s.ErrorMessage)
+                .First();
+
             return _checkRequestBody(modelStateError.Key, error);
         }
 
@@ -111,39 +108,9 @@ private string _formatPropertyName(string propertyName)
             => _options.Value.PropertyNamingPolicy switch
             {
                 PropertyNamingPolicy.Original => propertyName,
-                PropertyNamingPolicy.SnakeCase => _formatPropertyToSnakeCase(propertyName),
-                _ => _formatPropertyToCamelCase(propertyName),
+                PropertyNamingPolicy.SnakeCase => propertyName.FormatToSnakeCase(),
+                _ => propertyName.FormatToCamelCase(),
             };
 
-        private static string _formatPropertyToCamelCase(string propertyName)
-        {
-            var propertyParts = propertyName.Split('.');
-            if(propertyParts.Length == 1)
-            {
-                return char.ToLowerInvariant(propertyName[0]) + propertyName[1..];
-            }
-
-
-            for(var count = 0; count < propertyParts.Length; count++)
-            {
-                propertyParts[count] = char.ToLowerInvariant(propertyParts[count][0]) + propertyParts[count][1..];
-            }
-
-
-            return string.Join(".", propertyParts);
-        }
-
-        private static string _formatPropertyToSnakeCase(string propertyName)
-        {
-            var propertyParts = propertyName.Split('.');
-
-            for(var count = 0; count < propertyParts.Length; count++)
-            {
-                propertyParts[count] = propertyParts[count].ToSnakeCase();
-            }
-
-
-            return string.Join(".", propertyParts);
-        }
     }
 }