feat: Add new ExceptionMapper<T>(Status, Property, Code, Description) in options;

Author: NelsonBN

README.md

@@ -110,6 +110,8 @@ public class Startup
         {
             options.ExceptionMapper<DuplicatedException>(exception => StatusCodes.Status409Conflict);
 
+            options.ExceptionMapper<PropertyException>(exception => (400, exception.Property, exception.Code, exception.Message));
+
             options.ExceptionMapper<ModelStatesException>(exception => (
                 exception.Status,
                 exception.Errors.ToDictionary(

samples/PowerUtils.AspNetCore.ErrorHandler.Samples/Controllers/ExceptionsController.cs

@@ -48,5 +48,13 @@ public IActionResult CustomException()
         [HttpGet("timeout-exception")]
         public IActionResult TimeoutException()
             => throw new TimeoutException();
+
+        [HttpGet("property-exception")]
+        public IActionResult PropertyException()
+            => throw new PropertyException("Error validations")
+            {
+                Property = "Prop",
+                Code = "Err",
+            };
     }
 }

samples/PowerUtils.AspNetCore.ErrorHandler.Samples/Exceptions/ModelStatesException.cs

@@ -41,11 +41,4 @@ public DuplicatedException() : base("double")
             };
         }
     }
-
-
-    public abstract class PropertyException : Exception
-    { // TODO: to finish
-        public string Property { get; set; }
-        public string Code { get; set; }
-    }
 }

samples/PowerUtils.AspNetCore.ErrorHandler.Samples/Exceptions/PropertyException.cs

@@ -0,0 +1,13 @@
+using System;
+
+namespace PowerUtils.AspNetCore.ErrorHandler.Samples.Exceptions
+{
+    public class PropertyException : Exception
+    {
+        public PropertyException(string message)
+            : base(message) { }
+
+        public string Property { get; set; }
+        public string Code { get; set; }
+    }
+}

samples/PowerUtils.AspNetCore.ErrorHandler.Samples/Startup.cs

@@ -1,5 +1,4 @@
-using System;
-using System.Linq;
+using System.Linq;
 using Microsoft.AspNetCore.Authentication;
 using Microsoft.AspNetCore.Authentication.JwtBearer;
 using Microsoft.AspNetCore.Builder;
@@ -45,7 +44,7 @@ public void ConfigureServices(IServiceCollection services)
                 options.PropertyNamingPolicy = PropertyNamingPolicy.SnakeCase;
 
                 options.ExceptionMapper<PropertyException>(exception => 599); // Only to test the override a mapping
-                //options.ExceptionMapper<PropertyException>(exception => (exception.Status, new(exception.Property, new()))); // TODO: to finish
+                options.ExceptionMapper<PropertyException>(exception => (400, exception.Property, exception.Code, exception.Message));
 
                 options.ExceptionMapper<ModelStatesException>(exception => (
                     exception.Status,
@@ -58,7 +57,6 @@ public void ConfigureServices(IServiceCollection services)
                 options.ExceptionMapper<CustomException>(exception => 582);
 
                 options.ExceptionMapper<TestException>(exception => StatusCodes.Status503ServiceUnavailable);
-                options.ExceptionMapper<TimeoutException>(exception => StatusCodes.Status504GatewayTimeout);
             });
 
 

src/ErrorHandlerOptions.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Collections.Immutable;
 using Microsoft.AspNetCore.Http;
 
 namespace PowerUtils.AspNetCore.ErrorHandler
@@ -75,6 +76,12 @@ public static void ExceptionMapper<TException>(this ErrorHandlerOptions options,
 
         public static void ExceptionMapper<TException>(this ErrorHandlerOptions options, Func<TException, int> configureMapper)
             where TException : Exception
-            => options.ExceptionMapper<TException>(e => (configureMapper(e), new Dictionary<string, ErrorDetails>()));
+            => options.ExceptionMapper<TException>(e => (configureMapper(e), ImmutableDictionary<string, ErrorDetails>.Empty));
+
+        public static void ExceptionMapper<TException>(this ErrorHandlerOptions options, Func<TException, (int Status, string Property, string Code, string Description)> configureMapper)
+            where TException : Exception => options.ExceptionMapper<TException>(e => (configureMapper(e).Status, new Dictionary<string, ErrorDetails>()
+            {
+                [configureMapper(e).Property ?? ""] = new(configureMapper(e).Code, configureMapper(e).Description)
+            }));
     }
 }

src/Handlers/ExceptionHandlerMiddleware.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Collections.Immutable;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Diagnostics;
 using Microsoft.AspNetCore.Http;
@@ -45,14 +46,20 @@ internal static IApplicationBuilder UseExceptionHandlerMiddleware(this IApplicat
 
                             var options = httpContext.RequestServices.GetRequiredService<IOptions<ErrorHandlerOptions>>();
 
-                            IEnumerable<KeyValuePair<string, ErrorDetails>> errors;
-                            (httpContext.Response.StatusCode, errors) = exception.MappingToStatusCode(options.Value);
-
-                            httpContext.ResetResponse(httpContext.Response.StatusCode);
-                            problemDetails = problemDetailsFactory.Create(httpContext, errors);
-
+                            try
+                            {
+                                IEnumerable<KeyValuePair<string, ErrorDetails>> errors;
+                                (httpContext.Response.StatusCode, errors) = exception.MappingToStatusCode(options.Value);
+                                httpContext.ResetResponse(httpContext.Response.StatusCode);
+                                problemDetails = problemDetailsFactory.Create(httpContext, errors);
 
-                            logger.Error(exception, problemDetails.Instance, problemDetails.Status);
+                                logger.Error(exception, problemDetails.Instance, problemDetails.Status);
+                            }
+                            catch(Exception mappingException)
+                            {
+                                problemDetails = problemDetailsFactory.Create(httpContext, ImmutableDictionary<string, ErrorDetails>.Empty);
+                                logger.Error(mappingException, "Error mapping exception");
+                            }
                         }
 
                         // Write error details in body response

src/LoggerExtensions.cs

@@ -6,6 +6,13 @@ namespace PowerUtils.AspNetCore.ErrorHandler
 {
     internal static class LoggerExtensions
     {
+        public static void Error(this ILogger logger, Exception exception, string message)
+           => logger.LogError(
+               exception,
+               $"[ERROR HANDLER] > {message}"
+           );
+
+
         public static void Error(this ILogger logger, Exception exception, string request, int? statusCode)
             => logger.LogError(
                 exception,

tests/PowerUtils.AspNetCore.ErrorHandler.Tests/Tests/Controllers/ExceptionsControllerTests.cs

@@ -252,5 +252,33 @@ public async void EndpointWithTimeoutException_Request_504StatusCode()
                 "An unexpected error has occurred."
             );
         }
+
+        [Fact]
+        public async void PropertyException_Request_400WithErrors()
+        {
+            // Arrange
+            var requestUri = "/exceptions/property-exception";
+            var options = _testsFixture.GetService<IOptions<ApiBehaviorOptions>>();
+
+
+            // Act
+            (var response, var content) = await _testsFixture.Client.SendGetAsync(requestUri);
+            options.Value.ClientErrorMapping.TryGetValue((int)response.StatusCode, out var clientErrorData);
+
+
+            // Assert
+            response.ValidateResponse(HttpStatusCode.BadRequest);
+
+            content.ValidateContent(
+                HttpStatusCode.BadRequest,
+                clientErrorData,
+                "GET: " + requestUri,
+                "Error validations",
+                new Dictionary<string, ErrorDetails>()
+                {
+                    { "prop", new("Err", "Error validations") }
+                }
+            );
+        }
     }
 }

tests/PowerUtils.AspNetCore.ErrorHandler.Tests/Utils/HttpClientUtils.cs

@@ -18,7 +18,6 @@ internal static class HttpClientUtils
                 endpoint += parameters.ToQueryString();
             }
 
-
             var response = await client.GetAsync(endpoint);
 
             return (