Skip to content

Commit 8416fcf

Browse files
authored
Merge pull request pappasam#239 from pappasam/default-disable-syntax-errors
Default disable syntax errors
2 parents 8f71df9 + cc5c984 commit 8416fcf

File tree

5 files changed

+94
-95
lines changed

5 files changed

+94
-95
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
44

55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7+
## 0.39.0
8+
9+
### Changed
10+
11+
- `jedi-language-server`-powered diagnostics are disabled by default. See: <https://github.com/pappasam/jedi-language-server/issues/187>
12+
713
## 0.38.0
814

915
### Added

README.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ jedi-language-server aims to support Jedi's capabilities and expose them through
4242

4343
### Text Synchronization (for diagnostics)
4444

45+
**Note:** diagnostics are disabled by default because Jedi's syntax checking is not supported for new syntax in Python 3.10+. For a detailed discussion on this topic, please refer to [this issue](https://github.com/pappasam/jedi-language-server/issues/187).
46+
4547
- [textDocument/didChange](https://microsoft.github.io/language-server-protocol/specification#textDocument_didChange)
4648
- [textDocument/didOpen](https://microsoft.github.io/language-server-protocol/specification#textDocument_didOpen)
4749
- [textDocument/didSave](https://microsoft.github.io/language-server-protocol/specification#textDocument_didSave)
@@ -164,7 +166,7 @@ If you are configuring manually, jedi-language-server supports the following [in
164166
"ignorePatterns": []
165167
},
166168
"diagnostics": {
167-
"enable": true,
169+
"enable": false,
168170
"didOpen": true,
169171
"didChange": true,
170172
"didSave": true
@@ -203,9 +205,11 @@ If you are configuring manually, jedi-language-server supports the following [in
203205

204206
See coc-jedi's [configuration instructions](https://github.com/pappasam/coc-jedi#configuration) for an explanation of the above configurations.
205207

206-
## Additional Diagnostics
208+
## Diagnostics
209+
210+
Jedi-powered diagnostics are disabled by default because Jedi's syntax checking is not supported for new syntax in Python 3.10+. For a detailed discussion on this topic, please refer to [this issue](https://github.com/pappasam/jedi-language-server/issues/187).
207211

208-
jedi-langugage-server provides diagnostics about syntax errors, powered by Jedi. If you would like additional diagnostics, we suggest using the powerful [diagnostic-language-server](https://github.com/iamcco/diagnostic-languageserver).
212+
If you would like diagnostics (from [pylint](https://github.com/PyCQA/pylint), [mypy](https://github.com/python/mypy), etc.), we recommend using the powerful [diagnostic-language-server](https://github.com/iamcco/diagnostic-languageserver).
209213

210214
## Code Formatting
211215

jedi_language_server/initialization_options.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class Completion(Model):
3838

3939

4040
class Diagnostics(Model):
41-
enable: bool = True
41+
enable: bool = False
4242
did_open: bool = True
4343
did_save: bool = True
4444
did_change: bool = True

0 commit comments

Comments
 (0)