Skip to content

Commit a2eb8f9

Browse files
Merge branch 'develop' into l10n_develop
2 parents b5f6f49 + 8d969a2 commit a2eb8f9

File tree

17 files changed

+118
-55
lines changed

17 files changed

+118
-55
lines changed

app/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ android {
4141
applicationId = "at.techbee.jtx"
4242
minSdk = 23
4343
targetSdk = 36
44-
versionCode = 215000004
45-
versionName = "2.15.00" // keep -release as a suffix also for release, build flavor adds the suffix e.g. .gplay (e.g. 1.00.00-rc0.gplay)
44+
versionCode = 215010001
45+
versionName = "2.15.01" // keep -release as a suffix also for release, build flavor adds the suffix e.g. .gplay (e.g. 1.00.00-rc0.gplay)
4646
buildConfigField("String", "versionCodename", "\"Love knows no borders \uD83C\uDF08\"")
4747
multiDexEnabled = true
4848
vectorDrawables.useSupportLibrary = true

app/src/main/java/at/techbee/jtx/ui/about/AboutContributors.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,11 @@ fun AboutContributors(
9191
}
9292

9393
item {
94+
val ffgUrl = stringResource(R.string.link_ffg)
95+
9496
ElevatedCard(
9597
onClick = {
96-
context.startActivity(Intent(Intent.ACTION_VIEW, context.getString(R.string.link_ffg).toUri()))
98+
context.startActivity(Intent(Intent.ACTION_VIEW, ffgUrl.toUri()))
9799
},
98100
modifier = Modifier.padding(top = 8.dp)
99101
) {
@@ -111,7 +113,7 @@ fun AboutContributors(
111113
textAlign = TextAlign.Center
112114
)
113115
Text(
114-
text = stringResource(id = R.string.link_ffg),
116+
text = ffgUrl,
115117
style = Typography.titleMedium,
116118
modifier = Modifier
117119
.fillMaxWidth()

app/src/main/java/at/techbee/jtx/ui/about/AboutJtx.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,18 +106,20 @@ fun AboutJtx(modifier: Modifier = Modifier) {
106106
modifier = Modifier.padding(top = 12.dp),
107107
style = Typography.titleMedium,
108108
)
109+
110+
val jtxTermsUrl = stringResource(id = R.string.link_jtx_terms)
109111
TextButton(
110112
content = {
111113
Text(
112-
text = stringResource(id = R.string.link_jtx_terms),
114+
text = jtxTermsUrl,
113115
style = Typography.bodyLarge,
114116
)
115117
},
116118
onClick = {
117119
context.startActivity(
118120
Intent(
119121
Intent.ACTION_VIEW,
120-
context.getString(R.string.link_jtx_terms).toUri()
122+
jtxTermsUrl.toUri()
121123
)
122124
)
123125
}

app/src/main/java/at/techbee/jtx/ui/collections/CollectionsScreen.kt

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@ fun CollectionsScreen(
133133
)
134134
}
135135

136+
val collectionsToastXItemsAdded = stringResource(R.string.collections_toast_x_items_added, resultImportTxtFilepaths.size)
136137
LaunchedEffect(resultImportTxtFilepaths, importCollection, importModule) {
137138
// import from file uri
138139
if(importModule == null) {
@@ -165,7 +166,7 @@ fun CollectionsScreen(
165166
}
166167
Toast.makeText(
167168
context,
168-
context.getString(R.string.collections_toast_x_items_added, resultImportTxtFilepaths.size),
169+
collectionsToastXItemsAdded,
169170
Toast.LENGTH_LONG
170171
).show()
171172
importCollection = null
@@ -198,11 +199,12 @@ fun CollectionsScreen(
198199

199200
// show result
200201
val insertResult by collectionsViewModel.resultInsertedFromICS.observeAsState()
202+
val snackbarTextXItemsAdded = stringResource(id = R.string.collections_snackbar_x_items_added, insertResult?.first?:0, insertResult?.second?:0)
201203
LaunchedEffect(insertResult) {
202204
insertResult?.let {
203205
Toast.makeText(
204206
context,
205-
context.getString(R.string.collections_snackbar_x_items_added, it.first, it.second),
207+
snackbarTextXItemsAdded,
206208
Toast.LENGTH_LONG
207209
).show()
208210
snackbarHostState.currentSnackbarData?.dismiss()
@@ -219,10 +221,13 @@ fun CollectionsScreen(
219221
onDismiss = { showCollectionsAddDialog = false }
220222
)
221223

224+
val biometricPromptTitle = stringResource(id = R.string.collections_biometric_protected_entries_locked_title)
225+
val biometricPromptSubtitle = stringResource(id = R.string.collections_biometric_protected_entries_locked_subtitle)
226+
val biometricPromptCancel = stringResource(id = R.string.cancel)
222227
val biometricPromptInfo: BiometricPrompt.PromptInfo = BiometricPrompt.PromptInfo.Builder()
223-
.setTitle(context.getString(R.string.collections_biometric_protected_entries_locked_title))
224-
.setSubtitle(context.getString(R.string.collections_biometric_protected_entries_locked_subtitle))
225-
.setNegativeButtonText(context.getString(R.string.cancel))
228+
.setTitle(biometricPromptTitle)
229+
.setSubtitle(biometricPromptSubtitle)
230+
.setNegativeButtonText(biometricPromptCancel)
226231
.build()
227232

228233
Scaffold(

app/src/main/java/at/techbee/jtx/ui/detail/DetailBottomAppBar.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -365,13 +365,14 @@ fun DetailBottomAppBar(
365365
}
366366
},
367367
floatingActionButton = {
368-
// TODO(b/228588827): Replace with Secondary FAB when available.
368+
val sanckbarBuyproRemoteEntriesBlockedText = stringResource(id = R.string.buypro_snackbar_remote_entries_blocked)
369+
369370
FloatingActionButton(
370371
onClick = {
371372
if (!isProActionAvailable)
372373
Toast.makeText(
373374
context,
374-
context.getText(R.string.buypro_snackbar_remote_entries_blocked),
375+
sanckbarBuyproRemoteEntriesBlockedText,
375376
Toast.LENGTH_LONG
376377
).show()
377378
else if (!collection.readonly)

app/src/main/java/at/techbee/jtx/ui/detail/DetailsCardDates.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,8 @@ fun DetailsCardDates(
6363
var completed by remember { mutableStateOf(icalObject.completed) }
6464
var completedTimezone by remember { mutableStateOf(icalObject.completedTimezone) }
6565

66+
val validationErrorToastText = stringResource(id = R.string.edit_validation_errors_dialog_due_date_before_dtstart)
67+
6668
ElevatedCard(modifier = modifier) {
6769
Column(
6870
modifier = Modifier.fillMaxWidth().padding(if(isEditMode) 4.dp else 0.dp),
@@ -76,7 +78,7 @@ fun DetailsCardDates(
7678
isEditMode = isEditMode,
7779
onDateTimeChanged = { datetime, timezone ->
7880
if((due ?: Long.MAX_VALUE) <= (datetime ?: Long.MIN_VALUE)) {
79-
Toast.makeText(context, context.getText(R.string.edit_validation_errors_dialog_due_date_before_dtstart), Toast.LENGTH_LONG).show()
81+
Toast.makeText(context, validationErrorToastText, Toast.LENGTH_LONG).show()
8082
} else {
8183
dtstart = datetime
8284
dtstartTimezone = timezone
@@ -120,7 +122,7 @@ fun DetailsCardDates(
120122
if((datetime ?: Long.MAX_VALUE) <= (dtstart ?: Long.MIN_VALUE)) {
121123
Toast.makeText(
122124
context,
123-
context.getText(R.string.edit_validation_errors_dialog_due_date_before_dtstart),
125+
validationErrorToastText,
124126
Toast.LENGTH_LONG
125127
).show()
126128
} else {

app/src/main/java/at/techbee/jtx/ui/detail/DetailsCardRecur.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
package at.techbee.jtx.ui.detail
1010

11+
import android.annotation.SuppressLint
1112
import androidx.compose.animation.AnimatedVisibility
1213
import androidx.compose.foundation.layout.Arrangement
1314
import androidx.compose.foundation.layout.Column
@@ -75,6 +76,7 @@ import java.util.Locale
7576
import kotlin.math.absoluteValue
7677

7778

79+
@SuppressLint("LocalContextGetResourceValueCall")
7880
@OptIn(ExperimentalLayoutApi::class)
7981
@Composable
8082
fun DetailsCardRecur(

app/src/main/java/at/techbee/jtx/ui/detail/DetailsScreen.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,6 +413,8 @@ fun DetailsScreen(
413413
)
414414
}
415415
)
416+
417+
val copiedToClipboardToastMessage = stringResource(id = R.string.menu_view_copy_to_clipboard_copied)
416418
DropdownMenuItem(
417419
text = { Text(text = stringResource(id = R.string.menu_view_copy_to_clipboard)) },
418420
onClick = {
@@ -427,7 +429,7 @@ fun DetailsScreen(
427429
val clipboardManager = context.getSystemService(CLIPBOARD_SERVICE) as ClipboardManager
428430
clipboardManager.setPrimaryClip(ClipData.newPlainText("", text))
429431
if (Build.VERSION.SDK_INT <= Build.VERSION_CODES.S_V2) // Only show a toast for Android 12 and lower.
430-
detailViewModel.toastMessage.value = context.getString(R.string.menu_view_copy_to_clipboard_copied)
432+
detailViewModel.toastMessage.value = copiedToClipboardToastMessage
431433
}
432434
}
433435
menuExpanded.value = false

app/src/main/java/at/techbee/jtx/ui/donate/DonateScreen.kt

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,17 +141,18 @@ fun DonateScreenContent(modifier: Modifier = Modifier) {
141141
textAlign = TextAlign.Center
142142
)
143143

144+
val paypalUrl = stringResource(id = R.string.link_paypal)
144145
TextButton(onClick = {
145146
context.startActivity(
146147
Intent(
147148
Intent.ACTION_VIEW,
148-
context.getString(R.string.link_paypal).toUri()
149+
paypalUrl.toUri()
149150
)
150151
)
151152
}) {
152153
Image(
153154
painter = painterResource(id = R.drawable.paypal),
154-
contentDescription = null,
155+
contentDescription = paypalUrl,
155156
modifier = Modifier
156157
.size(200.dp, 100.dp)
157158
)
@@ -165,10 +166,11 @@ fun DonateScreenContent(modifier: Modifier = Modifier) {
165166
textAlign = TextAlign.Center
166167
)
167168

169+
val contributeUrl = stringResource(id = R.string.link_jtx_contribute)
168170
TextButton(
169171
content = {
170172
Text(
171-
text = stringResource(id = R.string.link_jtx_donate),
173+
text = contributeUrl,
172174
style = Typography.titleLarge,
173175
fontWeight = FontWeight.Bold,
174176
textAlign = TextAlign.Center
@@ -179,7 +181,7 @@ fun DonateScreenContent(modifier: Modifier = Modifier) {
179181
context.startActivity(
180182
Intent(
181183
Intent.ACTION_VIEW,
182-
context.getString(R.string.link_jtx_donate).toUri()
184+
contributeUrl.toUri()
183185
)
184186
)
185187
}

app/src/main/java/at/techbee/jtx/ui/list/ListScreenKanban.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
package at.techbee.jtx.ui.list
1010

11+
import android.annotation.SuppressLint
1112
import android.content.Context.VIBRATOR_MANAGER_SERVICE
1213
import android.content.Context.VIBRATOR_SERVICE
1314
import android.media.MediaPlayer
@@ -66,6 +67,7 @@ import kotlin.math.abs
6667
import kotlin.math.roundToInt
6768

6869

70+
@SuppressLint("LocalContextGetResourceValueCall")
6971
@OptIn(ExperimentalFoundationApi::class)
7072
@Composable
7173
fun ListScreenKanban(

0 commit comments

Comments
 (0)