Remove async, rule loading speed ~x2, pragmas for optimal perf

Rule loading is roughly twice as fast over the previous version thanks to prepared statements.

Removed async functions.

Add pragmas for optimal performance.

Add new indexes for optimal performance.

Author: TechnikEmpire

.gitignore

@@ -253,3 +253,6 @@ paket-files/
 # JetBrains Rider
 .idea/
 *.sln.iml
+
+# Coverity
+**/cov-int/

DistillNET/DistillNET/DistillNET.csproj

@@ -9,12 +9,12 @@
     <RepositoryUrl>https://github.com/TechnikEmpire/DistillNET</RepositoryUrl>
     <Description>DistillNET is a library for matching and filtering HTTP requests URLs using the Adblock Plus Filter format.</Description>
     <Copyright>Copyright © 2017 - 2018 Jesse Nicholson</Copyright>
-    <Version>1.5.0</Version>
+    <Version>1.5.1</Version>
     <Authors>Jesse Nicholson</Authors>
     <Company>Technik Empire</Company>
     <PackageTags>DistillNET Adblock AdblockPlus Adblock-Plus URL-Filter URL-Filtering Content-Filter Filter</PackageTags>
-    <PackageReleaseNotes>Version fix. Bump minor because of configurable feature addition.</PackageReleaseNotes>
-    <AssemblyVersion>1.5.0.0</AssemblyVersion>
+    <PackageReleaseNotes>Rule loading is ~twice as fast as previous version now thanks to prepared statements.</PackageReleaseNotes>
+    <AssemblyVersion>1.5.1.0</AssemblyVersion>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
@@ -26,8 +26,8 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.Data.SQLite" Version="2.0.1" />
-    <PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="2.0.1" />
+    <PackageReference Include="Microsoft.Data.SQLite" Version="2.1.0-rc1-final" />
+    <PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="2.0.2" />
   </ItemGroup>
 
 </Project>

DistillNET/DistillNET/DistillNET/AbpFormatRuleParser.cs

@@ -20,12 +20,12 @@ public class AbpFormatRuleParser
         /// <summary>
         /// Delimiters used for splitting URL filtering options.
         /// </summary>
-        private static char[] s_optionsDelim = new[] { ',' };
+        private static readonly char[] s_optionsDelim = new[] { ',' };
 
         /// <summary>
         /// Delimiters used for splitting domains specified in the URL filtering options "domains".
         /// </summary>
-        private static char[] s_domainsDelim = new[] { '|' };
+        private static readonly char[] s_domainsDelim = new[] { '|' };
 
         internal class OptionsDictComparer : IEqualityComparer<string>
         {
@@ -368,13 +368,14 @@ private Filter ParseUrlFilter(string rule, int optionsStartOffset, bool hasOptio
                         }
                     }
                 }
+
 #endif
 
+
                 // Parse out the rest of the options.
-                UrlFilter.UrlFilterOptions asOpt;
-                foreach(var opt in allOptions)
-                {   
-                    if(s_optionsMap.TryGetValue(opt, out asOpt))
+                foreach (var opt in allOptions)
+                {
+                    if (s_optionsMap.TryGetValue(opt, out UrlFilter.UrlFilterOptions asOpt))
                     {
                         enumOptions |= asOpt;
                         enumOptions &= ~UrlFilter.UrlFilterOptions.None;
@@ -466,8 +467,7 @@ private Filter ParseUrlFilter(string rule, int optionsStartOffset, bool hasOptio
                             break;
                         }
 
-                        Uri parsedUri = null;
-                        if(Uri.TryCreate(anchoredAddress, UriKind.Absolute, out parsedUri))
+                        if (Uri.TryCreate(anchoredAddress, UriKind.Absolute, out Uri parsedUri))
                         {
                             applicableDomains.Add(parsedUri.Host);
                         }