Skip to content

Commit 0942655

Browse files
authored
Merge pull request #2740 from TechnologyEnhancedLearning/Develop/Fix/TD-4320-Supervisor-emails-on-ManageSupervisors-list
TD-4320-Supervisor emails should be shown on 'Manage Supervisors' list/ 'Quick add'
2 parents db2b3bc + a49090b commit 0942655

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

DigitalLearningSolutions.Data/DataServices/SelfAssessmentDataService/CompetencyDataService.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ public IEnumerable<Competency> GetResultSupervisorVerifications(int selfAssessme
269269
const string supervisorFields = @"
270270
LAR.EmailSent,
271271
LAR.Requested AS SupervisorVerificationRequested,
272-
COALESCE(au.Forename + ' ' + au.Surname + (CASE WHEN au.Active = 1 THEN '' ELSE ' (Inactive)' END), sd.SupervisorEmail) AS SupervisorName,
272+
au.Forename + ' ' + au.Surname + (CASE WHEN au.Active = 1 THEN '' ELSE ' (Inactive)' END) + ' (' + sd.SupervisorEmail + ')' AS SupervisorName,
273273
au.CentreName,
274274
SelfAssessmentResultSupervisorVerificationId AS SupervisorVerificationId,
275275
CandidateAssessmentSupervisorID";

DigitalLearningSolutions.Web/Views/LearningPortal/SelfAssessments/ManageSupervisors.cshtml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,9 @@
6161
<tr role="row" class="nhsuk-table__row">
6262
<td class="nhsuk-table__cell">
6363
<span class="nhsuk-table-responsive__heading">Name/role </span>
64-
@supervisor.SupervisorName, @supervisor.RoleName
65-
64+
<span class="text-wrap word-break">
65+
@supervisor.SupervisorName (@supervisor.SupervisorEmail), @supervisor.RoleName
66+
</span>
6667
</td>
6768
<td class="nhsuk-table__cell">
6869
<span class="nhsuk-table-responsive__heading">Centre </span>
@@ -110,7 +111,9 @@ else
110111
<tr role="row" class="nhsuk-table__row">
111112
<td class="nhsuk-table__cell">
112113
<span class="nhsuk-table-responsive__heading">Name/role </span>
113-
@supervisor.SupervisorName, @supervisor.RoleName
114+
<span class="text-wrap word-break">
115+
@supervisor.SupervisorName (@supervisor.SupervisorEmail), @supervisor.RoleName
116+
</span>
114117
</td>
115118
<td class="nhsuk-table__cell">
116119
<span class="nhsuk-table-responsive__heading">Centre </span>

DigitalLearningSolutions.Web/Views/LearningPortal/SelfAssessments/ReviewConfirmationRequests.cshtml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,10 @@
7777
</td>
7878
<td role="cell" class="nhsuk-table__cell nhsuk-u-font-size-16">
7979
<span class="nhsuk-table-responsive__heading">Request </span>
80-
@competency.SupervisorName (@competency.CentreName)<br />
81-
@competency.SupervisorVerificationRequested?.ToString("dd/MM/yyyy")<br />
80+
<span class="text-wrap word-break">
81+
@competency.SupervisorName @competency.CentreName<br />
82+
@competency.SupervisorVerificationRequested?.ToString("dd/MM/yyyy")<br />
83+
</span>
8284
<div class="nhsuk-u-one-half-tablet" style="white-space: nowrap;">
8385
<div class="nhsuk-grid-row nhsuk-u-padding-0">
8486
@if (competency.EmailSent.HasValue && clockUtility.UtcNow.Subtract(competency.EmailSent.Value) > TimeSpan.FromHours(1))

0 commit comments

Comments
 (0)