Skip to content

Commit 23166a1

Browse files
authored
Merge pull request #2145 from TechnologyEnhancedLearning/Develop/Fixes/TD-2524_Issue_when_Learner_changed_answers_of_self_assessment_before_resending_the_sign_off
TD-2524 show resend link only when all assessments are in confirmed state and sign off button when all results are confirmed
2 parents 5a3c94d + 9132dc1 commit 23166a1

File tree

3 files changed

+15
-10
lines changed

3 files changed

+15
-10
lines changed

DigitalLearningSolutions.Web/Views/LearningPortal/SelfAssessments/SelfAssessmentOverview.cshtml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,8 @@
155155
model="@competencySummaries"
156156
view-data="@(new ViewDataDictionary(ViewData) { { "IsSupervisorResultsReviewed", Model.SelfAssessment.IsSupervisorResultsReviewed } })" />
157157
<h2>@Model.SelfAssessment.SignOffRoleName Sign-off</h2>
158-
<partial name="../../Supervisor/Shared/_SupervisorSignOffSummary.cshtml" model="Model.SupervisorSignOffs" />
158+
<partial name="../../Supervisor/Shared/_SupervisorSignOffSummary.cshtml" model="Model.SupervisorSignOffs"
159+
view-data="@(new ViewDataDictionary(ViewData) { { "IsAllCompetencyConfirmed", competencySummaries.Sum(c => (int)c["questionsCount"]) == competencySummaries.Sum(c => (int)c["verifiedCount"]) }})" />
159160
@if (Model.AllQuestionsVerifiedOrNotRequired)
160161
{
161162
@if (!Model.SupervisorSignOffs.Any())

DigitalLearningSolutions.Web/Views/Supervisor/ReviewSelfAssessment.cshtml

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -85,16 +85,20 @@
8585
@if (!Model.ExportToExcelHide)
8686
{
8787
<a class="nhsuk-button nhsuk-button--secondary float-right"
88-
asp-route-candidateAssessmentId="@Model.CandidateAssessmentId"
89-
asp-route-selfAssessmentName="@Model.DelegateSelfAssessment.RoleName"
90-
asp-route-delegateUserID="@Model.DelegateSelfAssessment.DelegateUserID"
91-
asp-route-delegateName="@Model.SupervisorDelegateDetail.FirstName @Model.SupervisorDelegateDetail.LastName"
92-
asp-action="ExportCandidateAssessment"
93-
role="button">
88+
asp-route-candidateAssessmentId="@Model.CandidateAssessmentId"
89+
asp-route-selfAssessmentName="@Model.DelegateSelfAssessment.RoleName"
90+
asp-route-delegateUserID="@Model.DelegateSelfAssessment.DelegateUserID"
91+
asp-route-delegateName="@Model.SupervisorDelegateDetail.FirstName @Model.SupervisorDelegateDetail.LastName"
92+
asp-action="ExportCandidateAssessment"
93+
role="button">
9494
Export to Excel
9595
</a>
9696
}
97-
@if (Model.DelegateSelfAssessment.SignOffRequested > 0)
97+
@if (
98+
Model.DelegateSelfAssessment.SignOffRequested > 0 &&
99+
Model.DelegateSelfAssessment.ResultsVerificationRequests == 0 &&
100+
competencySummaries.Sum(c => (int)c["questionsCount"]) == competencySummaries.Sum(c => (int)c["verifiedCount"])
101+
)
98102
{
99103
<a role="button" asp-action="SignOffProfileAssessment" asp-route-candidateAssessmentId="@Model.DelegateSelfAssessment.ID" asp-route-supervisorDelegateId="@Model.SupervisorDelegateDetail.ID" class="nhsuk-button">Sign-off self assessment</a>
100104
}
@@ -200,7 +204,7 @@
200204
{
201205
<div class="nhsuk-u-margin-top-4">
202206
<h3>Self Assessment Sign-off Status</h3>
203-
<partial name="Shared/_SupervisorSignOffSummary" model="@Model.SupervisorSignOffs" />
207+
<partial name="Shared/_SupervisorSignOffSummary" model="@Model.SupervisorSignOffs" view-data="@(new ViewDataDictionary(ViewData) { { "IsAllCompetencyConfirmed", true }})" />
204208
</div>
205209
}
206210
@if (Model.CompetencyGroups.Any())

DigitalLearningSolutions.Web/Views/Supervisor/Shared/_SupervisorSignOffSummary.cshtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
{
4949
@if (Model.FirstOrDefault().EmailSent == null || Model.FirstOrDefault().EmailSent.Value.ToShortDateString() != ClockUtility.UtcNow.ToShortDateString())
5050
{
51-
@if (ViewContext.RouteData.Values.ContainsKey("vocabulary"))
51+
@if (ViewContext.RouteData.Values.ContainsKey("vocabulary") && (bool)ViewData["IsAllCompetencyConfirmed"])
5252
{
5353
<a asp-action="SendRequestSignOffReminder" asp-route-candidateAssessmentSupervisorVerificationId="@Model.FirstOrDefault().ID" asp-route-vocabulary="@ViewContext.RouteData.Values["vocabulary"]" asp-route-candidateAssessmentSupervisorId="@Model.FirstOrDefault().CandidateAssessmentSupervisorID" asp-route-selfAssessmentId="@ViewContext.RouteData.Values["selfAssessmentId"]">Resend</a>
5454
}

0 commit comments

Comments
 (0)