Skip to content

Commit 2984002

Browse files
Auldrin-Possakevwhitt-hee
authored andcommitted
TD-4975-Todo items for requested signoffs/confirmation are filtered by admin category
1 parent efeae28 commit 2984002

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

DigitalLearningSolutions.Data/DataServices/SupervisorDataService.cs

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -640,8 +640,11 @@ public IEnumerable<SupervisorDashboardToDoItem> GetSupervisorDashboardToDoItemsF
640640
SelfAssessments AS sa ON ca.SelfAssessmentID = sa.ID INNER JOIN
641641
SupervisorDelegates AS sd ON cas.SupervisorDelegateId = sd.ID INNER JOIN
642642
CandidateAssessmentSupervisorVerifications AS casv ON cas.ID = casv.CandidateAssessmentSupervisorID INNER JOIN
643-
Users AS u ON ca.DelegateUserID = u.ID
644-
WHERE (sd.SupervisorAdminID = @adminId) AND (casv.Verified IS NULL) AND (cas.Removed IS NULL) AND (sd.Removed IS NULL)", new { adminId }
643+
Users AS u ON ca.DelegateUserID = u.ID INNER JOIN
644+
AdminAccounts As aa ON sd.SupervisorAdminID = aa.ID
645+
WHERE (sd.SupervisorAdminID = @adminId) AND (casv.Verified IS NULL) AND (cas.Removed IS NULL)
646+
AND (sd.Removed IS NULL)
647+
AND (aa.CategoryID is null or sa.CategoryID = aa.CategoryID)", new { adminId }
645648
);
646649
}
647650
public IEnumerable<SupervisorDashboardToDoItem> GetSupervisorDashboardToDoItemsForRequestedReviews(int adminId)
@@ -659,8 +662,10 @@ public IEnumerable<SupervisorDashboardToDoItem> GetSupervisorDashboardToDoItemsF
659662
SELECT TOP 1 sar2.DateTime
660663
FROM SelfAssessmentResults AS sar2
661664
WHERE sar2.ID = sar.ID AND sar2.SelfAssessmentID = sar.SelfAssessmentID AND sar2.CompetencyID = co.ID AND sar2.Result != 0 ORDER BY sar2.ID DESC
662-
)
665+
) INNER JOIN
666+
AdminAccounts AS aa ON sd.SupervisorAdminID = aa.ID
663667
WHERE (sd.SupervisorAdminID = @adminId) AND (cas.Removed IS NULL) AND (sasv.Verified IS NULL) AND (sd.Removed IS NULL)
668+
AND (aa.CategoryID is null or sa.CategoryID = aa.CategoryID)
664669
GROUP BY sa.ID, ca.ID, sd.ID, u.FirstName, u.LastName, sa.Name,cast(sasv.Requested as date)", new { adminId }
665670
);
666671
}

0 commit comments

Comments
 (0)