TD-3885 Correcting if condition to check for tempdata base url

rshrirohit · rshrirohit · commit 2d89466488b4 · 2024-05-21T12:03:28.000+01:00
diff --git a/DigitalLearningSolutions.Web/Controllers/TrackingSystem/Delegates/AllDelegatesController.cs b/DigitalLearningSolutions.Web/Controllers/TrackingSystem/Delegates/AllDelegatesController.cs
@@ -98,7 +98,7 @@ public IActionResult Index(
             var CurrentSiteBaseUrl = configuration.GetCurrentSystemBaseUrl();
 
             if (((TempData["allDelegatesCentreId"] != null && TempData["allDelegatesCentreId"].ToString() != User.GetCentreId().ToString())
-                     || (TempData["LastBaseUrl"].ToString() != CurrentSiteBaseUrl)) && existingFilterString != null)
+                     || (TempData["LastBaseUrl"] != null && (TempData["LastBaseUrl"].ToString() != CurrentSiteBaseUrl))) && existingFilterString != null)
             {
                 if (existingFilterString.Contains("Answer"))
                     existingFilterString = FilterHelper.RemoveNonExistingPromptFilters(availableFilters, existingFilterString);

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ public IActionResult Index(`
`98`	`98`	`var CurrentSiteBaseUrl = configuration.GetCurrentSystemBaseUrl();`
`99`	`99`
`100`	`100`	`if (((TempData["allDelegatesCentreId"] != null && TempData["allDelegatesCentreId"].ToString() != User.GetCentreId().ToString())`
`101`		`- \|\| (TempData["LastBaseUrl"].ToString() != CurrentSiteBaseUrl)) && existingFilterString != null)`
	`101`	`+ \|\| (TempData["LastBaseUrl"] != null && (TempData["LastBaseUrl"].ToString() != CurrentSiteBaseUrl))) && existingFilterString != null)`
`102`	`102`	`{`
`103`	`103`	`if (existingFilterString.Contains("Answer"))`
`104`	`104`	`existingFilterString = FilterHelper.RemoveNonExistingPromptFilters(availableFilters, existingFilterString);`