Merge pull request #2164 from TechnologyEnhancedLearning/Develop/Fixes/TD-2408-AddedCheckForDuplicateCentreInEditScreen

TD-2408 Added a condition for duplicate centre in edit centre details and added a corresponding web test.

Author: rshrirohit

DigitalLearningSolutions.Web.Tests/Controllers/SuperAdmin/CentresControllerTests.cs

@@ -62,6 +62,8 @@ public void Cleanup()
         public void EditCentreDetails_updates_centre_and_redirects_with_successful_save()
         {
             // Given
+            IEnumerable<(int, string)> centresList = new List<(int, string)> { (374, "##HEE Demo Centre1##") };
+            A.CallTo(() => centresDataService.GetAllCentres(false)).Returns(centresList);
             var model = new EditCentreDetailsSuperAdminViewModel
             {
                 CentreId = 374,
@@ -91,6 +93,46 @@ public void EditCentreDetails_updates_centre_and_redirects_with_successful_save(
                                                 .MustHaveHappenedOnceExactly();
         }
 
+        [Test]
+        public void EditCentreDetails_results_DuplicateCentre_error()
+        {
+            // Given
+            IEnumerable<(int, string)> centresList = new List<(int, string)> { (374, "##HEE Demo Centre##") };
+            A.CallTo(() => centresDataService.GetAllCentres(false)).Returns(centresList);
+            var model = new EditCentreDetailsSuperAdminViewModel
+            {
+                CentreId = 374,
+                CentreName = "##HEE Demo Centre##",
+                CentreTypeId = 1,
+                CentreType = "NHS Organisation",
+                RegionName = "National",
+                CentreEmail = "[email protected]",
+                IpPrefix = "12.33.4",
+                ShowOnMap = true,
+                RegionId = 13
+            };
+
+            // When
+            var result = controller.EditCentreDetails(model);            
+            // Then
+            result.Should().BeViewResult();
+            controller.ModelState.IsValid.Should().BeFalse();
+            var centreNameErrors = controller.ModelState["CentreName"].Errors;
+            centreNameErrors.Should().NotBeEmpty();
+            centreNameErrors.Should().Contain(error => error.ErrorMessage ==
+            "The centre name you have entered already exists, please enter a different centre name");
+
+            A.CallTo(() => centresDataService.UpdateCentreDetailsForSuperAdmin(
+                                                model.CentreId,
+                                                model.CentreName,
+                                                model.CentreTypeId,
+                                                model.RegionId,
+                                                model.CentreEmail,
+                                                model.IpPrefix,
+                                                model.ShowOnMap))
+                                                .MustNotHaveHappened();
+        }
+
         [Test]
         public void AddCentre_adds_centre_and_redirects_with_successful_save()
         {

DigitalLearningSolutions.Web/Controllers/SuperAdmin/Centres/CentresController.cs

@@ -227,6 +227,12 @@ public IActionResult EditCentreDetails(int centreId = 0)
         [Route("SuperAdmin/Centres/{centreId=0:int}/EditCentreDetails")]
         public IActionResult EditCentreDetails(EditCentreDetailsSuperAdminViewModel model)
         {
+            bool isCentreNamePresent = centresDataService.GetAllCentres().Any(center => center.Item2 == model.CentreName);
+            if (isCentreNamePresent)
+            {
+                ModelState.AddModelError("CentreName", CommonValidationErrorMessages.CentreNameAlreadyExist);
+            }
+
             if (!ModelState.IsValid)
             {
                 var regions = regionDataService.GetRegionsAlphabetical().ToList();